Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Govindapillai, Vinod" <vinod.govindapillai@intel.com>
Subject: Re: [PATCH v8 5/5] drm/i915/hotplug: avoid HPD polling if the device is PME capable
Date: Tue, 15 Sep 2026 12:55:55 +0000	[thread overview]
Message-ID: <def231e772cbe95b67aafe6b52ab8ac9787f25f3.camel@intel.com> (raw)
In-Reply-To: <20260915092518.639448-6-vinod.govindapillai@intel.com>

On Tue, 2026-09-15 at 12:25 +0300, Vinod Govindapillai wrote:
> In supported devices, HPDs can generate PME and which in turn
> can invoke runtime resume calls for xe. No need to keep the
> HPD polling in such PME capable devices.
> 
> v2: use intel_display_rpm_pme_enabled() directly (JaniN)
> 
> Bspec: 52979, 52980, 68857, 68867, 68970
> Assisted-by: GitHub_Copilot:claude-opus-5
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_hotplug.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c
> b/drivers/gpu/drm/i915/display/intel_hotplug.c
> index 970aa95ee344..d095eb13dc06 100644
> --- a/drivers/gpu/drm/i915/display/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
> @@ -867,6 +867,11 @@ void intel_hpd_poll_enable(struct intel_display
> *display)
>  	if (!HAS_DISPLAY(display) ||
> !intel_display_device_enabled(display))
>  		return;
>  
> +	if (intel_display_rpm_pme_enabled(display)) {
> +		drm_dbg_kms(display->drm, "PME wake capable device,
> skipping HPD polling.\n");
> +		return;
> +	}
> +
>  	WRITE_ONCE(display->hotplug.poll_enabled, true);
>  
>  	/*


  reply	other threads:[~2026-09-15 12:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15  9:25 [PATCH v8 0/5] pm_pme support on display hotplug Vinod Govindapillai
2026-09-15  9:25 ` [PATCH v8 1/5] drm/xe/pm: introduce PM PME support Vinod Govindapillai
2026-09-15 12:27   ` Hogander, Jouni
2026-09-16 14:16     ` Rodrigo Vivi
2026-09-15  9:25 ` [PATCH v8 2/5] drm/i915: add pme_enabled() to the parent interface Vinod Govindapillai
2026-09-15 12:38   ` Hogander, Jouni
2026-09-15  9:25 ` [PATCH v8 3/5] drm/i915/xe: plug the pme_enabed implementation for xe Vinod Govindapillai
2026-09-15 12:39   ` Hogander, Jouni
2026-09-15  9:25 ` [PATCH v8 4/5] drm/i915/irq: conditional HPD IRQ resets based on PME capability Vinod Govindapillai
2026-09-15  9:43   ` sashiko-bot
2026-09-15 12:55   ` Hogander, Jouni
2026-09-15  9:25 ` [PATCH v8 5/5] drm/i915/hotplug: avoid HPD polling if the device is PME capable Vinod Govindapillai
2026-09-15 12:55   ` Hogander, Jouni [this message]
2026-09-15 11:01 ` ✓ i915.CI.BAT: success for pm_pme support on display hotplug (rev8) Patchwork
2026-09-15 17:10 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=def231e772cbe95b67aafe6b52ab8ac9787f25f3.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=vinod.govindapillai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox