* [Intel-gfx] [PATCH i-g-t] gem_ctx_persistence: adjust reset timeout
@ 2022-09-23 16:01 Andrzej Hajda
2022-09-26 8:57 ` [Intel-gfx] [igt-dev] " Das, Nirmoy
2022-10-04 10:57 ` [Intel-gfx] " Kamil Konieczny
0 siblings, 2 replies; 3+ messages in thread
From: Andrzej Hajda @ 2022-09-23 16:01 UTC (permalink / raw)
To: intel-gfx, igt-dev; +Cc: Chris Wilson, Andrzej Hajda
Tests on DG2 show that context cancel can take even 350ms,
due to error state capturing in guc_handle_context_reset.
Since it happens only in debug mode and tests runs in debug mode
it should be fine to adjust the timeout.
Let's double this value, to be on safe side.
It should fix multiple test timeout failures.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1551
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5891
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3952
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
tests/i915/gem_ctx_persistence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c
index 50196edb19f..a844439de19 100644
--- a/tests/i915/gem_ctx_persistence.c
+++ b/tests/i915/gem_ctx_persistence.c
@@ -1214,7 +1214,7 @@ static void do_test(void (*test)(int i915, const intel_ctx_cfg_t *cfg,
if (timeout != -1) {
igt_require(gem_engine_property_printf(i915, name,
ATTR, "%d", 50) > 0);
- reset_timeout_ms = 200;
+ reset_timeout_ms = 700;
}
test(i915, cfg, engine);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] gem_ctx_persistence: adjust reset timeout
2022-09-23 16:01 [Intel-gfx] [PATCH i-g-t] gem_ctx_persistence: adjust reset timeout Andrzej Hajda
@ 2022-09-26 8:57 ` Das, Nirmoy
2022-10-04 10:57 ` [Intel-gfx] " Kamil Konieczny
1 sibling, 0 replies; 3+ messages in thread
From: Das, Nirmoy @ 2022-09-26 8:57 UTC (permalink / raw)
To: Andrzej Hajda, intel-gfx, igt-dev; +Cc: Chris Wilson
Acked-by: Nirmoy Das <nirmoy.das@intel.com>
On 9/23/2022 6:01 PM, Andrzej Hajda wrote:
> Tests on DG2 show that context cancel can take even 350ms,
> due to error state capturing in guc_handle_context_reset.
> Since it happens only in debug mode and tests runs in debug mode
> it should be fine to adjust the timeout.
> Let's double this value, to be on safe side.
> It should fix multiple test timeout failures.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1551
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5891
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3952
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
> tests/i915/gem_ctx_persistence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c
> index 50196edb19f..a844439de19 100644
> --- a/tests/i915/gem_ctx_persistence.c
> +++ b/tests/i915/gem_ctx_persistence.c
> @@ -1214,7 +1214,7 @@ static void do_test(void (*test)(int i915, const intel_ctx_cfg_t *cfg,
> if (timeout != -1) {
> igt_require(gem_engine_property_printf(i915, name,
> ATTR, "%d", 50) > 0);
> - reset_timeout_ms = 200;
> + reset_timeout_ms = 700;
> }
>
> test(i915, cfg, engine);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] gem_ctx_persistence: adjust reset timeout
2022-09-23 16:01 [Intel-gfx] [PATCH i-g-t] gem_ctx_persistence: adjust reset timeout Andrzej Hajda
2022-09-26 8:57 ` [Intel-gfx] [igt-dev] " Das, Nirmoy
@ 2022-10-04 10:57 ` Kamil Konieczny
1 sibling, 0 replies; 3+ messages in thread
From: Kamil Konieczny @ 2022-10-04 10:57 UTC (permalink / raw)
To: intel-gfx, igt-dev; +Cc: Andrzej Hajda
On 2022-09-23 at 18:01:37 +0200, Andrzej Hajda wrote:
> Tests on DG2 show that context cancel can take even 350ms,
> due to error state capturing in guc_handle_context_reset.
> Since it happens only in debug mode and tests runs in debug mode
> it should be fine to adjust the timeout.
> Let's double this value, to be on safe side.
> It should fix multiple test timeout failures.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1551
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5891
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3952
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> tests/i915/gem_ctx_persistence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c
> index 50196edb19f..a844439de19 100644
> --- a/tests/i915/gem_ctx_persistence.c
> +++ b/tests/i915/gem_ctx_persistence.c
> @@ -1214,7 +1214,7 @@ static void do_test(void (*test)(int i915, const intel_ctx_cfg_t *cfg,
> if (timeout != -1) {
> igt_require(gem_engine_property_printf(i915, name,
> ATTR, "%d", 50) > 0);
> - reset_timeout_ms = 200;
> + reset_timeout_ms = 700;
> }
>
> test(i915, cfg, engine);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-04 10:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-23 16:01 [Intel-gfx] [PATCH i-g-t] gem_ctx_persistence: adjust reset timeout Andrzej Hajda
2022-09-26 8:57 ` [Intel-gfx] [igt-dev] " Das, Nirmoy
2022-10-04 10:57 ` [Intel-gfx] " Kamil Konieczny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox