Re: [PATCH 0/6] drm/i915: expose RCS topology to userspace

[Lionel Landwerlin <lionel.g.landwerlin@intel.com>]

Hey Tvrtko,

I've had only one comment from Chris on this series (addressed locally).
Since atm you might be the only other person in need of this API, do you 
have any feedback on it?

Thanks,

-
Lionel

On 18/12/17 15:35, Lionel Landwerlin wrote:
> Hi all,
>
> This series a respin of a few attempts ([1], [2], [3]) to expose RCS
> topology to userspace.
>
> The motivation for this is to be able to monitor part of the GPU using
> i915 perf and have detailled knowledge about what execution units are
> fused off. Let's say you monitor slice 1, knowing how many EUs are
> actually usuable on that slice is critical to provide normalized
> numbers (like average busyness of the EUs on slice1) on that
> particular part of the GPU. Currently numbers returned like
> I915_PARAM_EU_TOTAL don't give us that information.
>
> This series introduces a new uAPI to query information from i915. It's
> partially inspired by the amdgpu_cs_ioctl, although we don't allow
> setting values onto the device, only queries. There is a good chance
> this new uAPI will be reused for exposing available engines (Tvrtko
> was looking into this).
>
> Thanks,
>
> [1]: https://patchwork.freedesktop.org/patch/185959/
> [2]: https://patchwork.freedesktop.org/series/33436/
> [3]: https://patchwork.freedesktop.org/series/33950/
>
> Lionel Landwerlin (6):
>    drm/i915: store all subslice masks
>    drm/i915/debugfs: reuse max slice/subslices already stored in sseu
>    drm/i915/debugfs: add rcs topology entry
>    drm/i915: add rcs topology to error state
>    drm/i915: add query uAPI
>    drm/i915: expose rcs topology through query uAPI
>
>   drivers/gpu/drm/i915/Makefile            |   1 +
>   drivers/gpu/drm/i915/i915_debugfs.c      |  87 ++++++++++-----
>   drivers/gpu/drm/i915/i915_drv.c          |   3 +-
>   drivers/gpu/drm/i915/i915_drv.h          |  26 ++++-
>   drivers/gpu/drm/i915/i915_gpu_error.c    |  35 ++++++
>   drivers/gpu/drm/i915/i915_query.c        | 186 +++++++++++++++++++++++++++++++
>   drivers/gpu/drm/i915/intel_device_info.c | 169 ++++++++++++++++++++--------
>   drivers/gpu/drm/i915/intel_lrc.c         |   2 +-
>   drivers/gpu/drm/i915/intel_query_info.c  |  88 +++++++++++++++
>   drivers/gpu/drm/i915/intel_ringbuffer.h  |   2 +-
>   include/uapi/drm/i915_drm.h              |  76 +++++++++++++
>   11 files changed, 598 insertions(+), 77 deletions(-)
>   create mode 100644 drivers/gpu/drm/i915/i915_query.c
>   create mode 100644 drivers/gpu/drm/i915/intel_query_info.c
>
> --
> 2.15.1
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx