Re: [PATCH v6 6/7] drm/i915: Expose RPCS (SSEU) configuration to userspace

[Lionel Landwerlin <lionel.g.landwerlin@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 993 bytes --]

On 24/05/18 11:43, Tvrtko Ursulin wrote:
>
>>
>>>
>>>> +
>>>> +    /*
>>>> +     * Mask of slices to enable for the context. Valid values are 
>>>> a subset
>>>> +     * of the bitmask value returned for I915_PARAM_SLICE_MASK.
>>>> +     */
>>>> +    __u8 slice_mask;
>>>> +
>>>> +    /*
>>>> +     * Mask of subslices to enable for the context. Valid values 
>>>> are a
>>>> +     * subset of the bitmask value return by 
>>>> I915_PARAM_SUBSLICE_MASK.
>>>> +     */
>>>> +    __u8 subslice_mask;
>>>
>>> Is this future proof enough, say for Gen11?
>>
>> As far as I can see, this fits.
>> No objection to bump it to 16/32bits if you'd like.
>
> Feel like I've asked you this before, sorry - nothing in the future 
> will need per slice subslice mask?

As far as I can see this remains the same uniform subslice per slice 
programming style.
We could play it safe and put all the masks in 64bits in the uAPI.

What do you think?

>
> Regards,
>
> Tvrtko



[-- Attachment #1.2: Type: text/html, Size: 2227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx