Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v6 7/7] drm/i915: add a sysfs entry to let users set sseu configs
Date: Wed, 23 May 2018 18:37:35 +0100	[thread overview]
Message-ID: <9f9be814-d3ac-e0d7-c806-bb69fdbe2f04@intel.com> (raw)
In-Reply-To: <4abc7173-35df-5bd7-5da8-13bec29c5d90@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 404 bytes --]

On 23/05/18 16:30, Tvrtko Ursulin wrote:
>>
>> +{
>> +    struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev);
>> +    int ret = i915_gem_contexts_get_allow_sseu(dev_priv);
>> +
>> +    return snprintf(buf, PAGE_SIZE, "%d\n", ret);
>
> Propagate ENODEV all the way by making 
> i915_gem_contexts_get_allow_sseu return an int? 

Actually should a cat on a sysfs entry fail with ENODEV?


[-- Attachment #1.2: Type: text/html, Size: 940 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-05-23 17:37 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 17:59 [PATCH v6 0/7] drm/i915: per context slice/subslice powergating Lionel Landwerlin
2018-05-22 17:59 ` [PATCH v6 1/7] drm/i915: Program RPCS for Broadwell Lionel Landwerlin
2018-05-22 17:59 ` [PATCH v6 2/7] drm/i915: Record the sseu configuration per-context & engine Lionel Landwerlin
2018-05-23 14:54   ` Tvrtko Ursulin
2018-05-23 14:58     ` Chris Wilson
2018-05-23 15:52     ` Lionel Landwerlin
2018-05-22 17:59 ` [PATCH v6 3/7] drm/i915/perf: simplify configure all context function Lionel Landwerlin
2018-05-23 14:54   ` Tvrtko Ursulin
2018-05-22 17:59 ` [PATCH v6 4/7] drm/i915/perf: reuse intel_lrc ctx regs macro Lionel Landwerlin
2018-05-23 14:57   ` Tvrtko Ursulin
2018-05-23 15:54     ` Lionel Landwerlin
2018-05-24 10:33       ` Tvrtko Ursulin
2018-05-22 18:00 ` [PATCH v6 5/7] drm/i915/perf: lock powergating configuration to default when active Lionel Landwerlin
2018-05-23 15:04   ` Tvrtko Ursulin
2018-05-22 18:00 ` [PATCH v6 6/7] drm/i915: Expose RPCS (SSEU) configuration to userspace Lionel Landwerlin
2018-05-23 15:13   ` Tvrtko Ursulin
2018-05-23 15:18     ` Chris Wilson
2018-05-23 17:12     ` Lionel Landwerlin
2018-05-24 10:43       ` Tvrtko Ursulin
2018-05-24 11:01         ` Lionel Landwerlin
2018-05-22 18:00 ` [PATCH v6 7/7] drm/i915: add a sysfs entry to let users set sseu configs Lionel Landwerlin
2018-05-23 15:30   ` Tvrtko Ursulin
2018-05-23 17:33     ` Lionel Landwerlin
2018-05-24 10:39       ` Tvrtko Ursulin
2018-05-24 10:45         ` Lionel Landwerlin
2018-05-25 15:42         ` Lionel Landwerlin
2018-05-23 17:37     ` Lionel Landwerlin [this message]
2018-05-22 18:55 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: per context slice/subslice powergating (rev5) Patchwork
2018-05-22 18:58 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-05-22 19:16 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-23  0:10 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f9be814-d3ac-e0d7-c806-bb69fdbe2f04@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox