Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Souza, Jose" <jose.souza@intel.com>
To: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Ghuge, Sagar" <sagar.ghuge@intel.com>,
	"Chery, Nanley G" <nanley.g.chery@intel.com>,
	"xry111@xry111.site" <xry111@xry111.site>
Subject: Re: [PATCH 0/4] drm/i915/fb: Deal with Mesa clear color alignment regression
Date: Tue, 7 Jan 2025 19:44:19 +0000	[thread overview]
Message-ID: <e1628f8af7d264fe090ff8dcb2b18260de262097.camel@intel.com> (raw)
In-Reply-To: <20241129065014.8363-1-ville.syrjala@linux.intel.com>

On Fri, 2024-11-29 at 08:50 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Mesa changed its clear color alignment without informing the kernel,
> and now the kernel expects 4k alignment whereas Mesa only guaratees
> 64 bytes. Reduce the kernel alignment requirement to the same 64 bytes
> since there's no real reason for the current 4k limit. And while at it
> add some missing checks and debugs to the clear color hadling.
> 
> Cc: Sagar Ghuge <sagar.ghuge@intel.com>
> Cc: Nanley Chery <nanley.g.chery@intel.com>
> Cc: Xi Ruoyao <xry111@xry111.site>

whole series lgtm

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> 
> Ville Syrjälä (4):
>   drm/i915/fb: Relax clear color alignment to 64 bytes
>   drm/i915/fb: Add debug spew for misaligned CC plane
>   drm/i915/fb: Check that the clear color fits within the BO
>   drm/uapi/fourcc: Document the Intel clear color alignment better
> 
>  drivers/gpu/drm/i915/display/intel_fb.c | 20 +++++++++++++++---
>  include/uapi/drm/drm_fourcc.h           | 27 +++++++++++++------------
>  2 files changed, 31 insertions(+), 16 deletions(-)
> 


      parent reply	other threads:[~2025-01-07 19:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-29  6:50 [PATCH 0/4] drm/i915/fb: Deal with Mesa clear color alignment regression Ville Syrjala
2024-11-29  6:50 ` [PATCH 1/4] drm/i915/fb: Relax clear color alignment to 64 bytes Ville Syrjala
2024-11-29 13:45   ` Xi Ruoyao
2024-11-29  6:50 ` [PATCH 2/4] drm/i915/fb: Add debug spew for misaligned CC plane Ville Syrjala
2024-11-29  6:50 ` [PATCH 3/4] drm/i915/fb: Check that the clear color fits within the BO Ville Syrjala
2024-11-29  6:50 ` [PATCH 4/4] drm/uapi/fourcc: Document the Intel clear color alignment better Ville Syrjala
2025-01-10 15:43   ` Chery, Nanley G
2025-01-13 16:38     ` Ville Syrjälä
2024-11-29  7:11 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/fb: Deal with Mesa clear color alignment regression Patchwork
2024-11-29  7:11 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-11-29  7:27 ` ✗ i915.CI.BAT: failure " Patchwork
2024-11-29  8:45 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/fb: Deal with Mesa clear color alignment regression (rev2) Patchwork
2024-11-29  8:45 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-11-29  8:57 ` ✓ i915.CI.BAT: success " Patchwork
2024-11-29 11:17 ` ✗ i915.CI.Full: failure " Patchwork
2025-01-07 19:44 ` Souza, Jose [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1628f8af7d264fe090ff8dcb2b18260de262097.camel@intel.com \
    --to=jose.souza@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=nanley.g.chery@intel.com \
    --cc=sagar.ghuge@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox