* Re: [Intel-gfx] [PATCH] drm/i915: Do not share hwsp across contexts any more, v5.1
[not found] ` <160329148583.24927.9148362733542956189@build.alporthouse.com>
@ 2020-10-22 8:16 ` Maarten Lankhorst
0 siblings, 0 replies; only message in thread
From: Maarten Lankhorst @ 2020-10-22 8:16 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Op 21-10-2020 om 16:44 schreef Chris Wilson:
> Quoting Maarten Lankhorst (2020-10-21 15:39:48)
>> Instead of sharing pages with breadcrumbs, give each timeline a
>> single page. This allows unrelated timelines not to share locks
>> any more during command submission.
> This is designed to fail. No. The hwsp is observed externally with a
> lifetime outside of the local timeline's control.
> -Chris
Hey,
Thank you for looking at the patch. It seems you're worried about
lifetime issues. When the timeline is pinned, i915_active takes a
reference on the vma pin and timeline.
intel_timeline_read_hwsp() uses the existing i915_active trick to keep
the timeline alive, so this will stay working correctly as intended. :)
Can I add your reviewed-by for the patch when I submit it to the ml
again?
Cheers,
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-22 8:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201021143948.2558154-1-maarten.lankhorst@linux.intel.com>
[not found] ` <160329148583.24927.9148362733542956189@build.alporthouse.com>
2020-10-22 8:16 ` [Intel-gfx] [PATCH] drm/i915: Do not share hwsp across contexts any more, v5.1 Maarten Lankhorst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox