From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 3/3] drm/i915: Force sync command ordering
Date: Tue, 11 Oct 2011 20:16:55 +0100 [thread overview]
Message-ID: <e39f63$29fugg@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1318357916-12661-4-git-send-email-ben@bwidawsk.net>
On Tue, 11 Oct 2011 11:31:56 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> This will strongly order synchronization commands with respect to 3d
> state and 3d primitive commands. AFAIK, this shouldn't impact anything
> as these sync commands are all for privileged (or ppgtt) batches only,
> so user space should not be relying on this, and the kernel wouldn't be
> relying on 3d state or primitive commands.
>
> This will help when we enable PPGTT, and perhaps this synchronization is
> currently useful and I just don't realize it.
>
> This was found through doc inspection by Ken and applies to Gen6+;
>
> Reported-by: Kenneth Graunke <kenneth@whitecape.org>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Ok, that bit does look quite important..., and the code also looks
correct!
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-10-11 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 18:31 [PATCH 0/3] execbuf cleanups Ben Widawsky
2011-10-11 18:31 ` [PATCH 1/3] drm/i915: extract constant offset setting Ben Widawsky
2011-10-11 19:09 ` Chris Wilson
2011-10-11 18:31 ` [PATCH 2/3] drm/i915: make eb structure do more Ben Widawsky
2011-10-11 19:11 ` Chris Wilson
2011-10-11 18:31 ` [PATCH 3/3] drm/i915: Force sync command ordering Ben Widawsky
2011-10-11 18:44 ` Ben Widawsky
2011-10-11 19:16 ` Chris Wilson [this message]
2011-10-11 19:18 ` Kenneth Graunke
2011-10-11 19:30 ` Ben Widawsky
2011-10-11 19:33 ` Ben Widawsky
2011-10-11 19:42 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e39f63$29fugg@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox