From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Force sync command ordering
Date: Tue, 11 Oct 2011 20:42:44 +0100 [thread overview]
Message-ID: <c55c5d$o4r6r@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <20111011123305.2eb736da@bwidawsk.net>
On Tue, 11 Oct 2011 12:33:05 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Tue, 11 Oct 2011 12:30:36 -0700
> Ben Widawsky <ben@bwidawsk.net> wrote:
>
> > On Tue, 11 Oct 2011 12:18:15 -0700
> > Kenneth Graunke <kenneth@whitecape.org> wrote:
> > >
> > > I might only enable this on Gen7 for now, unless it actually fixes
> > > something on Sandybridge. It's not listed as required for Gen6.
> >
> > I would prefer to keep for gen6 for two reasons:
> > 1 - paranoia
> > 2 - user space is going to be toggling a bit which it doesn't mean to
> > toggle and that has a who knows what impact on gen6.
> >
> > Ben
>
> I'm an idiot. Disregard this comment. Was thinking of the other hunk.
> Just 1 reason then, paranoia? Any takers?
Does PIPE_CONTROL qualify as a 3D state packet? If so without that bit
set, there is no barrier between writing to a register and attempting to
make use of it within the batch.
Sounds like justifiable paranoia to me.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2011-10-11 19:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 18:31 [PATCH 0/3] execbuf cleanups Ben Widawsky
2011-10-11 18:31 ` [PATCH 1/3] drm/i915: extract constant offset setting Ben Widawsky
2011-10-11 19:09 ` Chris Wilson
2011-10-11 18:31 ` [PATCH 2/3] drm/i915: make eb structure do more Ben Widawsky
2011-10-11 19:11 ` Chris Wilson
2011-10-11 18:31 ` [PATCH 3/3] drm/i915: Force sync command ordering Ben Widawsky
2011-10-11 18:44 ` Ben Widawsky
2011-10-11 19:16 ` Chris Wilson
2011-10-11 19:18 ` Kenneth Graunke
2011-10-11 19:30 ` Ben Widawsky
2011-10-11 19:33 ` Ben Widawsky
2011-10-11 19:42 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='c55c5d$o4r6r@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox