From: Chris Wilson <chris@chris-wilson.co.uk>
To: Kenneth Graunke <kenneth@whitecape.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] intel: Remove Ironlake from IS_GEN4 macro.
Date: Tue, 21 Feb 2012 21:08:38 +0000 [thread overview]
Message-ID: <e39f63$3pub8q@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1329857978-30626-2-git-send-email-kenneth@whitecape.org>
On Tue, 21 Feb 2012 12:59:38 -0800, Kenneth Graunke <kenneth@whitecape.org> wrote:
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
A task for a rainy afternoon would be to rigorously use the verbose
PCI_ID_* names rather than the raw values.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> intel/intel_chipset.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h
> index e3a30fc..1b6e357 100644
> --- a/intel/intel_chipset.h
> +++ b/intel/intel_chipset.h
> @@ -96,8 +96,6 @@
> dev == 0x2E22 || \
> dev == 0x2E32 || \
> dev == 0x2E42 || \
Note that these 5 IDs are part of IS_G4X, can you kill them as well (in
another patch).
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-21 21:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 20:59 [PATCH 1/2] intel: Add support for overriding the PCI ID via an environment variable Kenneth Graunke
2012-02-21 20:59 ` [PATCH 2/2] intel: Remove Ironlake from IS_GEN4 macro Kenneth Graunke
2012-02-21 21:08 ` Chris Wilson [this message]
2012-02-21 22:24 ` Kenneth Graunke
2012-02-21 21:11 ` [PATCH 1/2] intel: Add support for overriding the PCI ID via an environment variable Chris Wilson
2012-02-21 22:42 ` Kenneth Graunke
2012-02-22 8:05 ` Daniel Vetter
2012-02-21 22:43 ` Ben Widawsky
2012-03-03 15:22 ` Julien Cristau
2012-03-05 23:18 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e39f63$3pub8q@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox