Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Kenneth Graunke <kenneth@whitecape.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] intel: Add support for overriding the PCI ID via an environment variable
Date: Tue, 21 Feb 2012 21:11:07 +0000	[thread overview]
Message-ID: <e39f63$3pubsr@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1329857978-30626-1-git-send-email-kenneth@whitecape.org>

On Tue, 21 Feb 2012 12:59:37 -0800, Kenneth Graunke <kenneth@whitecape.org> wrote:
> @@ -1828,6 +1829,9 @@ drm_intel_gem_bo_mrb_exec2(drm_intel_bo *bo, int used,
>  	execbuf.rsvd1 = 0;
>  	execbuf.rsvd2 = 0;
>  
> +	if (getenv("INTEL_DEVID_OVERRIDE"))
> +		goto skip_execution;

I'm not thrilled about calling getenv() for every execbuffer. And what
about the original execbuffer path?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  parent reply	other threads:[~2012-02-21 21:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-21 20:59 [PATCH 1/2] intel: Add support for overriding the PCI ID via an environment variable Kenneth Graunke
2012-02-21 20:59 ` [PATCH 2/2] intel: Remove Ironlake from IS_GEN4 macro Kenneth Graunke
2012-02-21 21:08   ` Chris Wilson
2012-02-21 22:24     ` Kenneth Graunke
2012-02-21 21:11 ` Chris Wilson [this message]
2012-02-21 22:42   ` [PATCH 1/2] intel: Add support for overriding the PCI ID via an environment variable Kenneth Graunke
2012-02-22  8:05     ` Daniel Vetter
2012-02-21 22:43   ` Ben Widawsky
2012-03-03 15:22   ` Julien Cristau
2012-03-05 23:18     ` Eric Anholt
  -- strict thread matches above, loose matches on Subject: below --
2012-03-07 19:21 Eric Anholt
2012-03-08  2:35 ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='e39f63$3pubsr@fmsmga002.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kenneth@whitecape.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox