[PATCH i-g-t] i915/gem_ctx_engines: Skip trying to read a non-existent TIMESTAMP

[PATCH i-g-t] i915/gem_ctx_engines: Skip trying to read a non-existent TIMESTAMP

[Chris Wilson]

The per-engine TIMESTAMP (at least at the offset I know about) only came
into being with gen6. So skip the test on older gen as the results are
garbage.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110874
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_ctx_engines.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/i915/gem_ctx_engines.c b/tests/i915/gem_ctx_engines.c
index 38ea34d21..3ecade417 100644
--- a/tests/i915/gem_ctx_engines.c
+++ b/tests/i915/gem_ctx_engines.c
@@ -419,6 +419,8 @@ static void independent(int i915)
 	int timeline = sw_sync_timeline_create();
 	uint32_t last, *map;
 
+	igt_require(gen >= 6); /* No per-engine TIMESTAMP on older gen */
+
 	{
 		struct drm_i915_gem_execbuffer2 execbuf = {
 			.buffers_ptr = to_user_pointer(&results),
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] i915/gem_ctx_engines: Skip trying to read a non-existent TIMESTAMP

[Tvrtko Ursulin]

On 10/06/2019 11:46, Chris Wilson wrote:
> The per-engine TIMESTAMP (at least at the offset I know about) only came
> into being with gen6. So skip the test on older gen as the results are
> garbage.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110874
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/i915/gem_ctx_engines.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/i915/gem_ctx_engines.c b/tests/i915/gem_ctx_engines.c
> index 38ea34d21..3ecade417 100644
> --- a/tests/i915/gem_ctx_engines.c
> +++ b/tests/i915/gem_ctx_engines.c
> @@ -419,6 +419,8 @@ static void independent(int i915)
>   	int timeline = sw_sync_timeline_create();
>   	uint32_t last, *map;
>   
> +	igt_require(gen >= 6); /* No per-engine TIMESTAMP on older gen */
> +
>   	{
>   		struct drm_i915_gem_execbuffer2 execbuf = {
>   			.buffers_ptr = to_user_pointer(&results),
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx