* [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state
@ 2022-02-08 2:07 John.C.Harrison
2022-02-08 2:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: John.C.Harrison @ 2022-02-08 2:07 UTC (permalink / raw)
To: Intel-GFX; +Cc: DRI-Devel
From: John Harrison <John.C.Harrison@Intel.com>
A flag query helper was actually writing to the flags word rather than
just reading. Fix that. Also update the function's comment as it was
out of date.
Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simplify locking")
Signed-off-by: John Harrison <john.c.harrison@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index b3a429a92c0d..d9f4218f5ef4 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -174,11 +174,8 @@ static inline void init_sched_state(struct intel_context *ce)
__maybe_unused
static bool sched_state_is_init(struct intel_context *ce)
{
- /*
- * XXX: Kernel contexts can have SCHED_STATE_NO_LOCK_REGISTERED after
- * suspend.
- */
- return !(ce->guc_state.sched_state &=
+ /* Kernel contexts can have SCHED_STATE_REGISTERED after suspend. */
+ return !(ce->guc_state.sched_state &
~(SCHED_STATE_BLOCKED_MASK | SCHED_STATE_REGISTERED));
}
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Fix flag query to not modify state 2022-02-08 2:07 [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state John.C.Harrison @ 2022-02-08 2:19 ` Patchwork 2022-02-08 2:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2022-02-08 2:19 UTC (permalink / raw) To: john.c.harrison; +Cc: intel-gfx == Series Details == Series: drm/i915/guc: Fix flag query to not modify state URL : https://patchwork.freedesktop.org/series/99803/ State : warning == Summary == $ dim checkpatch origin/drm-tip 98f0397a8054 drm/i915/guc: Fix flag query to not modify state -:30: CHECK:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email comments mismatch: 'From: John Harrison <John.C.Harrison@Intel.com>' != 'Signed-off-by: John Harrison <john.c.harrison@intel.com>' total: 0 errors, 0 warnings, 1 checks, 13 lines checked ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Fix flag query to not modify state 2022-02-08 2:07 [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state John.C.Harrison 2022-02-08 2:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork @ 2022-02-08 2:51 ` Patchwork 2022-02-08 6:18 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2022-02-08 9:39 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 3 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2022-02-08 2:51 UTC (permalink / raw) To: john.c.harrison; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 7285 bytes --] == Series Details == Series: drm/i915/guc: Fix flag query to not modify state URL : https://patchwork.freedesktop.org/series/99803/ State : success == Summary == CI Bug Log - changes from CI_DRM_11199 -> Patchwork_22195 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/index.html Participating hosts (46 -> 44) ------------------------------ Additional (1): fi-pnv-d510 Missing (3): fi-bsw-cyan fi-icl-u2 shard-tglu Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_22195: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@gem_exec_suspend@basic-s3@smem: - {fi-rkl-11600}: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html Known issues ------------ Here are the changes found in Patchwork_22195 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_huc_copy@huc-copy: - fi-skl-6600u: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-skl-6600u/igt@gem_huc_copy@huc-copy.html - fi-pnv-d510: NOTRUN -> [SKIP][4] ([fdo#109271]) +57 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-pnv-d510/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@verify-random: - fi-skl-6600u: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-skl-6600u/igt@gem_lmem_swapping@verify-random.html * igt@i915_selftest@live@gt_heartbeat: - fi-skl-6700k2: [PASS][6] -> [DMESG-FAIL][7] ([i915#2291] / [i915#541]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/fi-skl-6700k2/igt@i915_selftest@live@gt_heartbeat.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-skl-6700k2/igt@i915_selftest@live@gt_heartbeat.html * igt@kms_chamelium@vga-edid-read: - fi-skl-6600u: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-skl-6600u/igt@kms_chamelium@vga-edid-read.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy: - fi-skl-6600u: NOTRUN -> [SKIP][9] ([fdo#109271]) +21 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-skl-6600u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html * igt@kms_frontbuffer_tracking@basic: - fi-cfl-8109u: [PASS][10] -> [DMESG-FAIL][11] ([i915#295]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - fi-skl-6600u: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#533]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-skl-6600u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@read-crc-pipe-b: - fi-cfl-8109u: [PASS][13] -> [DMESG-WARN][14] ([i915#295]) +10 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/fi-cfl-8109u/igt@kms_pipe_crc_basic@read-crc-pipe-b.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-cfl-8109u/igt@kms_pipe_crc_basic@read-crc-pipe-b.html * igt@runner@aborted: - fi-bdw-5557u: NOTRUN -> [FAIL][15] ([i915#2426] / [i915#4312]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-bdw-5557u/igt@runner@aborted.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3@smem: - fi-bdw-5557u: [INCOMPLETE][16] ([i915#146]) -> [PASS][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html * igt@i915_module_load@reload: - fi-kbl-soraka: [DMESG-WARN][18] ([i915#1982]) -> [PASS][19] [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/fi-kbl-soraka/igt@i915_module_load@reload.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-kbl-soraka/igt@i915_module_load@reload.html * igt@kms_frontbuffer_tracking@basic: - fi-cml-u2: [DMESG-WARN][20] ([i915#4269]) -> [PASS][21] [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html #### Warnings #### * igt@i915_selftest@live@hangcheck: - bat-dg1-6: [DMESG-FAIL][22] ([i915#4494] / [i915#4957]) -> [DMESG-FAIL][23] ([i915#4957]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/bat-dg1-6/igt@i915_selftest@live@hangcheck.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/bat-dg1-6/igt@i915_selftest@live@hangcheck.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295 [i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541 Build changes ------------- * Linux: CI_DRM_11199 -> Patchwork_22195 CI-20190529: 20190529 CI_DRM_11199: e74a41add451a1ff1e15abe5985a1324e4c328d9 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6341: a96674e747ea2f2431bbf8813156adc44ec3162a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_22195: 98f0397a805467b84d37effdcfb7c3725e90c706 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 98f0397a8054 drm/i915/guc: Fix flag query to not modify state == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/index.html [-- Attachment #2: Type: text/html, Size: 8721 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Fix flag query to not modify state 2022-02-08 2:07 [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state John.C.Harrison 2022-02-08 2:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2022-02-08 2:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2022-02-08 6:18 ` Patchwork 2022-02-08 9:39 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 3 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2022-02-08 6:18 UTC (permalink / raw) To: john.c.harrison; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 30271 bytes --] == Series Details == Series: drm/i915/guc: Fix flag query to not modify state URL : https://patchwork.freedesktop.org/series/99803/ State : success == Summary == CI Bug Log - changes from CI_DRM_11199_full -> Patchwork_22195_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (13 -> 13) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in Patchwork_22195_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_eio@in-flight-contexts-1us: - shard-tglb: [PASS][1] -> [TIMEOUT][2] ([i915#3063]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-tglb2/igt@gem_eio@in-flight-contexts-1us.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb6/igt@gem_eio@in-flight-contexts-1us.html * igt@gem_exec_balancer@parallel-contexts: - shard-iclb: [PASS][3] -> [SKIP][4] ([i915#4525]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-iclb1/igt@gem_exec_balancer@parallel-contexts.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb3/igt@gem_exec_balancer@parallel-contexts.html * igt@gem_exec_capture@pi@bcs0: - shard-skl: NOTRUN -> [INCOMPLETE][5] ([i915#4547]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl10/igt@gem_exec_capture@pi@bcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-tglb: NOTRUN -> [FAIL][6] ([i915#2842]) +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html - shard-glk: [PASS][9] -> [FAIL][10] ([i915#2842]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_params@secure-non-master: - shard-tglb: NOTRUN -> [SKIP][11] ([fdo#112283]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@gem_exec_params@secure-non-master.html * igt@gem_lmem_swapping@heavy-multi: - shard-kbl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-kbl6/igt@gem_lmem_swapping@heavy-multi.html * igt@gem_lmem_swapping@parallel-random: - shard-skl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4613]) +2 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl4/igt@gem_lmem_swapping@parallel-random.html * igt@gem_lmem_swapping@random-engines: - shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl4/igt@gem_lmem_swapping@random-engines.html * igt@gem_pwrite@basic-exhaustion: - shard-apl: NOTRUN -> [WARN][15] ([i915#2658]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl4/igt@gem_pwrite@basic-exhaustion.html - shard-tglb: NOTRUN -> [WARN][16] ([i915#2658]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@gem_pwrite@basic-exhaustion.html * igt@gem_pxp@reject-modify-context-protection-on: - shard-iclb: NOTRUN -> [SKIP][17] ([i915#4270]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@gem_pxp@reject-modify-context-protection-on.html * igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs: - shard-iclb: NOTRUN -> [SKIP][18] ([i915#768]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs.html * igt@gem_spin_batch@legacy@vebox: - shard-apl: [PASS][19] -> [FAIL][20] ([i915#2898]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-apl7/igt@gem_spin_batch@legacy@vebox.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl8/igt@gem_spin_batch@legacy@vebox.html * igt@gem_userptr_blits@input-checking: - shard-skl: NOTRUN -> [DMESG-WARN][21] ([i915#4990]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl6/igt@gem_userptr_blits@input-checking.html * igt@gen9_exec_parse@bb-oversize: - shard-iclb: NOTRUN -> [SKIP][22] ([i915#2856]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@gen9_exec_parse@bb-oversize.html * igt@i915_module_load@reload-with-fault-injection: - shard-skl: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-skl6/igt@i915_module_load@reload-with-fault-injection.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl10/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pm_dc@dc6-dpms: - shard-tglb: NOTRUN -> [FAIL][25] ([i915#454]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait: - shard-tglb: NOTRUN -> [SKIP][26] ([fdo#111644] / [i915#1397] / [i915#2411]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html * igt@i915_selftest@live@hangcheck: - shard-snb: [PASS][27] -> [INCOMPLETE][28] ([i915#3921]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-snb2/igt@i915_selftest@live@hangcheck.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-snb6/igt@i915_selftest@live@hangcheck.html * igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip: - shard-skl: NOTRUN -> [FAIL][29] ([i915#3743]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html * igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip: - shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#3777]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl7/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html * igt@kms_big_fb@y-tiled-64bpp-rotate-90: - shard-iclb: NOTRUN -> [SKIP][31] ([fdo#110725] / [fdo#111614]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@kms_big_fb@y-tiled-64bpp-rotate-90.html * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip: - shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3777]) +1 similar issue [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip: - shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3777]) +1 similar issue [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-kbl6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip: - shard-tglb: NOTRUN -> [SKIP][34] ([fdo#111615]) +1 similar issue [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip.html * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][35] ([i915#3689]) +3 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_ccs.html * igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs: - shard-kbl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3886]) +3 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-kbl7/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc: - shard-skl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#3886]) +11 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl6/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc: - shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109278] / [i915#3886]) +1 similar issue [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3886]) +5 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl4/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-d-crc-sprite-planes-basic-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][40] ([fdo#111615] / [i915#3689]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-yf_tiled_ccs.html * igt@kms_chamelium@dp-hpd-for-each-pipe: - shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +4 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-kbl6/igt@kms_chamelium@dp-hpd-for-each-pipe.html * igt@kms_chamelium@dp-hpd-storm: - shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109284] / [fdo#111827]) +1 similar issue [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@kms_chamelium@dp-hpd-storm.html * igt@kms_color@pipe-d-ctm-green-to-red: - shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109278] / [i915#1149]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@kms_color@pipe-d-ctm-green-to-red.html * igt@kms_color_chamelium@pipe-b-ctm-max: - shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +17 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl6/igt@kms_color_chamelium@pipe-b-ctm-max.html * igt@kms_color_chamelium@pipe-c-ctm-0-25: - shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +7 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl4/igt@kms_color_chamelium@pipe-c-ctm-0-25.html - shard-tglb: NOTRUN -> [SKIP][46] ([fdo#109284] / [fdo#111827]) +3 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@kms_color_chamelium@pipe-c-ctm-0-25.html * igt@kms_content_protection@dp-mst-type-1: - shard-iclb: NOTRUN -> [SKIP][47] ([i915#3116]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@kms_content_protection@dp-mst-type-1.html - shard-tglb: NOTRUN -> [SKIP][48] ([i915#3116] / [i915#3299]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb3/igt@kms_content_protection@dp-mst-type-1.html * igt@kms_cursor_crc@pipe-a-cursor-512x512-random: - shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109278] / [fdo#109279]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@kms_cursor_crc@pipe-a-cursor-512x512-random.html * igt@kms_cursor_crc@pipe-a-cursor-max-size-offscreen: - shard-tglb: NOTRUN -> [SKIP][50] ([i915#3359]) +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@kms_cursor_crc@pipe-a-cursor-max-size-offscreen.html * igt@kms_cursor_crc@pipe-b-cursor-32x32-sliding: - shard-tglb: NOTRUN -> [SKIP][51] ([i915#3319]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@kms_cursor_crc@pipe-b-cursor-32x32-sliding.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-kbl: [PASS][52] -> [DMESG-WARN][53] ([i915#180]) +3 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_crc@pipe-d-cursor-256x85-random: - shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109278]) +7 similar issues [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@kms_cursor_crc@pipe-d-cursor-256x85-random.html * igt@kms_cursor_crc@pipe-d-cursor-suspend: - shard-tglb: [PASS][55] -> [DMESG-WARN][56] ([i915#2411] / [i915#2867]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-tglb3/igt@kms_cursor_crc@pipe-d-cursor-suspend.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb3/igt@kms_cursor_crc@pipe-d-cursor-suspend.html * igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic: - shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109274] / [fdo#109278]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: - shard-tglb: NOTRUN -> [SKIP][58] ([fdo#109274] / [fdo#111825]) +2 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-skl: NOTRUN -> [FAIL][59] ([i915#2346] / [i915#533]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: [PASS][60] -> [INCOMPLETE][61] ([i915#180]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl3/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-flip-vs-wf_vblank-interruptible: - shard-iclb: NOTRUN -> [SKIP][62] ([fdo#109274]) +1 similar issue [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1: - shard-apl: [PASS][63] -> [FAIL][64] ([i915#79]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-apl: [PASS][65] -> [DMESG-WARN][66] ([i915#180]) +3 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1: - shard-skl: [PASS][67] -> [FAIL][68] ([i915#2122]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling: - shard-glk: [PASS][69] -> [FAIL][70] ([i915#4911]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-glk2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling: - shard-iclb: [PASS][71] -> [SKIP][72] ([i915#3701]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-iclb4/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.html * igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt: - shard-skl: NOTRUN -> [SKIP][73] ([fdo#109271]) +205 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl4/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt: - shard-kbl: NOTRUN -> [SKIP][74] ([fdo#109271]) +56 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-kbl6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt: - shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109280]) +3 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-move: - shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109280] / [fdo#111825]) +8 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-move.html * igt@kms_hdr@static-swap: - shard-tglb: NOTRUN -> [SKIP][77] ([i915#1187]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@kms_hdr@static-swap.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - shard-skl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#533]) +2 similar issues [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl4/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-d: - shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#533]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl4/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html * igt@kms_pipe_crc_basic@read-crc-pipe-d: - shard-kbl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#533]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-kbl7/igt@kms_pipe_crc_basic@read-crc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb: - shard-skl: NOTRUN -> [FAIL][81] ([fdo#108145] / [i915#265]) +1 similar issue [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-skl: NOTRUN -> [FAIL][82] ([i915#265]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max: - shard-kbl: NOTRUN -> [FAIL][83] ([fdo#108145] / [i915#265]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html * igt@kms_plane_cursor@pipe-d-viewport-size-128: - shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271]) +67 similar issues [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl4/igt@kms_plane_cursor@pipe-d-viewport-size-128.html * igt@kms_plane_lowres@pipe-b-tiling-y: - shard-tglb: NOTRUN -> [SKIP][85] ([i915#3536]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@kms_plane_lowres@pipe-b-tiling-y.html * igt@kms_psr2_sf@cursor-plane-update-sf: - shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#658]) +1 similar issue [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl7/igt@kms_psr2_sf@cursor-plane-update-sf.html * igt@kms_psr2_sf@overlay-plane-update-continuous-sf: - shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#658]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-kbl7/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area: - shard-skl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#658]) +3 similar issues [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html * igt@kms_psr2_su@frontbuffer-xrgb8888: - shard-tglb: NOTRUN -> [SKIP][89] ([i915#1911]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@kms_psr2_su@frontbuffer-xrgb8888.html - shard-iclb: [PASS][90] -> [SKIP][91] ([fdo#109642] / [fdo#111068] / [i915#658]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-iclb2/igt@kms_psr2_su@frontbuffer-xrgb8888.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb6/igt@kms_psr2_su@frontbuffer-xrgb8888.html * igt@kms_psr@psr2_basic: - shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109441]) [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@kms_psr@psr2_basic.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [PASS][93] -> [SKIP][94] ([fdo#109441]) +1 similar issue [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-iclb2/igt@kms_psr@psr2_no_drrs.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb8/igt@kms_psr@psr2_no_drrs.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-tglb: NOTRUN -> [FAIL][95] ([i915#132] / [i915#3467]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@kms_sysfs_edid_timing: - shard-skl: NOTRUN -> [FAIL][96] ([IGT#2]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl6/igt@kms_sysfs_edid_timing.html * igt@kms_writeback@writeback-pixel-formats: - shard-skl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2437]) [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl1/igt@kms_writeback@writeback-pixel-formats.html - shard-apl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2437]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl4/igt@kms_writeback@writeback-pixel-formats.html * igt@nouveau_crc@pipe-c-ctx-flip-detection: - shard-tglb: NOTRUN -> [SKIP][99] ([i915#2530]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@nouveau_crc@pipe-c-ctx-flip-detection.html * igt@perf@polling: - shard-skl: [PASS][100] -> [FAIL][101] ([i915#1542]) [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-skl4/igt@perf@polling.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl9/igt@perf@polling.html * igt@perf@polling-parameterized: - shard-skl: NOTRUN -> [FAIL][102] ([i915#1542]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl6/igt@perf@polling-parameterized.html * igt@perf_pmu@module-unload: - shard-tglb: [PASS][103] -> [DMESG-WARN][104] ([i915#262] / [i915#2867]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-tglb3/igt@perf_pmu@module-unload.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb3/igt@perf_pmu@module-unload.html * igt@prime_nv_test@nv_write_i915_gtt_mmap_read: - shard-tglb: NOTRUN -> [SKIP][105] ([fdo#109291]) +1 similar issue [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb1/igt@prime_nv_test@nv_write_i915_gtt_mmap_read.html * igt@sysfs_clients@busy: - shard-skl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#2994]) +1 similar issue [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl1/igt@sysfs_clients@busy.html #### Possible fixes #### * igt@drm_read@short-buffer-nonblock: - {shard-rkl}: [SKIP][107] ([i915#4098]) -> [PASS][108] [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-rkl-2/igt@drm_read@short-buffer-nonblock.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-rkl-6/igt@drm_read@short-buffer-nonblock.html * igt@fbdev@nullptr: - {shard-rkl}: [SKIP][109] ([i915#2582]) -> [PASS][110] [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-rkl-2/igt@fbdev@nullptr.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-rkl-6/igt@fbdev@nullptr.html * igt@gem_ctx_persistence@many-contexts: - shard-tglb: [FAIL][111] ([i915#2410]) -> [PASS][112] [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-tglb8/igt@gem_ctx_persistence@many-contexts.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb5/igt@gem_ctx_persistence@many-contexts.html * igt@gem_ctx_persistence@smoketest: - {shard-dg1}: [DMESG-WARN][113] ([i915#4892]) -> [PASS][114] [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-dg1-16/igt@gem_ctx_persistence@smoketest.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-dg1-15/igt@gem_ctx_persistence@smoketest.html * igt@gem_eio@in-flight-contexts-immediate: - shard-tglb: [TIMEOUT][115] ([i915#3063]) -> [PASS][116] [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-tglb2/igt@gem_eio@in-flight-contexts-immediate.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-tglb6/igt@gem_eio@in-flight-contexts-immediate.html * igt@gem_exec_balancer@parallel-out-fence: - shard-iclb: [SKIP][117] ([i915#4525]) -> [PASS][118] +1 similar issue [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-iclb5/igt@gem_exec_balancer@parallel-out-fence.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb4/igt@gem_exec_balancer@parallel-out-fence.html * igt@gem_exec_capture@pi@rcs0: - shard-skl: [INCOMPLETE][119] ([i915#4547]) -> [PASS][120] [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-skl6/igt@gem_exec_capture@pi@rcs0.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl10/igt@gem_exec_capture@pi@rcs0.html * igt@gem_exec_capture@pi@vecs0: - shard-iclb: [INCOMPLETE][121] ([i915#3371]) -> [PASS][122] [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-iclb4/igt@gem_exec_capture@pi@vecs0.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-iclb5/igt@gem_exec_capture@pi@vecs0.html * igt@gem_exec_fair@basic-none@vcs0: - shard-kbl: [FAIL][123] ([i915#2842]) -> [PASS][124] +4 similar issues [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-kbl4/igt@gem_exec_fair@basic-none@vcs0.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - {shard-rkl}: [FAIL][125] ([i915#2842]) -> ([PASS][126], [PASS][127]) [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-rkl-1/igt@gem_exec_fair@basic-pace-share@rcs0.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-rkl-4/igt@gem_exec_fair@basic-pace-share@rcs0.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-rkl-1/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_reloc@basic-scanout@vecs0: - {shard-rkl}: [SKIP][128] ([i915#3639]) -> [PASS][129] +3 similar issues [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-rkl-1/igt@gem_exec_reloc@basic-scanout@vecs0.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-rkl-6/igt@gem_exec_reloc@basic-scanout@vecs0.html * igt@gem_exec_schedule@u-fairslice-all: - shard-skl: [FAIL][130] -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-skl6/igt@gem_exec_schedule@u-fairslice-all.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl10/igt@gem_exec_schedule@u-fairslice-all.html * igt@gem_workarounds@suspend-resume-context: - shard-apl: [DMESG-WARN][132] ([i915#180]) -> [PASS][133] +2 similar issues [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-apl8/igt@gem_workarounds@suspend-resume-context.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-apl4/igt@gem_workarounds@suspend-resume-context.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [DMESG-WARN][134] ([i915#1436] / [i915#716]) -> [PASS][135] [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-skl4/igt@gen9_exec_parse@allowed-single.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-skl6/igt@gen9_exec_parse@allowed-single.html * igt@i915_pm_backlight@bad-brightness: - {shard-rkl}: [SKIP][136] ([i915#3012]) -> [PASS][137] +1 similar issue [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/shard-rkl-2/igt@i915_pm_backlight@bad-brightness.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/shard-rkl-6/igt@i915_pm_backlight@bad-brightness.html * ig == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22195/index.html [-- Attachment #2: Type: text/html, Size: 33644 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state 2022-02-08 2:07 [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state John.C.Harrison ` (2 preceding siblings ...) 2022-02-08 6:18 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2022-02-08 9:39 ` Tvrtko Ursulin 2022-02-08 18:53 ` John Harrison 3 siblings, 1 reply; 7+ messages in thread From: Tvrtko Ursulin @ 2022-02-08 9:39 UTC (permalink / raw) To: John.C.Harrison, Intel-GFX; +Cc: DRI-Devel On 08/02/2022 02:07, John.C.Harrison@Intel.com wrote: > From: John Harrison <John.C.Harrison@Intel.com> > > A flag query helper was actually writing to the flags word rather than > just reading. Fix that. Also update the function's comment as it was > out of date. > > Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simplify locking") > Signed-off-by: John Harrison <john.c.harrison@intel.com> > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > index b3a429a92c0d..d9f4218f5ef4 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > @@ -174,11 +174,8 @@ static inline void init_sched_state(struct intel_context *ce) > __maybe_unused > static bool sched_state_is_init(struct intel_context *ce) > { > - /* > - * XXX: Kernel contexts can have SCHED_STATE_NO_LOCK_REGISTERED after > - * suspend. > - */ > - return !(ce->guc_state.sched_state &= > + /* Kernel contexts can have SCHED_STATE_REGISTERED after suspend. */ > + return !(ce->guc_state.sched_state & > ~(SCHED_STATE_BLOCKED_MASK | SCHED_STATE_REGISTERED)); > } > Looks important - what are the consequences? Needs Cc: stable for 5.16? Regards, Tvrtko ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state 2022-02-08 9:39 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin @ 2022-02-08 18:53 ` John Harrison 2022-02-09 8:27 ` Tvrtko Ursulin 0 siblings, 1 reply; 7+ messages in thread From: John Harrison @ 2022-02-08 18:53 UTC (permalink / raw) To: Tvrtko Ursulin, Intel-GFX; +Cc: DRI-Devel On 2/8/2022 01:39, Tvrtko Ursulin wrote: > On 08/02/2022 02:07, John.C.Harrison@Intel.com wrote: >> From: John Harrison <John.C.Harrison@Intel.com> >> >> A flag query helper was actually writing to the flags word rather than >> just reading. Fix that. Also update the function's comment as it was >> out of date. >> >> Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simplify locking") >> Signed-off-by: John Harrison <john.c.harrison@intel.com> >> --- >> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> index b3a429a92c0d..d9f4218f5ef4 100644 >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> @@ -174,11 +174,8 @@ static inline void init_sched_state(struct >> intel_context *ce) >> __maybe_unused >> static bool sched_state_is_init(struct intel_context *ce) >> { >> - /* >> - * XXX: Kernel contexts can have SCHED_STATE_NO_LOCK_REGISTERED >> after >> - * suspend. >> - */ >> - return !(ce->guc_state.sched_state &= >> + /* Kernel contexts can have SCHED_STATE_REGISTERED after >> suspend. */ >> + return !(ce->guc_state.sched_state & >> ~(SCHED_STATE_BLOCKED_MASK | SCHED_STATE_REGISTERED)); >> } > > Looks important - what are the consequences? Supposedly nothing. The test was only ever used inside a BUG_ON during context registration. Rather than asserting that the condition was true, it was making the condition true. So, in theory, there was no consequence because we should never have hit a BUG_ON anyway. Which means the write should always have been a no-op. > > Needs Cc: stable for 5.16? Meaning "Cc: <stable@vger.kernel.org>"? Or is there anything required to specify 5.16? John. > > Regards, > > Tvrtko ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state 2022-02-08 18:53 ` John Harrison @ 2022-02-09 8:27 ` Tvrtko Ursulin 0 siblings, 0 replies; 7+ messages in thread From: Tvrtko Ursulin @ 2022-02-09 8:27 UTC (permalink / raw) To: John Harrison, Intel-GFX; +Cc: DRI-Devel On 08/02/2022 18:53, John Harrison wrote: > On 2/8/2022 01:39, Tvrtko Ursulin wrote: >> On 08/02/2022 02:07, John.C.Harrison@Intel.com wrote: >>> From: John Harrison <John.C.Harrison@Intel.com> >>> >>> A flag query helper was actually writing to the flags word rather than >>> just reading. Fix that. Also update the function's comment as it was >>> out of date. >>> >>> Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simplify locking") >>> Signed-off-by: John Harrison <john.c.harrison@intel.com> >>> --- >>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 ++----- >>> 1 file changed, 2 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> index b3a429a92c0d..d9f4218f5ef4 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> @@ -174,11 +174,8 @@ static inline void init_sched_state(struct >>> intel_context *ce) >>> __maybe_unused >>> static bool sched_state_is_init(struct intel_context *ce) >>> { >>> - /* >>> - * XXX: Kernel contexts can have SCHED_STATE_NO_LOCK_REGISTERED >>> after >>> - * suspend. >>> - */ >>> - return !(ce->guc_state.sched_state &= >>> + /* Kernel contexts can have SCHED_STATE_REGISTERED after >>> suspend. */ >>> + return !(ce->guc_state.sched_state & >>> ~(SCHED_STATE_BLOCKED_MASK | SCHED_STATE_REGISTERED)); >>> } >> >> Looks important - what are the consequences? > Supposedly nothing. > > The test was only ever used inside a BUG_ON during context registration. > Rather than asserting that the condition was true, it was making the > condition true. So, in theory, there was no consequence because we > should never have hit a BUG_ON anyway. Which means the write should > always have been a no-op. > >> >> Needs Cc: stable for 5.16? > Meaning "Cc: <stable@vger.kernel.org>"? Or is there anything required to > specify 5.16? It would have been: Cc: <stable@vger.kernel.org> # v5.16+ You can use "dim fixes <sha>" and it will output you the suggested tags. But given what you say about it having no impact even in debug builds then it's not needed. Just note that explaining the impact in the commit message when Fixes: tag is present is very desirable in general. Without it maintainers have a hard time assessing and highlighting important stuff in pull requests. So I would at least ask for respin with updated commit message explaining there is no consequence and why cc stable is not needed. Regards, Tvrtko ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-02-09 8:27 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-02-08 2:07 [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state John.C.Harrison 2022-02-08 2:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2022-02-08 2:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-02-08 6:18 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2022-02-08 9:39 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2022-02-08 18:53 ` John Harrison 2022-02-09 8:27 ` Tvrtko Ursulin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox