From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/2] drm/i915: add an explict mmio base for gpio/gmbus io
Date: Fri, 23 Mar 2012 23:01:31 +0000 [thread overview]
Message-ID: <f80fcd$3udp18@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1332542616-2367-2-git-send-email-daniel.vetter@ffwll.ch>
On Fri, 23 Mar 2012 23:43:36 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Again, Valleyview modes these around, so make the mmio base more
> explicit to consolidate the base address computations to one
> HAS_PCH_SPLIT check.
>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Consolidating the offset computation is nice. Everytime I look at this I
question whether we should be using GMBUS0 or a plain 0 for the actual
registers. I think GMBUS0 wins for being greppable.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-03-23 23:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 22:43 [PATCH 1/2] drm/i915/sdov: switch IS_SDVOB to a flag Daniel Vetter
2012-03-23 22:43 ` [PATCH 2/2] drm/i915: add an explict mmio base for gpio/gmbus io Daniel Vetter
2012-03-23 23:01 ` Chris Wilson [this message]
2012-03-24 14:57 ` Daniel Vetter
2012-03-25 20:37 ` Daniel Vetter
2012-03-23 22:59 ` [PATCH 1/2] drm/i915/sdov: switch IS_SDVOB to a flag Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f80fcd$3udp18@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox