From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: split page flip queueing into per-chipset functions
Date: Tue, 14 Jun 2011 19:20:12 +0100 [thread overview]
Message-ID: <f80fcd$h9mqf@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1308075188-2821-1-git-send-email-jbarnes@virtuousgeek.org>
On Tue, 14 Jun 2011 11:13:07 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> @@ -6343,7 +6458,12 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,
> /* Offset into the new buffer for cases of shared fbs between CRTCs */
> offset = crtc->y * fb->pitch + crtc->x * fb->bits_per_pixel/8;
>
> - ret = BEGIN_LP_RING(4);
> + if (!dev_priv->display.queue_flip) {
> + ret = -ENODEV;
> + goto cleanup_objs;
> + }
> +
> + ret = dev_priv->display.queue_flip(dev, crtc, fb, obj);
Neil Brown would recommend that we use a default queue_flip that returns
-ENODEV which both removes lines of code from this complicated routine
and optimises the common case. I agree with him. :)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-06-14 18:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 18:13 [PATCH 1/2] drm/i915: split page flip queueing into per-chipset functions Jesse Barnes
2011-06-14 18:13 ` [PATCH 2/2] drm/i915: add Ivy Bridge page flip support Jesse Barnes
2011-06-14 18:22 ` Chris Wilson
2011-06-14 19:35 ` Jesse Barnes
2011-06-14 18:20 ` Chris Wilson [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-14 19:34 [PATCH 1/2] drm/i915: split page flip queueing into per-chipset functions Jesse Barnes
2011-06-16 16:19 IVB page flipping fixes (hopefully final) Jesse Barnes
2011-06-16 16:19 ` [PATCH 1/2] drm/i915: split page flip queueing into per-chipset functions Jesse Barnes
2011-06-16 18:53 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f80fcd$h9mqf@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox