* [PATCH] drm/atomic: Call ww_acquire_done after drm_modeset_lock_all
@ 2018-02-21 15:23 Maarten Lankhorst
2018-02-21 16:24 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Maarten Lankhorst @ 2018-02-21 15:23 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx
After we acquired all generic modeset locks in drm_modeset_lock_all, it's
unsafe acquire any other so just mark acquisition as done.
Atomic drivers shouldn't use drm_modeset_lock_all.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
drivers/gpu/drm/drm_modeset_lock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_modeset_lock.c b/drivers/gpu/drm/drm_modeset_lock.c
index 963e23db0fe7..8a5100685875 100644
--- a/drivers/gpu/drm/drm_modeset_lock.c
+++ b/drivers/gpu/drm/drm_modeset_lock.c
@@ -113,6 +113,7 @@ void drm_modeset_lock_all(struct drm_device *dev)
kfree(ctx);
return;
}
+ ww_acquire_done(&ctx->ww_ctx);
WARN_ON(config->acquire_ctx);
--
2.16.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/atomic: Call ww_acquire_done after drm_modeset_lock_all
2018-02-21 15:23 [PATCH] drm/atomic: Call ww_acquire_done after drm_modeset_lock_all Maarten Lankhorst
@ 2018-02-21 16:24 ` Patchwork
2018-02-21 18:36 ` [PATCH] " Daniel Vetter
2018-02-21 20:56 ` ✗ Fi.CI.IGT: warning for " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-02-21 16:24 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: drm/atomic: Call ww_acquire_done after drm_modeset_lock_all
URL : https://patchwork.freedesktop.org/series/38711/
State : success
== Summary ==
Series 38711v1 drm/atomic: Call ww_acquire_done after drm_modeset_lock_all
https://patchwork.freedesktop.org/api/1.0/series/38711/revisions/1/mbox/
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_chamelium:
Subgroup dp-crc-fast:
pass -> DMESG-WARN (fi-kbl-7500u) fdo#103841
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
fail -> PASS (fi-ivb-3520m)
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-snb-2520m) fdo#103713
fail -> PASS (fi-ivb-3520m)
Subgroup suspend-read-crc-pipe-c:
fail -> PASS (fi-ivb-3520m)
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:425s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:425s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:372s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:483s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:285s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:474s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:477s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:462s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:452s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:556s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:415s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:283s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:504s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:386s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:406s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:456s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:409s
fi-kbl-7500u total:288 pass:262 dwarn:2 dfail:0 fail:0 skip:24 time:453s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:492s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:449s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:493s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:586s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:424s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:500s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:518s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:485s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:484s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:408s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:428s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:521s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:393s
42d073db2a8593a8d1832037ffe0988403031568 drm-tip: 2018y-02m-21d-14h-03m-58s UTC integration manifest
f0281441bf56 drm/atomic: Call ww_acquire_done after drm_modeset_lock_all
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8108/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/atomic: Call ww_acquire_done after drm_modeset_lock_all
2018-02-21 15:23 [PATCH] drm/atomic: Call ww_acquire_done after drm_modeset_lock_all Maarten Lankhorst
2018-02-21 16:24 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-02-21 18:36 ` Daniel Vetter
2018-02-21 19:39 ` Harry Wentland
2018-02-21 20:56 ` ✗ Fi.CI.IGT: warning for " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2018-02-21 18:36 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx, dri-devel
On Wed, Feb 21, 2018 at 04:23:31PM +0100, Maarten Lankhorst wrote:
> After we acquired all generic modeset locks in drm_modeset_lock_all, it's
> unsafe acquire any other so just mark acquisition as done.
>
> Atomic drivers shouldn't use drm_modeset_lock_all.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Also, I'm pretty much expecting to regret this like all the other
ww_acquire_done patches I've acked, but where's the fun in not trying :-)
Cheers, Daniel
> ---
> drivers/gpu/drm/drm_modeset_lock.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_modeset_lock.c b/drivers/gpu/drm/drm_modeset_lock.c
> index 963e23db0fe7..8a5100685875 100644
> --- a/drivers/gpu/drm/drm_modeset_lock.c
> +++ b/drivers/gpu/drm/drm_modeset_lock.c
> @@ -113,6 +113,7 @@ void drm_modeset_lock_all(struct drm_device *dev)
> kfree(ctx);
> return;
> }
> + ww_acquire_done(&ctx->ww_ctx);
>
> WARN_ON(config->acquire_ctx);
>
> --
> 2.16.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/atomic: Call ww_acquire_done after drm_modeset_lock_all
2018-02-21 18:36 ` [PATCH] " Daniel Vetter
@ 2018-02-21 19:39 ` Harry Wentland
2018-03-05 9:51 ` Maarten Lankhorst
0 siblings, 1 reply; 6+ messages in thread
From: Harry Wentland @ 2018-02-21 19:39 UTC (permalink / raw)
To: Daniel Vetter, Maarten Lankhorst; +Cc: intel-gfx, dri-devel
On 2018-02-21 01:36 PM, Daniel Vetter wrote:
> On Wed, Feb 21, 2018 at 04:23:31PM +0100, Maarten Lankhorst wrote:
>> After we acquired all generic modeset locks in drm_modeset_lock_all, it's
>> unsafe acquire any other so just mark acquisition as done.
>>
>> Atomic drivers shouldn't use drm_modeset_lock_all.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Also, I'm pretty much expecting to regret this like all the other
> ww_acquire_done patches I've acked, but where's the fun in not trying :-)
>
This shouldn't really hurt anything, other than throw DEBUG warnings if DEBUG_MUTEXES is on.
Acked-by: Harry Wentland <harry.wentland@amd.com>
Harry
> Cheers, Daniel
>
>> ---
>> drivers/gpu/drm/drm_modeset_lock.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/drm_modeset_lock.c b/drivers/gpu/drm/drm_modeset_lock.c
>> index 963e23db0fe7..8a5100685875 100644
>> --- a/drivers/gpu/drm/drm_modeset_lock.c
>> +++ b/drivers/gpu/drm/drm_modeset_lock.c
>> @@ -113,6 +113,7 @@ void drm_modeset_lock_all(struct drm_device *dev)
>> kfree(ctx);
>> return;
>> }
>> + ww_acquire_done(&ctx->ww_ctx);
>>
>> WARN_ON(config->acquire_ctx);
>>
>> --
>> 2.16.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/atomic: Call ww_acquire_done after drm_modeset_lock_all
2018-02-21 19:39 ` Harry Wentland
@ 2018-03-05 9:51 ` Maarten Lankhorst
0 siblings, 0 replies; 6+ messages in thread
From: Maarten Lankhorst @ 2018-03-05 9:51 UTC (permalink / raw)
To: Harry Wentland, Daniel Vetter; +Cc: intel-gfx, dri-devel
Op 21-02-18 om 20:39 schreef Harry Wentland:
> On 2018-02-21 01:36 PM, Daniel Vetter wrote:
>> On Wed, Feb 21, 2018 at 04:23:31PM +0100, Maarten Lankhorst wrote:
>>> After we acquired all generic modeset locks in drm_modeset_lock_all, it's
>>> unsafe acquire any other so just mark acquisition as done.
>>>
>>> Atomic drivers shouldn't use drm_modeset_lock_all.
>>>
>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>
>> Also, I'm pretty much expecting to regret this like all the other
>> ww_acquire_done patches I've acked, but where's the fun in not trying :-)
>>
> This shouldn't really hurt anything, other than throw DEBUG warnings if DEBUG_MUTEXES is on.
>
> Acked-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
>> Cheers, Daniel
>>
>>> ---
>>> drivers/gpu/drm/drm_modeset_lock.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_modeset_lock.c b/drivers/gpu/drm/drm_modeset_lock.c
>>> index 963e23db0fe7..8a5100685875 100644
>>> --- a/drivers/gpu/drm/drm_modeset_lock.c
>>> +++ b/drivers/gpu/drm/drm_modeset_lock.c
>>> @@ -113,6 +113,7 @@ void drm_modeset_lock_all(struct drm_device *dev)
>>> kfree(ctx);
>>> return;
>>> }
>>> + ww_acquire_done(&ctx->ww_ctx);
>>>
>>> WARN_ON(config->acquire_ctx);
>>>
>>> --
>>> 2.16.1
>>>
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Thanks, pushed.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.IGT: warning for drm/atomic: Call ww_acquire_done after drm_modeset_lock_all
2018-02-21 15:23 [PATCH] drm/atomic: Call ww_acquire_done after drm_modeset_lock_all Maarten Lankhorst
2018-02-21 16:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-21 18:36 ` [PATCH] " Daniel Vetter
@ 2018-02-21 20:56 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-02-21 20:56 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: drm/atomic: Call ww_acquire_done after drm_modeset_lock_all
URL : https://patchwork.freedesktop.org/series/38711/
State : warning
== Summary ==
Test kms_flip:
Subgroup 2x-plain-flip-ts-check:
pass -> FAIL (shard-hsw) fdo#100368 +1
Subgroup dpms-vs-vblank-race-interruptible:
pass -> FAIL (shard-hsw) fdo#103060
Test perf:
Subgroup enable-disable:
pass -> FAIL (shard-apl) fdo#103715
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-pri-indfb-draw-mmap-gtt:
pass -> FAIL (shard-apl) fdo#101623
Test kms_sysfs_edid_timing:
warn -> FAIL (shard-hsw) fdo#100047
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-c-frame-sequence:
fail -> PASS (shard-apl) fdo#103481
Test kms_chv_cursor_fail:
Subgroup pipe-b-256x256-bottom-edge:
pass -> DMESG-WARN (shard-snb)
Test kms_atomic_transition:
Subgroup 1x-modeset-transitions-nonblocking-fencing:
fail -> PASS (shard-apl) fdo#103207
Test drv_suspend:
Subgroup fence-restore-untiled:
pass -> SKIP (shard-snb)
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103715 https://bugs.freedesktop.org/show_bug.cgi?id=103715
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
fdo#103207 https://bugs.freedesktop.org/show_bug.cgi?id=103207
shard-apl total:3300 pass:1729 dwarn:1 dfail:0 fail:15 skip:1553 time:11773s
shard-hsw total:3464 pass:1764 dwarn:1 dfail:0 fail:6 skip:1693 time:11927s
shard-snb total:3464 pass:1352 dwarn:2 dfail:0 fail:3 skip:2107 time:6611s
Blacklisted hosts:
shard-kbl total:3464 pass:1940 dwarn:18 dfail:4 fail:13 skip:1489 time:9659s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8108/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-05 9:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-21 15:23 [PATCH] drm/atomic: Call ww_acquire_done after drm_modeset_lock_all Maarten Lankhorst
2018-02-21 16:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-21 18:36 ` [PATCH] " Daniel Vetter
2018-02-21 19:39 ` Harry Wentland
2018-03-05 9:51 ` Maarten Lankhorst
2018-02-21 20:56 ` ✗ Fi.CI.IGT: warning for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox