From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v2 10/11] drm/i915: Improve PSR2 CTL macros
Date: Mon, 03 Dec 2018 15:03:52 -0800 [thread overview]
Message-ID: <ff68d30dfc4bfcb8b6fac83b761767c47dc9a895.camel@intel.com> (raw)
In-Reply-To: <20181130022525.25676-10-jose.souza@intel.com>
On Thu, 2018-11-29 at 18:25 -0800, José Roberto de Souza wrote:
> - Reusing the EDP_PSR2_FRAME_BEFORE_SU_SHIFT in
> EDP_PSR2_FRAME_BEFORE_SU
> - Removing unused EDP_PSR2_FRAME_BEFORE_SU_MASK
> - Adding EDP_PSR2_FRAME_BEFORE_SU_MAX
> - Adding EDP_PSR2_IDLE_FRAME()
> - Adding EDP_PSR2_IDLE_FRAME_MAX
>
> In the next patch the new macros will be used.
>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h
> index d3ef97915455..9e46da5032c0 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -4216,10 +4216,11 @@ enum {
> #define EDP_PSR2_TP2_TIME_50us (3 << 8)
> #define EDP_PSR2_TP2_TIME_MASK (3 << 8)
> #define EDP_PSR2_FRAME_BEFORE_SU_SHIFT 4
> -#define EDP_PSR2_FRAME_BEFORE_SU_MASK (0xf << 4)
_MASKs are useful when we want to read back the register for debugging.
So, I'm not fully convinced this is an improvement.
Rodrigo, your thoughts on this?
> -#define EDP_PSR2_FRAME_BEFORE_SU(a) ((a) << 4)
> -#define EDP_PSR2_IDLE_FRAME_MASK 0xf
> +#define EDP_PSR2_FRAME_BEFORE_SU_MAX 0xf
> +#define EDP_PSR2_FRAME_BEFORE_SU(a) ((a) <<
> EDP_PSR2_FRAME_BEFORE_SU_SHIFT)
> #define EDP_PSR2_IDLE_FRAME_SHIFT 0
> +#define EDP_PSR2_IDLE_FRAME_MAX 0xf
Not sure if this is better than re-using _MASK here. I'm sure there are
places in the driver where we already do that.
> +#define EDP_PSR2_IDLE_FRAME(a) ((a) <<
> EDP_PSR2_IDLE_FRAME_SHIFT)
>
> #define _PSR_EVENT_TRANS_A 0x60848
> #define _PSR_EVENT_TRANS_B 0x61848
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-03 23:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 2:25 [PATCH v2 01/11] drm/i915: Disable PSR in Apple panels José Roberto de Souza
2018-11-30 2:25 ` [PATCH v2 02/11] drm/i915/psr: Don't tell sink that main link will be active while is active PSR2 José Roberto de Souza
2018-11-30 23:42 ` Dhinakaran Pandiyan
2018-11-30 2:25 ` [PATCH v2 03/11] drm/i915/psr: Set PSR CRC verification bit in sink inside PSR1 block José Roberto de Souza
2018-11-30 23:54 ` Dhinakaran Pandiyan
2018-12-03 20:24 ` Souza, Jose
2018-11-30 2:25 ` [PATCH v2 04/11] drm/i915/psr: Enable sink to trigger a interruption on PSR2 CRC mismatch José Roberto de Souza
2018-12-01 0:00 ` Dhinakaran Pandiyan
2018-11-30 2:25 ` [PATCH v2 05/11] drm/i915/icl: Do not change reserved registers related to PSR2 José Roberto de Souza
2018-11-30 2:25 ` [PATCH v2 06/11] drm: Add the PSR SU granularity registers offsets José Roberto de Souza
2018-12-01 0:13 ` Dhinakaran Pandiyan
2018-11-30 2:25 ` [PATCH v2 07/11] drm/i915/psr: Check if resolution is supported by default SU granularity José Roberto de Souza
2018-12-01 0:37 ` Dhinakaran Pandiyan
2018-12-03 20:40 ` Souza, Jose
2018-11-30 2:25 ` [PATCH v2 08/11] drm/i915/psr: Check if source supports sink specific " José Roberto de Souza
2018-12-03 20:59 ` Dhinakaran Pandiyan
2018-12-03 22:45 ` Souza, Jose
2018-12-03 23:12 ` Pandiyan, Dhinakaran
2018-12-03 23:18 ` Souza, Jose
2018-11-30 2:25 ` [PATCH v2 09/11] drm/i915: Remove old PSR2 FIXME about frontbuffer tracking José Roberto de Souza
2018-11-30 2:25 ` [PATCH v2 10/11] drm/i915: Improve PSR2 CTL macros José Roberto de Souza
2018-12-03 23:03 ` Dhinakaran Pandiyan [this message]
2018-12-03 23:10 ` Rodrigo Vivi
2018-11-30 2:25 ` [PATCH v2 11/11] drm/i915/psr: Set the right frames values José Roberto de Souza
2018-11-30 2:37 ` ✗ Fi.CI.SPARSE: warning for series starting with [v2,01/11] drm/i915: Disable PSR in Apple panels Patchwork
2018-11-30 2:55 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-30 20:53 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-30 23:35 ` [PATCH v2 01/11] " Dhinakaran Pandiyan
2018-12-03 20:14 ` Souza, Jose
2018-12-03 22:45 ` Dhinakaran Pandiyan
2018-12-03 22:53 ` Souza, Jose
2018-12-03 20:40 ` Dhinakaran Pandiyan
2018-12-03 12:04 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff68d30dfc4bfcb8b6fac83b761767c47dc9a895.camel@intel.com \
--to=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox