Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v2 06/11] drm: Add the PSR SU granularity registers offsets
Date: Fri, 30 Nov 2018 16:13:01 -0800	[thread overview]
Message-ID: <3ec0ea7d3d31e74ba4399cf2d0046d219a958efb.camel@intel.com> (raw)
In-Reply-To: <20181130022525.25676-6-jose.souza@intel.com>

On Thu, 2018-11-29 at 18:25 -0800, José Roberto de Souza wrote:
> Source is required to comply to sink SU granularity when
> DP_PSR2_SU_GRANULARITY_REQUIRED is set in DP_PSR_CAPS,
> so adding the registers offsets.
> 
> v2: Also adding DP_PSR2_SU_Y_GRANULARITY(Rodrigo)
> 
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  include/drm/drm_dp_helper.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/drm/drm_dp_helper.h
> b/include/drm/drm_dp_helper.h
> index 047314ce25d6..0e04b2db3dde 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -314,6 +314,10 @@
>  # define DP_PSR_SETUP_TIME_SHIFT            1
>  # define DP_PSR2_SU_Y_COORDINATE_REQUIRED   (1 << 4)  /* eDP 1.4a */
>  # define DP_PSR2_SU_GRANULARITY_REQUIRED    (1 << 5)  /* eDP 1.4b */
> +
> +#define DP_PSR2_SU_X_GRANULARITY	    0x072 /* eDP 1.4b */
> +#define DP_PSR2_SU_Y_GRANULARITY	    0x074 /* eDP 1.4b */
Definitions above use spaces instead of tabs, so it'd have been good to
be consistent. But, there are places in the file where tabs are used
too, so will leave it to you if you want to switch.

> +
Verified against eDP spec 1.4b
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

>  /*
>   * 0x80-0x8f describe downstream port capabilities, but there are
> two layouts
>   * based on whether DP_DETAILED_CAP_INFO_AVAILABLE was set.  If it
> was not,

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-12-01  0:13 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30  2:25 [PATCH v2 01/11] drm/i915: Disable PSR in Apple panels José Roberto de Souza
2018-11-30  2:25 ` [PATCH v2 02/11] drm/i915/psr: Don't tell sink that main link will be active while is active PSR2 José Roberto de Souza
2018-11-30 23:42   ` Dhinakaran Pandiyan
2018-11-30  2:25 ` [PATCH v2 03/11] drm/i915/psr: Set PSR CRC verification bit in sink inside PSR1 block José Roberto de Souza
2018-11-30 23:54   ` Dhinakaran Pandiyan
2018-12-03 20:24     ` Souza, Jose
2018-11-30  2:25 ` [PATCH v2 04/11] drm/i915/psr: Enable sink to trigger a interruption on PSR2 CRC mismatch José Roberto de Souza
2018-12-01  0:00   ` Dhinakaran Pandiyan
2018-11-30  2:25 ` [PATCH v2 05/11] drm/i915/icl: Do not change reserved registers related to PSR2 José Roberto de Souza
2018-11-30  2:25 ` [PATCH v2 06/11] drm: Add the PSR SU granularity registers offsets José Roberto de Souza
2018-12-01  0:13   ` Dhinakaran Pandiyan [this message]
2018-11-30  2:25 ` [PATCH v2 07/11] drm/i915/psr: Check if resolution is supported by default SU granularity José Roberto de Souza
2018-12-01  0:37   ` Dhinakaran Pandiyan
2018-12-03 20:40     ` Souza, Jose
2018-11-30  2:25 ` [PATCH v2 08/11] drm/i915/psr: Check if source supports sink specific " José Roberto de Souza
2018-12-03 20:59   ` Dhinakaran Pandiyan
2018-12-03 22:45     ` Souza, Jose
2018-12-03 23:12       ` Pandiyan, Dhinakaran
2018-12-03 23:18         ` Souza, Jose
2018-11-30  2:25 ` [PATCH v2 09/11] drm/i915: Remove old PSR2 FIXME about frontbuffer tracking José Roberto de Souza
2018-11-30  2:25 ` [PATCH v2 10/11] drm/i915: Improve PSR2 CTL macros José Roberto de Souza
2018-12-03 23:03   ` Dhinakaran Pandiyan
2018-12-03 23:10     ` Rodrigo Vivi
2018-11-30  2:25 ` [PATCH v2 11/11] drm/i915/psr: Set the right frames values José Roberto de Souza
2018-11-30  2:37 ` ✗ Fi.CI.SPARSE: warning for series starting with [v2,01/11] drm/i915: Disable PSR in Apple panels Patchwork
2018-11-30  2:55 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-30 20:53 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-30 23:35 ` [PATCH v2 01/11] " Dhinakaran Pandiyan
2018-12-03 20:14   ` Souza, Jose
2018-12-03 22:45     ` Dhinakaran Pandiyan
2018-12-03 22:53       ` Souza, Jose
2018-12-03 20:40   ` Dhinakaran Pandiyan
2018-12-03 12:04 ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ec0ea7d3d31e74ba4399cf2d0046d219a958efb.camel@intel.com \
    --to=dhinakaran.pandiyan@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox