Re: [PATCH 2/4] drm/i915/bios: Parse eDP fast link training params only if enabled

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/i915/bios: commit message omits clamping rate to
  max_link_rate
--

commit 3610be7f547f32532810e072a6b6707742df692f
Author: Lee Shawn C <shawn.c.lee@intel.com>

drm/i915/bios: Parse eDP fast link training params only if enabled

This commit parses the VBT eDP fast link training enable bit and only
populates the fast link training parameters when that bit is set, while
also normalizing the parsed rate and lane count values.

> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 6b2924c56cae3..378f8b60b4a09 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c

[ ... ]

> @@ -1526,6 +1532,29 @@ parse_edp_fast_link_params(struct intel_display *display,
>  			    edp_link_params->vswing);
>  		break;
>  	}
> +
> +	/*
> +	 * The fast link training rate is limited by the eDP max port link
> +	 * rate: FLT rate = min(FLT rate, eDP max port link rate).
> +	 */
> +	if (panel->vbt.edp.rate && panel->vbt.edp.max_link_rate)
> +		panel->vbt.edp.rate = min(panel->vbt.edp.rate,
> +					  panel->vbt.edp.max_link_rate);

[Severity: Low]
This isn't a bug, but the commit message does not mention clamping
panel->vbt.edp.rate to panel->vbt.edp.max_link_rate or reordering
parse_edp_fast_link_params() in parse_edp() after max_link_rate is parsed.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110115432.894616-1-shawn.c.lee@intel.com?part=2