* [PATCH] drm/i915/dip: Clear VSC_SELECT before setting it
@ 2026-11-18 13:14 Eriksen Xie
2026-11-18 13:21 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Eriksen Xie @ 2026-11-18 13:14 UTC (permalink / raw)
To: intel-gfx, intel-xe
Cc: Ankit Nautiyal, Chaitanya Kumar Borah, Ville Syrjälä,
Suraj Kandpal
VSC_SELECT in VIDEO_DIP_CTL is a two bit field selecting whether the
header and the data of the VSC SDP are generated by the hardware or
taken from the DIP data registers. hsw_write_infoframe() ORs
VSC_DIP_HW_DATA_SW_HEA into the value read back from the register
without clearing the field first, so a different value left in it,
e.g. by the firmware, isn't replaced but combined with the new one
(VSC_DIP_HW_HEA_SW_DATA | VSC_DIP_HW_DATA_SW_HEA results in
VSC_DIP_SW_HEA_DATA).
Clear the field before setting it.
Signed-off-by: Eriksen Xie <xiaolu.xie@intel.com>
---
This was split out of my earlier patch [1], as suggested by Ankit in the
review of Chaitanya's v2 [2]. It doesn't depend on that patch and applies
with or without it.
There is no report of a stale VSC_SELECT value on actual hardware, the
issue follows from the field being only ORed into.
[1] https://patchwork.freedesktop.org/patch/763779/
[2] https://lists.freedesktop.org/archives/intel-gfx/2026-November/400881.html
drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 4ec0db8d93..14dacbb58a 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -552,8 +552,10 @@ void hsw_write_infoframe(struct intel_encoder *encoder,
!crtc_state->has_panel_replay && type == DP_SDP_VSC))
val |= hsw_infoframe_enable(type);
- if (type == DP_SDP_VSC)
+ if (type == DP_SDP_VSC) {
+ val &= ~VSC_SELECT_MASK;
val |= VSC_DIP_HW_DATA_SW_HEA;
+ }
intel_de_write(display, ctl_reg, val);
intel_de_posting_read(display, ctl_reg);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915/dip: Clear VSC_SELECT before setting it
2026-11-18 13:14 [PATCH] drm/i915/dip: Clear VSC_SELECT before setting it Eriksen Xie
@ 2026-11-18 13:21 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-18 13:21 UTC (permalink / raw)
To: Eriksen Xie, intel-gfx, intel-xe
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/i915/dip: missing Fixes trailer for VSC_SELECT in
hsw_write_infoframe()
--
commit f244e26161b0f3b5713588fd3abc78616009d0e8
Author: Eriksen Xie <xiaolu.xie@intel.com>
> drm/i915/dip: Clear VSC_SELECT before setting it
>
> VSC_SELECT in VIDEO_DIP_CTL is a two bit field selecting whether the
> header and the data of the VSC SDP are generated by the hardware or
> taken from the DIP data registers. hsw_write_infoframe() ORs
> VSC_DIP_HW_DATA_SW_HEA into the value read back from the register
> without clearing the field first, so a different value left in it,
> e.g. by the firmware, isn't replaced but combined with the new one
> (VSC_DIP_HW_HEA_SW_DATA | VSC_DIP_HW_DATA_SW_HEA results in
> VSC_DIP_SW_HEA_DATA).
>
> Clear the field before setting it.
>
> Signed-off-by: Eriksen Xie <xiaolu.xie@intel.com>
[Severity: Low]
This fixes the unmasked VSC_SELECT bitfield update in
hsw_write_infoframe(). Should this include:
Fixes: bac2d7d8e64b ("drm/i915/display: Take care of VSC select field in video dip ctl register")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118131441.2023100-1-xiaolu.xie@intel.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-18 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 13:14 [PATCH] drm/i915/dip: Clear VSC_SELECT before setting it Eriksen Xie
2026-11-18 13:21 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox