[PATCH] drm/i915: disable temporal dithering on the internal panel

[PATCH] drm/i915: disable temporal dithering on the internal panel

[Daniel Vetter]

<ajax> i'm getting tempted to just disable temporal
<mjg59> Approved.
<ajax> apparently it makes the screen look pulse-y which is worse
than the disease.

References: http://lists.freedesktop.org/archives/intel-gfx/2011-October/012545.html
Tested-by: Олег Герман <oleg.german@gmail.com>
Cc: Adam Jackson <ajax@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index f0e5f9f..6fa1e12 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5533,7 +5533,7 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
 	pipeconf &= ~PIPECONF_DITHER_TYPE_MASK;
 	if ((is_lvds && dev_priv->lvds_dither) || dither) {
 		pipeconf |= PIPECONF_DITHER_EN;
-		pipeconf |= PIPECONF_DITHER_TYPE_ST1;
+		pipeconf |= PIPECONF_DITHER_TYPE_SP;
 	}
 	if (is_dp || intel_encoder_is_pch_edp(&has_edp_encoder->base)) {
 		intel_dp_set_m_n(crtc, mode, adjusted_mode);
-- 
1.7.6.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: disable temporal dithering on the internal panel

[Adam Jackson]

On 10/11/11 11:27 AM, Daniel Vetter wrote:
> <ajax>  i'm getting tempted to just disable temporal
> <mjg59>  Approved.
> <ajax>  apparently it makes the screen look pulse-y which is worse
> than the disease.
>
> References: http://lists.freedesktop.org/archives/intel-gfx/2011-October/012545.html
> Tested-by: Олег Герман<oleg.german@gmail.com>
> Cc: Adam Jackson<ajax@redhat.com>
> Signed-off-by: Daniel Vetter<daniel.vetter@ffwll.ch>

I was going to call you out for not also removing it from the GM45 DP 
path, but apparently it's no longer there anyway.

Might be worth wiring this up as an output property someday.

Reviewed-by: Adam Jackson <ajax@redhat.com>

- ajax
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: disable temporal dithering on the internal panel

[Chris Wilson]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

On Tue, 11 Oct 2011 12:02:58 -0400, Adam Jackson <ajax@redhat.com> wrote:
> On 10/11/11 11:27 AM, Daniel Vetter wrote:
> > <ajax>  i'm getting tempted to just disable temporal
> > <mjg59>  Approved.
> > <ajax>  apparently it makes the screen look pulse-y which is worse
> > than the disease.
> >
> > References: http://lists.freedesktop.org/archives/intel-gfx/2011-October/012545.html
> > Tested-by: Олег Герман<oleg.german@gmail.com>
> > Cc: Adam Jackson<ajax@redhat.com>
> > Signed-off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
> 
> I was going to call you out for not also removing it from the GM45 DP 
> path, but apparently it's no longer there anyway.
> 
> Might be worth wiring this up as an output property someday.

Good idea, Daniel can you include a hint for a rainy day?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: disable temporal dithering on the internal panel

[Daniel Vetter]

Hi Keith,

This patch hasn't shown up in your -next pull request. Please consider
merging for 3.2.

Yours, Daniel

On Tue, Oct 11, 2011 at 12:02:58PM -0400, Adam Jackson wrote:
> On 10/11/11 11:27 AM, Daniel Vetter wrote:
> ><ajax>  i'm getting tempted to just disable temporal
> ><mjg59>  Approved.
> ><ajax>  apparently it makes the screen look pulse-y which is worse
> >than the disease.
> >
> >References: http://lists.freedesktop.org/archives/intel-gfx/2011-October/012545.html
> >Tested-by: Олег Герман<oleg.german@gmail.com>
> >Cc: Adam Jackson<ajax@redhat.com>
> >Signed-off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
> 
> I was going to call you out for not also removing it from the GM45
> DP path, but apparently it's no longer there anyway.
> 
> Might be worth wiring this up as an output property someday.
> 
> Reviewed-by: Adam Jackson <ajax@redhat.com>
> 
> - ajax

-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: disable temporal dithering on the internal panel

[Keith Packard]

[-- Attachment #1.1: Type: text/plain, Size: 317 bytes --]

On Sun, 23 Oct 2011 12:03:32 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> Hi Keith,
> 
> This patch hasn't shown up in your -next pull request. Please consider
> merging for 3.2.

So small I missed it? I'll send it in the next set after Dave merges
what I've posted so far.

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx