From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>,
Wander Lairson Costa <wander@redhat.com>
Cc: intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock
Date: Mon, 23 Sep 2024 11:02:55 +0200 [thread overview]
Message-ID: <02076f9d-1158-4f3e-85cc-83ee4d41091e@intel.com> (raw)
In-Reply-To: <7e2c75bf-3ec5-4202-8b69-04fce763e948@molgen.mpg.de>
On 9/21/24 14:52, Paul Menzel wrote:
> Dear Wander,
>
>
> Thank you for your patch.
>
> Am 20.09.24 um 20:59 schrieb Wander Lairson Costa:
>> tx_queue_lock and stats_lock are declared and initialized, but never
>> used. Remove them.
>>
>> Signed-off-by: Wander Lairson Costa <wander@redhat.com>
>
> It’d be great if you added a Fixes: tag.
Alternatively you could split this series into two, and send this patch
to iwl-next tree, without the fixes tag. For me this patch is just
a cleanup, not a fix.
>
[...]
>
> With that addressed:
>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
>
>
> Kind regards,
>
> Paul
next prev parent reply other threads:[~2024-09-23 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 18:59 [Intel-wired-lan] [PATCH 0/2] Fixes in igbvf driver Wander Lairson Costa
2024-09-20 18:59 ` [Intel-wired-lan] [PATCH 1/2] igb: Disable threaded IRQ for igb_msix_other Wander Lairson Costa
2024-09-23 9:07 ` Przemek Kitszel
2024-10-09 8:54 ` Romanowski, Rafal
2024-09-20 18:59 ` [Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock Wander Lairson Costa
2024-09-21 12:52 ` Paul Menzel
2024-09-23 9:02 ` Przemek Kitszel [this message]
2024-09-23 16:46 ` Wander Lairson Costa
2024-09-23 18:44 ` Tony Nguyen
2024-09-24 11:21 ` Wander Lairson Costa
2024-10-21 22:57 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02076f9d-1158-4f3e-85cc-83ee4d41091e@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox