Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: Wander Lairson Costa <wander@redhat.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Paul Menzel <pmenzel@molgen.mpg.de>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock
Date: Mon, 21 Oct 2024 15:57:21 -0700	[thread overview]
Message-ID: <e3bc08eb-a292-4b5d-bbb8-cb8787710d52@intel.com> (raw)
In-Reply-To: <CAAq0SU=n0Qym5EmpimHb=6ayEeURYpHgoYxX8ZxuFbXziKHprw@mail.gmail.com>



On 9/24/2024 4:21 AM, Wander Lairson Costa wrote:
> On Mon, Sep 23, 2024 at 3:44 PM Tony Nguyen <anthony.l.nguyen@intel.com> wrote:
>>
>>
>>
>> On 9/23/2024 9:46 AM, Wander Lairson Costa wrote:
>>> On Mon, Sep 23, 2024 at 6:04 AM Przemek Kitszel
>>> <przemyslaw.kitszel@intel.com> wrote:
>>>>
>>>> On 9/21/24 14:52, Paul Menzel wrote:
>>>>> Dear Wander,
>>>>>
>>>>>
>>>>> Thank you for your patch.
>>>>>
>>>>> Am 20.09.24 um 20:59 schrieb Wander Lairson Costa:
>>>>>> tx_queue_lock and stats_lock are declared and initialized, but never
>>>>>> used. Remove them.
>>>>>>
>>>>>> Signed-off-by: Wander Lairson Costa <wander@redhat.com>
>>>>>
>>>>> It’d be great if you added a Fixes: tag.
>>>>
>>>> Alternatively you could split this series into two, and send this patch
>>>> to iwl-next tree, without the fixes tag. For me this patch is just
>>>> a cleanup, not a fix.
>>>>
>>>>>
>>>>
>>>
>>> Should I send a new version of the patches separately?
>>
>> The patches apply to the respective trees when split out so I can take
>> these without a re-send. Patch 1 will need a Fixes: for it though...
>>
>> I'm seeing it as: 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet
>> driver")?
>>
> 
> Can you add the tag when you apply the patch or should I add it?
> 

I will add the fixes tag when I said it.

Thanks,
Jake

      reply	other threads:[~2024-10-21 22:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 18:59 [Intel-wired-lan] [PATCH 0/2] Fixes in igbvf driver Wander Lairson Costa
2024-09-20 18:59 ` [Intel-wired-lan] [PATCH 1/2] igb: Disable threaded IRQ for igb_msix_other Wander Lairson Costa
2024-09-23  9:07   ` Przemek Kitszel
2024-10-09  8:54     ` Romanowski, Rafal
2024-09-20 18:59 ` [Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock Wander Lairson Costa
2024-09-21 12:52   ` Paul Menzel
2024-09-23  9:02     ` Przemek Kitszel
2024-09-23 16:46       ` Wander Lairson Costa
2024-09-23 18:44         ` Tony Nguyen
2024-09-24 11:21           ` Wander Lairson Costa
2024-10-21 22:57             ` Jacob Keller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3bc08eb-a292-4b5d-bbb8-cb8787710d52@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=wander@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox