* [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings
@ 2023-06-05 3:15 Prasad Koya
2023-06-05 8:34 ` Neftin, Sasha
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Prasad Koya @ 2023-06-05 3:15 UTC (permalink / raw)
To: intel-wired-lan
Cc: Devora Fuxbrumer, Salam Noureddine, Anthony L Nguyen,
Bob Gilligan, Dima Ruinskiy, Amir Avivi, Prasad Koya
set TP bit in the 'supported' and 'advertising' fields. I226 only supports twisted pair copper.
Fixes: 8c5ad0dae93c9 ("igc: Add ethtool support")
Signed-off-by: Prasad Koya <prasad@arista.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 8cc077b712ad..511fc3f41208 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -1707,6 +1707,8 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
/* twisted pair */
cmd->base.port = PORT_TP;
cmd->base.phy_address = hw->phy.addr;
+ ethtool_link_ksettings_add_link_mode(cmd, supported, TP);
+ ethtool_link_ksettings_add_link_mode(cmd, advertising, TP);
/* advertising link modes */
if (hw->phy.autoneg_advertised & ADVERTISE_10_HALF)
--
2.25.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings
2023-06-05 3:15 [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings Prasad Koya
@ 2023-06-05 8:34 ` Neftin, Sasha
2023-06-05 17:05 ` Paul Menzel
2023-06-21 9:23 ` naamax.meir
2 siblings, 0 replies; 7+ messages in thread
From: Neftin, Sasha @ 2023-06-05 8:34 UTC (permalink / raw)
To: Prasad Koya, intel-wired-lan
Cc: Devora Fuxbrumer, Salam Noureddine, Anthony L Nguyen,
Bob Gilligan, Dima Ruinskiy, Amir Avivi
On 6/5/2023 06:15, Prasad Koya wrote:
> set TP bit in the 'supported' and 'advertising' fields. I226 only supports twisted pair copper.
Minor correction: i225/226 parts (instead of I226).
>
> Fixes: 8c5ad0dae93c9 ("igc: Add ethtool support")
> Signed-off-by: Prasad Koya <prasad@arista.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index 8cc077b712ad..511fc3f41208 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -1707,6 +1707,8 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
> /* twisted pair */
> cmd->base.port = PORT_TP;
> cmd->base.phy_address = hw->phy.addr;
> + ethtool_link_ksettings_add_link_mode(cmd, supported, TP);
> + ethtool_link_ksettings_add_link_mode(cmd, advertising, TP);
>
> /* advertising link modes */
> if (hw->phy.autoneg_advertised & ADVERTISE_10_HALF)
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings
2023-06-05 3:15 [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings Prasad Koya
2023-06-05 8:34 ` Neftin, Sasha
@ 2023-06-05 17:05 ` Paul Menzel
2023-06-05 18:11 ` Prasad Koya
2023-06-21 9:23 ` naamax.meir
2 siblings, 1 reply; 7+ messages in thread
From: Paul Menzel @ 2023-06-05 17:05 UTC (permalink / raw)
To: Prasad Koya
Cc: Devora Fuxbrumer, Salam Noureddine, Anthony L Nguyen,
Bob Gilligan, intel-wired-lan, Dima Ruinskiy, Amir Avivi
Dear Prasad,
Am 05.06.23 um 05:15 schrieb Prasad Koya:
> set TP bit in the 'supported' and 'advertising' fields. I226 only supports twisted pair copper.
Please wrap lines after 75 characters in commit messages.
> Fixes: 8c5ad0dae93c9 ("igc: Add ethtool support")
`scripts/checkpatch.pl` says:
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1>
("<title line>")' - ie: 'Fixes: 8c5ad0dae93c ("igc: Add ethtool support")'
> Signed-off-by: Prasad Koya <prasad@arista.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index 8cc077b712ad..511fc3f41208 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -1707,6 +1707,8 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
> /* twisted pair */
> cmd->base.port = PORT_TP;
> cmd->base.phy_address = hw->phy.addr;
> + ethtool_link_ksettings_add_link_mode(cmd, supported, TP);
> + ethtool_link_ksettings_add_link_mode(cmd, advertising, TP);
>
> /* advertising link modes */
> if (hw->phy.autoneg_advertised & ADVERTISE_10_HALF)
Kind regards,
Paul
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings
2023-06-05 17:05 ` Paul Menzel
@ 2023-06-05 18:11 ` Prasad Koya
0 siblings, 0 replies; 7+ messages in thread
From: Prasad Koya @ 2023-06-05 18:11 UTC (permalink / raw)
To: Paul Menzel, Neftin, Sasha
Cc: Devora Fuxbrumer, Salam Noureddine, Anthony L Nguyen,
Bob Gilligan, intel-wired-lan, Dima Ruinskiy, Amir Avivi
[-- Attachment #1.1: Type: text/plain, Size: 1698 bytes --]
Thanks for pointing out checkpatch.pl. Ran checkpatch.pl on the patch.
Script said patch is ready to submit.
I also fixed the " i225/226 parts" and added "Acked-by:" line.
Thanks guys.
On Mon, Jun 5, 2023 at 10:05 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> Dear Prasad,
>
>
> Am 05.06.23 um 05:15 schrieb Prasad Koya:
> > set TP bit in the 'supported' and 'advertising' fields. I226 only
> supports twisted pair copper.
>
> Please wrap lines after 75 characters in commit messages.
>
> > Fixes: 8c5ad0dae93c9 ("igc: Add ethtool support")
>
> `scripts/checkpatch.pl` says:
>
> WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1>
> ("<title line>")' - ie: 'Fixes: 8c5ad0dae93c ("igc: Add ethtool support")'
>
> > Signed-off-by: Prasad Koya <prasad@arista.com>
> > ---
> > drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> > index 8cc077b712ad..511fc3f41208 100644
> > --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> > +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> > @@ -1707,6 +1707,8 @@ static int igc_ethtool_get_link_ksettings(struct
> net_device *netdev,
> > /* twisted pair */
> > cmd->base.port = PORT_TP;
> > cmd->base.phy_address = hw->phy.addr;
> > + ethtool_link_ksettings_add_link_mode(cmd, supported, TP);
> > + ethtool_link_ksettings_add_link_mode(cmd, advertising, TP);
> >
> > /* advertising link modes */
> > if (hw->phy.autoneg_advertised & ADVERTISE_10_HALF)
>
>
> Kind regards,
>
> Paul
>
[-- Attachment #1.2: Type: text/html, Size: 2501 bytes --]
[-- Attachment #2: Type: text/plain, Size: 162 bytes --]
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings
2023-06-05 3:15 [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings Prasad Koya
2023-06-05 8:34 ` Neftin, Sasha
2023-06-05 17:05 ` Paul Menzel
@ 2023-06-21 9:23 ` naamax.meir
2 siblings, 0 replies; 7+ messages in thread
From: naamax.meir @ 2023-06-21 9:23 UTC (permalink / raw)
To: Prasad Koya, intel-wired-lan
Cc: Devora Fuxbrumer, Salam Noureddine, Anthony L Nguyen,
Bob Gilligan, Dima Ruinskiy, Amir Avivi
On 6/5/2023 06:15, Prasad Koya wrote:
> set TP bit in the 'supported' and 'advertising' fields. I226 only supports twisted pair copper.
>
> Fixes: 8c5ad0dae93c9 ("igc: Add ethtool support")
> Signed-off-by: Prasad Koya <prasad@arista.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 ++
> 1 file changed, 2 insertions(+)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings
@ 2023-06-05 18:09 Prasad Koya
2023-06-21 9:26 ` naamax.meir
0 siblings, 1 reply; 7+ messages in thread
From: Prasad Koya @ 2023-06-05 18:09 UTC (permalink / raw)
To: intel-wired-lan
Cc: Devora Fuxbrumer, Salam Noureddine, Anthony L Nguyen,
Bob Gilligan, Dima Ruinskiy, Amir Avivi, Prasad Koya
set TP bit in the 'supported' and 'advertising' fields. i225/226 parts
only support twisted pair copper.
Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Signed-off-by: Prasad Koya <prasad@arista.com>
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 8cc077b712ad..511fc3f41208 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -1707,6 +1707,8 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
/* twisted pair */
cmd->base.port = PORT_TP;
cmd->base.phy_address = hw->phy.addr;
+ ethtool_link_ksettings_add_link_mode(cmd, supported, TP);
+ ethtool_link_ksettings_add_link_mode(cmd, advertising, TP);
/* advertising link modes */
if (hw->phy.autoneg_advertised & ADVERTISE_10_HALF)
--
2.25.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings
2023-06-05 18:09 Prasad Koya
@ 2023-06-21 9:26 ` naamax.meir
0 siblings, 0 replies; 7+ messages in thread
From: naamax.meir @ 2023-06-21 9:26 UTC (permalink / raw)
To: Prasad Koya, intel-wired-lan
Cc: Devora Fuxbrumer, Salam Noureddine, Anthony L Nguyen,
Bob Gilligan, Dima Ruinskiy, Amir Avivi
On 6/5/2023 21:09, Prasad Koya wrote:
> set TP bit in the 'supported' and 'advertising' fields. i225/226 parts
> only support twisted pair copper.
>
> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
> Signed-off-by: Prasad Koya <prasad@arista.com>
> Acked-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 ++
> 1 file changed, 2 insertions(+)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-21 9:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-05 3:15 [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings Prasad Koya
2023-06-05 8:34 ` Neftin, Sasha
2023-06-05 17:05 ` Paul Menzel
2023-06-05 18:11 ` Prasad Koya
2023-06-21 9:23 ` naamax.meir
-- strict thread matches above, loose matches on Subject: below --
2023-06-05 18:09 Prasad Koya
2023-06-21 9:26 ` naamax.meir
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox