* [Intel-wired-lan] [PATCH next 2/4] e1000e: Enable TSO for stacked vlan
2015-08-06 8:57 [Intel-wired-lan] [PATCH next 1/4] igbvf: Enable TSO for stacked vlan Toshiaki Makita
@ 2015-08-06 8:57 ` Toshiaki Makita
2015-08-21 22:32 ` Brown, Aaron F
2015-08-06 8:57 ` [Intel-wired-lan] [PATCH next 3/4] ixgbe: " Toshiaki Makita
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Toshiaki Makita @ 2015-08-06 8:57 UTC (permalink / raw)
To: intel-wired-lan
Setting ndo_features_check to passthru_features_check allows the driver
to skip the check for multiple tagged TSO packets and enables stacked
vlan TSO.
Tested with I217-LM.
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 546b5da..bcabbba 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -6952,6 +6952,7 @@ static const struct net_device_ops e1000e_netdev_ops = {
#endif
.ndo_set_features = e1000_set_features,
.ndo_fix_features = e1000_fix_features,
+ .ndo_features_check = passthru_features_check,
};
/**
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Intel-wired-lan] [PATCH next 2/4] e1000e: Enable TSO for stacked vlan
2015-08-06 8:57 ` [Intel-wired-lan] [PATCH next 2/4] e1000e: " Toshiaki Makita
@ 2015-08-21 22:32 ` Brown, Aaron F
0 siblings, 0 replies; 8+ messages in thread
From: Brown, Aaron F @ 2015-08-21 22:32 UTC (permalink / raw)
To: intel-wired-lan
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Toshiaki Makita
> Sent: Thursday, August 06, 2015 1:57 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; Nelson, Shannon <shannon.nelson@intel.com>;
> Wyborny, Carolyn <carolyn.wyborny@intel.com>; Skidmore, Donald C
> <donald.c.skidmore@intel.com>; Vick, Matthew <matthew.vick@intel.com>;
> Ronciak, John <john.ronciak@intel.com>; Williams, Mitch A
> <mitch.a.williams@intel.com>
> Cc: intel-wired-lan at lists.osuosl.org; Toshiaki Makita
> <makita.toshiaki@lab.ntt.co.jp>
> Subject: [Intel-wired-lan] [PATCH next 2/4] e1000e: Enable TSO for stacked vlan
>
> Setting ndo_features_check to passthru_features_check allows the driver
> to skip the check for multiple tagged TSO packets and enables stacked
> vlan TSO.
> Tested with I217-LM.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
> 1 file changed, 1 insertion(+)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH next 3/4] ixgbe: Enable TSO for stacked vlan
2015-08-06 8:57 [Intel-wired-lan] [PATCH next 1/4] igbvf: Enable TSO for stacked vlan Toshiaki Makita
2015-08-06 8:57 ` [Intel-wired-lan] [PATCH next 2/4] e1000e: " Toshiaki Makita
@ 2015-08-06 8:57 ` Toshiaki Makita
2015-08-07 6:07 ` Jeff Kirsher
2015-08-06 8:57 ` [Intel-wired-lan] [PATCH next 4/4] ixgbevf: Enables " Toshiaki Makita
2015-08-21 22:33 ` [Intel-wired-lan] [PATCH next 1/4] igbvf: Enable " Brown, Aaron F
3 siblings, 1 reply; 8+ messages in thread
From: Toshiaki Makita @ 2015-08-06 8:57 UTC (permalink / raw)
To: intel-wired-lan
Setting ndo_features_check to passthru_features_check allows the driver
to skip the check for multiple tagged TSO packets and enables stacked
vlan TSO.
Tested with 82599ES.
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 3e6a931..1f35e6d 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -8255,6 +8255,7 @@ static const struct net_device_ops ixgbe_netdev_ops = {
.ndo_dfwd_del_station = ixgbe_fwd_del,
.ndo_add_vxlan_port = ixgbe_add_vxlan_port,
.ndo_del_vxlan_port = ixgbe_del_vxlan_port,
+ .ndo_features_check = passthru_features_check,
};
/**
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Intel-wired-lan] [PATCH next 3/4] ixgbe: Enable TSO for stacked vlan
2015-08-06 8:57 ` [Intel-wired-lan] [PATCH next 3/4] ixgbe: " Toshiaki Makita
@ 2015-08-07 6:07 ` Jeff Kirsher
2015-08-07 6:22 ` Toshiaki Makita
0 siblings, 1 reply; 8+ messages in thread
From: Jeff Kirsher @ 2015-08-07 6:07 UTC (permalink / raw)
To: intel-wired-lan
On Thu, 2015-08-06 at 17:57 +0900, Toshiaki Makita wrote:
> Setting ndo_features_check to passthru_features_check allows the
> driver
> to skip the check for multiple tagged TSO packets and enables stacked
> vlan TSO.
> Tested with 82599ES.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 +
> 1 file changed, 1 insertion(+)
NACK!
This does not apply cleanly AND the ixgbe code already has
a .ndo_features_check which is assigned to our ixgbe_features_check().
PLEASE pull my tree to ensure you are using the latest code when
generating patches.
Dropping this patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20150806/7448b70d/attachment.asc>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH next 3/4] ixgbe: Enable TSO for stacked vlan
2015-08-07 6:07 ` Jeff Kirsher
@ 2015-08-07 6:22 ` Toshiaki Makita
0 siblings, 0 replies; 8+ messages in thread
From: Toshiaki Makita @ 2015-08-07 6:22 UTC (permalink / raw)
To: intel-wired-lan
On 2015/08/07 15:07, Jeff Kirsher wrote:
> On Thu, 2015-08-06 at 17:57 +0900, Toshiaki Makita wrote:
>> Setting ndo_features_check to passthru_features_check allows the
>> driver
>> to skip the check for multiple tagged TSO packets and enables stacked
>> vlan TSO.
>> Tested with 82599ES.
>>
>> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
>> ---
>> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> NACK!
>
> This does not apply cleanly AND the ixgbe code already has
> a .ndo_features_check which is assigned to our ixgbe_features_check().
>
> PLEASE pull my tree to ensure you are using the latest code when
> generating patches.
Oops...
I tested patches on next-queue's "master" branch but I now realize I
should have tested on "dev-queue" branch..
I'm sorry, this patch is completely unnecessary since
ixgbe_features_check() doesn't call vlan_check_features().
Toshiaki Makita
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH next 4/4] ixgbevf: Enables TSO for stacked vlan
2015-08-06 8:57 [Intel-wired-lan] [PATCH next 1/4] igbvf: Enable TSO for stacked vlan Toshiaki Makita
2015-08-06 8:57 ` [Intel-wired-lan] [PATCH next 2/4] e1000e: " Toshiaki Makita
2015-08-06 8:57 ` [Intel-wired-lan] [PATCH next 3/4] ixgbe: " Toshiaki Makita
@ 2015-08-06 8:57 ` Toshiaki Makita
2015-08-21 22:33 ` [Intel-wired-lan] [PATCH next 1/4] igbvf: Enable " Brown, Aaron F
3 siblings, 0 replies; 8+ messages in thread
From: Toshiaki Makita @ 2015-08-06 8:57 UTC (permalink / raw)
To: intel-wired-lan
Setting ndo_features_check to passthru_features_check allows the driver
to skip the check for multiple tagged TSO packets and enables stacked
vlan TSO.
Tested with 82599ES.
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index 88298a3..67c785d 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -3896,6 +3896,7 @@ static const struct net_device_ops ixgbevf_netdev_ops = {
#ifdef CONFIG_NET_POLL_CONTROLLER
.ndo_poll_controller = ixgbevf_netpoll,
#endif
+ .ndo_features_check = passthru_features_check,
};
static void ixgbevf_assign_netdev_ops(struct net_device *dev)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Intel-wired-lan] [PATCH next 1/4] igbvf: Enable TSO for stacked vlan
2015-08-06 8:57 [Intel-wired-lan] [PATCH next 1/4] igbvf: Enable TSO for stacked vlan Toshiaki Makita
` (2 preceding siblings ...)
2015-08-06 8:57 ` [Intel-wired-lan] [PATCH next 4/4] ixgbevf: Enables " Toshiaki Makita
@ 2015-08-21 22:33 ` Brown, Aaron F
3 siblings, 0 replies; 8+ messages in thread
From: Brown, Aaron F @ 2015-08-21 22:33 UTC (permalink / raw)
To: intel-wired-lan
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Toshiaki Makita
> Sent: Thursday, August 06, 2015 1:57 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; Nelson, Shannon <shannon.nelson@intel.com>;
> Wyborny, Carolyn <carolyn.wyborny@intel.com>; Skidmore, Donald C
> <donald.c.skidmore@intel.com>; Vick, Matthew <matthew.vick@intel.com>;
> Ronciak, John <john.ronciak@intel.com>; Williams, Mitch A
> <mitch.a.williams@intel.com>
> Cc: intel-wired-lan at lists.osuosl.org; Toshiaki Makita
> <makita.toshiaki@lab.ntt.co.jp>
> Subject: [Intel-wired-lan] [PATCH next 1/4] igbvf: Enable TSO for stacked vlan
>
> Setting ndo_features_check to passthru_features_check allows the driver
> to skip the check for multiple tagged TSO packets and enables stacked
> vlan TSO.
> Tested with I350.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
> ---
> drivers/net/ethernet/intel/igbvf/netdev.c | 1 +
> 1 file changed, 1 insertion(+)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread