Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [E1000-devel] i40e card Tx resets
Date: Thu, 17 Mar 2016 15:41:17 -0400	[thread overview]
Message-ID: <20160317194117.GN25656@oracle.com> (raw)
In-Reply-To: <20160317122814.00000adf@unknown>

On (03/17/16 12:28), Jesse Brandeburg wrote:
> We can ask on netdev if the driver should defend against this kind of
> input to hard_start_xmit (transmit routine), but the driver doesn't
> check the maximum length of the skb to see if it is invalid, because
> the stack can never build (only pktgen can) these invalid SKBs.
> 
> The issue is that pktgen builds skb->data with a contiguous buffer of
> whatever size transmit requested, (regardless of MTU) and then sends it
> straight to the transmit routine, no segmentation flags, no MSS set.

I see. And after you mentioned it, I checked with ixgbe, sure 
enough, that also results in a tx-hang for the pktgen test case
(whereas there were no issues with the (rds-stress , ixgbe) test.

I would surmise that pktgen is a bit of an outlier, more interesting
to focus on those cases that use the regular stack.

I dont know if dpdk can create the same issues as pktgen?

> we don't need to bring it up on netdev.  We have a way to troubleshoot
> MDDs that I can send to you, if you want to do the work.  Otherwise we
> need to have some time to reproduce here.

yes, I can do the work, since I already have this nicely set up.
Just need some hings on how to trouble-shoot the mdd.

--Sowmini


  reply	other threads:[~2016-03-17 19:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14 21:43 [Intel-wired-lan] i40e card Tx resets Sowmini Varadhan
2016-03-15  6:12 ` [Intel-wired-lan] [E1000-devel] " zhuyj
2016-03-15  8:55   ` zhuyj
2016-03-15 10:54     ` Sowmini Varadhan
2016-03-16  3:19       ` zhuyj
2016-03-16  3:25         ` Sowmini Varadhan
2016-03-16 11:46           ` zhuyj
2016-03-16 14:36             ` Sowmini Varadhan
2016-03-17  2:20               ` zhuyj
2016-03-17  2:29                 ` zhuyj
2016-03-17 18:56                 ` Sowmini Varadhan
2016-03-17 19:28                   ` Jesse Brandeburg
2016-03-17 19:41                     ` Sowmini Varadhan [this message]
2016-03-18 11:08                     ` zhuyj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160317194117.GN25656@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox