From: Alice Michael <alice.michael@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S9 5/7] i40e: fix missed "Negotiated" string in i40e_print_link_message()
Date: Mon, 26 Aug 2019 11:16:53 -0700 [thread overview]
Message-ID: <20190826181655.15106-5-alice.michael@intel.com> (raw)
In-Reply-To: <20190826181655.15106-1-alice.michael@intel.com>
From: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
The "Negotiated" string in i40e_print_link_message() function was missed.
This string has been added to the dmesg and small refactoring done removing
common substrings and unifying link status message format.
Without this patch it was not clear that FEC is related to negotiated FEC.
Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index ed8e62cb5417..161663de09ef 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -6564,19 +6564,19 @@ void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)
}
if (pf->hw.phy.link_info.link_speed == I40E_LINK_SPEED_25GB) {
- req_fec = ", Requested FEC: None";
- fec = ", FEC: None";
- an = ", Autoneg: False";
+ req_fec = "None";
+ fec = "None";
+ an = "False";
if (pf->hw.phy.link_info.an_info & I40E_AQ_AN_COMPLETED)
- an = ", Autoneg: True";
+ an = "True";
if (pf->hw.phy.link_info.fec_info &
I40E_AQ_CONFIG_FEC_KR_ENA)
- fec = ", FEC: CL74 FC-FEC/BASE-R";
+ fec = "CL74 FC-FEC/BASE-R";
else if (pf->hw.phy.link_info.fec_info &
I40E_AQ_CONFIG_FEC_RS_ENA)
- fec = ", FEC: CL108 RS-FEC";
+ fec = "CL108 RS-FEC";
/* 'CL108 RS-FEC' should be displayed when RS is requested, or
* both RS and FC are requested
@@ -6585,13 +6585,14 @@ void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)
(I40E_AQ_REQUEST_FEC_KR | I40E_AQ_REQUEST_FEC_RS)) {
if (vsi->back->hw.phy.link_info.req_fec_info &
I40E_AQ_REQUEST_FEC_RS)
- req_fec = ", Requested FEC: CL108 RS-FEC";
+ req_fec = "CL108 RS-FEC";
else
- req_fec = ", Requested FEC: CL74 FC-FEC/BASE-R";
+ req_fec = "CL74 FC-FEC/BASE-R";
}
}
- netdev_info(vsi->netdev, "NIC Link is Up, %sbps Full Duplex%s%s%s, Flow Control: %s\n",
+ netdev_info(vsi->netdev,
+ "NIC Link is Up, %sbps Full Duplex, Requested FEC: %s, Negotiated FEC: %s, Autoneg: %s, Flow Control: %s\n",
speed, req_fec, fec, an, fc);
}
--
2.21.0
next prev parent reply other threads:[~2019-08-26 18:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 18:16 [Intel-wired-lan] [next PATCH S9 1/7] i40e: Allow updating OROM when a NIC is in recovery mode Alice Michael
2019-08-26 18:16 ` [Intel-wired-lan] [next PATCH S9 2/7] i40e: use ktime_get_real_ts64 instead of ktime_to_timespec64 Alice Michael
2019-08-28 16:27 ` Bowers, AndrewX
2019-08-26 18:16 ` [Intel-wired-lan] [next PATCH S9 3/7] i40e: remove I40E_AQC_ADD_CLOUD_FILTER_OIP Alice Michael
2019-08-28 16:27 ` Bowers, AndrewX
2019-08-26 18:16 ` [Intel-wired-lan] [next PATCH S9 4/7] i40e: mark additional missing bits as reserved Alice Michael
2019-08-28 16:28 ` Bowers, AndrewX
2019-08-26 18:16 ` Alice Michael [this message]
2019-08-28 16:28 ` [Intel-wired-lan] [next PATCH S9 5/7] i40e: fix missed "Negotiated" string in i40e_print_link_message() Bowers, AndrewX
2019-08-26 18:16 ` [Intel-wired-lan] [next PATCH S9 6/7] i40e: Fix message for other card without FEC Alice Michael
2019-08-28 16:29 ` Bowers, AndrewX
2019-08-26 18:16 ` [Intel-wired-lan] [next PATCH S9 7/7] i40e: use BIT macro to specify the cloud filter field flags Alice Michael
2019-08-28 16:29 ` Bowers, AndrewX
2019-08-26 18:42 ` [Intel-wired-lan] [next PATCH S9 1/7] i40e: Allow updating OROM when a NIC is in recovery mode Kwapulinski, Piotr
2019-08-27 18:58 ` Jeff Kirsher
2019-08-29 13:49 ` Kwapulinski, Piotr
2019-09-13 17:54 ` Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826181655.15106-5-alice.michael@intel.com \
--to=alice.michael@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox