Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alice Michael <alice.michael@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S9 6/7] i40e: Fix message for other card without FEC.
Date: Mon, 26 Aug 2019 11:16:54 -0700	[thread overview]
Message-ID: <20190826181655.15106-6-alice.michael@intel.com> (raw)
In-Reply-To: <20190826181655.15106-1-alice.michael@intel.com>

From: Czeslaw Zagorski <czeslawx.zagorski@intel.com>

When variable "req_fec, fec, an" are empty,
dmesg shows log with "Requested FEC: , Negotiated FEC: , Autoneg:".
Add link dmesg log for cards without FEC.

Signed-off-by: Czeslaw Zagorski <czeslawx.zagorski@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 161663de09ef..5fed47cc8da3 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -6589,11 +6589,15 @@ void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)
 			else
 				req_fec = "CL74 FC-FEC/BASE-R";
 		}
+		netdev_info(vsi->netdev,
+			    "NIC Link is Up, %sbps Full Duplex, Requested FEC: %s, Negotiated FEC: %s, Autoneg: %s, Flow Control: %s\n",
+			    speed, req_fec, fec, an, fc);
+	} else {
+		netdev_info(vsi->netdev,
+			    "NIC Link is Up, %sbps Full Duplex, Flow Control: %s\n",
+			    speed, fc);
 	}
 
-	netdev_info(vsi->netdev,
-		    "NIC Link is Up, %sbps Full Duplex, Requested FEC: %s, Negotiated FEC: %s, Autoneg: %s, Flow Control: %s\n",
-		    speed, req_fec, fec, an, fc);
 }
 
 /**
-- 
2.21.0


  parent reply	other threads:[~2019-08-26 18:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 18:16 [Intel-wired-lan] [next PATCH S9 1/7] i40e: Allow updating OROM when a NIC is in recovery mode Alice Michael
2019-08-26 18:16 ` [Intel-wired-lan] [next PATCH S9 2/7] i40e: use ktime_get_real_ts64 instead of ktime_to_timespec64 Alice Michael
2019-08-28 16:27   ` Bowers, AndrewX
2019-08-26 18:16 ` [Intel-wired-lan] [next PATCH S9 3/7] i40e: remove I40E_AQC_ADD_CLOUD_FILTER_OIP Alice Michael
2019-08-28 16:27   ` Bowers, AndrewX
2019-08-26 18:16 ` [Intel-wired-lan] [next PATCH S9 4/7] i40e: mark additional missing bits as reserved Alice Michael
2019-08-28 16:28   ` Bowers, AndrewX
2019-08-26 18:16 ` [Intel-wired-lan] [next PATCH S9 5/7] i40e: fix missed "Negotiated" string in i40e_print_link_message() Alice Michael
2019-08-28 16:28   ` Bowers, AndrewX
2019-08-26 18:16 ` Alice Michael [this message]
2019-08-28 16:29   ` [Intel-wired-lan] [next PATCH S9 6/7] i40e: Fix message for other card without FEC Bowers, AndrewX
2019-08-26 18:16 ` [Intel-wired-lan] [next PATCH S9 7/7] i40e: use BIT macro to specify the cloud filter field flags Alice Michael
2019-08-28 16:29   ` Bowers, AndrewX
2019-08-26 18:42 ` [Intel-wired-lan] [next PATCH S9 1/7] i40e: Allow updating OROM when a NIC is in recovery mode Kwapulinski, Piotr
2019-08-27 18:58 ` Jeff Kirsher
2019-08-29 13:49   ` Kwapulinski, Piotr
2019-09-13 17:54 ` Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190826181655.15106-6-alice.michael@intel.com \
    --to=alice.michael@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox