[Intel-wired-lan] [next PATCH S9 1/7] i40e: Allow updating OROM when a NIC is in recovery mode

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

On Mon, 2019-08-26 at 11:16 -0700, Alice Michael wrote:
> From: Piotr Kwapulinski <piotr.kwapulinski@intel.com>
> 
> Allow OROM update with nvmupdate tool when a NIC is in recovery mode.
> Implemented by not exiting a recovery mode after firmware EMP reset
> and before actual OROM update.
> Previously it was not possible to do the OROM update with nvmupdate
> tool.

Should we be referencing our nvmupdate tool?  Is there a plan to
integrate this functionality into the existing ethtool interface to
update EEPROM's?

> 
> Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index a71369546c23..ed8e62cb5417 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -14559,8 +14559,8 @@ static bool i40e_check_recovery_mode(struct
> i40e_pf *pf)
>  
>  		return true;
>  	}
> -	if (test_and_clear_bit(__I40E_RECOVERY_MODE, pf->state))
> -		dev_info(&pf->pdev->dev, "Reinitializing in normal mode
> with full functionality.\n");
> +	if (test_bit(__I40E_RECOVERY_MODE, pf->state))
> +		dev_info(&pf->pdev->dev, "Please do POR to initialize
> adapter in normal mode with full functionality.\n");

POR?  What does that stand for?  Is there is a reason we are using a
cryptic acronym in what is supposed to be a useful debug message to the
end-user?

FYI, common definitions for POR are "Plan of Record" or "Provided on
Request", but neither of those make much sense in this debug message.

>  
>  	return false;
>  }

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20190827/0e1a733d/attachment.asc>