From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH S31 10/15] ice: write register with correct offset
Date: Wed, 9 Oct 2019 07:09:48 -0700 [thread overview]
Message-ID: <20191009140953.14087-10-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20191009140953.14087-1-anthony.l.nguyen@intel.com>
From: Mitch Williams <mitch.a.williams@intel.com>
The VF_MBX_ARQLEN register array is per-PF, not global, so we should not
use the absolute VF ID as an index. Instead, use the per-PF VF ID.
This fixes an issue with VFs on PFs other than 0 not seeing reset.
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
---
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
index 6fa929eae789..33b19f1ad2ed 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
@@ -390,7 +390,7 @@ static void ice_trigger_vf_reset(struct ice_vf *vf, bool is_vflr, bool is_pfr)
* by the time we get here.
*/
if (!is_pfr)
- wr32(hw, VF_MBX_ARQLEN(vf_abs_id), 0);
+ wr32(hw, VF_MBX_ARQLEN(vf->vf_id), 0);
/* In the case of a VFLR, the HW has already reset the VF and we
* just need to clean up, so don't hit the VFRTRIG register.
--
2.20.1
next prev parent reply other threads:[~2019-10-09 14:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 14:09 [Intel-wired-lan] [PATCH S31 01/15] ice: implement set_eeprom functionality Tony Nguyen
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 02/15] ice: add ethtool -m support for reading i2c eeprom modules Tony Nguyen
2019-10-16 16:17 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 03/15] ice: Add support for FW recovery mode detection Tony Nguyen
2019-10-16 16:17 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 04/15] ice: Update Boot Configuration Section read of NVM Tony Nguyen
2019-10-16 16:18 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 05/15] ice: handle DCBx non-contiguous TC request Tony Nguyen
2019-10-16 16:18 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 06/15] ice: fix driver unload flow Tony Nguyen
2019-10-16 16:20 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 07/15] ice: Adjust DCB INIT for SW mode Tony Nguyen
2019-10-16 16:20 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 08/15] ice: save PCI state in probe Tony Nguyen
2019-10-16 16:21 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 09/15] ice: Check for null pointer dereference when setting rings Tony Nguyen
2019-10-16 16:22 ` Bowers, AndrewX
2019-10-09 14:09 ` Tony Nguyen [this message]
2019-10-16 16:22 ` [Intel-wired-lan] [PATCH S31 10/15] ice: write register with correct offset Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 11/15] ice: print unsupported module message Tony Nguyen
2019-10-16 16:23 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 12/15] ice: print PCI link speed and width Tony Nguyen
2019-10-16 16:23 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 13/15] ice: Get rid of ice_cleanup_header Tony Nguyen
2019-10-16 16:24 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 14/15] ice: Rename VF function ice_vc_dis_vf to match its behavior Tony Nguyen
2019-10-16 16:24 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 15/15] ice: Fix return value when SR-IOV is not supported Tony Nguyen
2019-10-16 16:25 ` Bowers, AndrewX
2019-10-16 16:16 ` [Intel-wired-lan] [PATCH S31 01/15] ice: implement set_eeprom functionality Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009140953.14087-10-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox