From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH S31 07/15] ice: Adjust DCB INIT for SW mode
Date: Wed, 9 Oct 2019 07:09:45 -0700 [thread overview]
Message-ID: <20191009140953.14087-7-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20191009140953.14087-1-anthony.l.nguyen@intel.com>
From: Dave Ertman <david.m.ertman@intel.com>
Adjust ice_init_dcb to set the is_sw_lldp boolean
in the case where the FW has been detected to be
in an untenable state such that the driver
should forcibly make sure it is off.
This will ensure that the FW is in a known state.
Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
---
drivers/net/ethernet/intel/ice/ice_dcb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_dcb.c b/drivers/net/ethernet/intel/ice/ice_dcb.c
index dd7efff121bd..713e8a892e14 100644
--- a/drivers/net/ethernet/intel/ice/ice_dcb.c
+++ b/drivers/net/ethernet/intel/ice/ice_dcb.c
@@ -965,9 +965,9 @@ enum ice_status ice_init_dcb(struct ice_hw *hw, bool enable_mib_change)
pi->dcbx_status == ICE_DCBX_STATUS_NOT_STARTED) {
/* Get current DCBX configuration */
ret = ice_get_dcb_cfg(pi);
- pi->is_sw_lldp = (hw->adminq.sq_last_status == ICE_AQ_RC_EPERM);
if (ret)
return ret;
+ pi->is_sw_lldp = false;
} else if (pi->dcbx_status == ICE_DCBX_STATUS_DIS) {
return ICE_ERR_NOT_READY;
}
@@ -975,8 +975,8 @@ enum ice_status ice_init_dcb(struct ice_hw *hw, bool enable_mib_change)
/* Configure the LLDP MIB change event */
if (enable_mib_change) {
ret = ice_aq_cfg_lldp_mib_change(hw, true, NULL);
- if (!ret)
- pi->is_sw_lldp = false;
+ if (ret)
+ pi->is_sw_lldp = true;
}
return ret;
--
2.20.1
next prev parent reply other threads:[~2019-10-09 14:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 14:09 [Intel-wired-lan] [PATCH S31 01/15] ice: implement set_eeprom functionality Tony Nguyen
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 02/15] ice: add ethtool -m support for reading i2c eeprom modules Tony Nguyen
2019-10-16 16:17 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 03/15] ice: Add support for FW recovery mode detection Tony Nguyen
2019-10-16 16:17 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 04/15] ice: Update Boot Configuration Section read of NVM Tony Nguyen
2019-10-16 16:18 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 05/15] ice: handle DCBx non-contiguous TC request Tony Nguyen
2019-10-16 16:18 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 06/15] ice: fix driver unload flow Tony Nguyen
2019-10-16 16:20 ` Bowers, AndrewX
2019-10-09 14:09 ` Tony Nguyen [this message]
2019-10-16 16:20 ` [Intel-wired-lan] [PATCH S31 07/15] ice: Adjust DCB INIT for SW mode Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 08/15] ice: save PCI state in probe Tony Nguyen
2019-10-16 16:21 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 09/15] ice: Check for null pointer dereference when setting rings Tony Nguyen
2019-10-16 16:22 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 10/15] ice: write register with correct offset Tony Nguyen
2019-10-16 16:22 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 11/15] ice: print unsupported module message Tony Nguyen
2019-10-16 16:23 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 12/15] ice: print PCI link speed and width Tony Nguyen
2019-10-16 16:23 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 13/15] ice: Get rid of ice_cleanup_header Tony Nguyen
2019-10-16 16:24 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 14/15] ice: Rename VF function ice_vc_dis_vf to match its behavior Tony Nguyen
2019-10-16 16:24 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 15/15] ice: Fix return value when SR-IOV is not supported Tony Nguyen
2019-10-16 16:25 ` Bowers, AndrewX
2019-10-16 16:16 ` [Intel-wired-lan] [PATCH S31 01/15] ice: implement set_eeprom functionality Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009140953.14087-7-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox