From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH S31 14/15] ice: Rename VF function ice_vc_dis_vf to match its behavior
Date: Wed, 9 Oct 2019 07:09:52 -0700 [thread overview]
Message-ID: <20191009140953.14087-14-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20191009140953.14087-1-anthony.l.nguyen@intel.com>
From: Brett Creeley <brett.creeley@intel.com>
ice_vc_dis_vf() tells iavf that it's going to perform a reset
and then performs a software reset. This is misleading based on
the function name because the VF does not get disabled. So fix
this by changing the name to ice_vc_reset_vf().
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
---
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
index 33b19f1ad2ed..965bbd68caa1 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
@@ -1477,12 +1477,10 @@ void ice_process_vflr_event(struct ice_pf *pf)
}
/**
- * ice_vc_dis_vf - Disable a given VF via SW reset
+ * ice_vc_reset_vf - Perform software reset on the VF after informing the AVF
* @vf: pointer to the VF info
- *
- * Disable the VF through a SW reset
*/
-static void ice_vc_dis_vf(struct ice_vf *vf)
+static void ice_vc_reset_vf(struct ice_vf *vf)
{
ice_vc_notify_vf_reset(vf);
ice_reset_vf(vf, false);
@@ -2522,7 +2520,7 @@ static int ice_vc_request_qs_msg(struct ice_vf *vf, u8 *msg)
} else {
/* request is successful, then reset VF */
vf->num_req_qs = req_queues;
- ice_vc_dis_vf(vf);
+ ice_vc_reset_vf(vf);
dev_info(&pf->pdev->dev,
"VF %d granted request of %u queues.\n",
vf->vf_id, req_queues);
@@ -3149,7 +3147,7 @@ int ice_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac)
"MAC on VF %d set to %pM. VF driver will be reinitialized\n",
vf_id, mac);
- ice_vc_dis_vf(vf);
+ ice_vc_reset_vf(vf);
return ret;
}
@@ -3185,7 +3183,7 @@ int ice_set_vf_trust(struct net_device *netdev, int vf_id, bool trusted)
return 0;
vf->trusted = trusted;
- ice_vc_dis_vf(vf);
+ ice_vc_reset_vf(vf);
dev_info(&pf->pdev->dev, "VF %u is now %strusted\n",
vf_id, trusted ? "" : "un");
--
2.20.1
next prev parent reply other threads:[~2019-10-09 14:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 14:09 [Intel-wired-lan] [PATCH S31 01/15] ice: implement set_eeprom functionality Tony Nguyen
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 02/15] ice: add ethtool -m support for reading i2c eeprom modules Tony Nguyen
2019-10-16 16:17 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 03/15] ice: Add support for FW recovery mode detection Tony Nguyen
2019-10-16 16:17 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 04/15] ice: Update Boot Configuration Section read of NVM Tony Nguyen
2019-10-16 16:18 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 05/15] ice: handle DCBx non-contiguous TC request Tony Nguyen
2019-10-16 16:18 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 06/15] ice: fix driver unload flow Tony Nguyen
2019-10-16 16:20 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 07/15] ice: Adjust DCB INIT for SW mode Tony Nguyen
2019-10-16 16:20 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 08/15] ice: save PCI state in probe Tony Nguyen
2019-10-16 16:21 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 09/15] ice: Check for null pointer dereference when setting rings Tony Nguyen
2019-10-16 16:22 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 10/15] ice: write register with correct offset Tony Nguyen
2019-10-16 16:22 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 11/15] ice: print unsupported module message Tony Nguyen
2019-10-16 16:23 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 12/15] ice: print PCI link speed and width Tony Nguyen
2019-10-16 16:23 ` Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 13/15] ice: Get rid of ice_cleanup_header Tony Nguyen
2019-10-16 16:24 ` Bowers, AndrewX
2019-10-09 14:09 ` Tony Nguyen [this message]
2019-10-16 16:24 ` [Intel-wired-lan] [PATCH S31 14/15] ice: Rename VF function ice_vc_dis_vf to match its behavior Bowers, AndrewX
2019-10-09 14:09 ` [Intel-wired-lan] [PATCH S31 15/15] ice: Fix return value when SR-IOV is not supported Tony Nguyen
2019-10-16 16:25 ` Bowers, AndrewX
2019-10-16 16:16 ` [Intel-wired-lan] [PATCH S31 01/15] ice: implement set_eeprom functionality Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009140953.14087-14-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox