Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Guedes <andre.guedes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 00/10] igc: Align log messages
Date: Tue, 24 Mar 2020 17:38:14 -0700	[thread overview]
Message-ID: <20200325003824.5487-1-andre.guedes@intel.com> (raw)

Throughout IGC code we print log messages using different log helpers such as
dev_*, pr_*, and netdev_*, generating inconsistent output.

Since this is a network device driver, we should preferably use netdev_*
helpers because they append the interface name to the message, helping making
sense out of the logs especially when we have more than one adapter in the
system.

This patchset converts all dev_* and pr_* calls to netdev_*. There are just a
few exceptions that cannot be converted because we don't have the netdev
allocated yet (e.g. when the module is loaded and on PCI probe). It also takes
the opportunity to improve some messages and remove the '\n' character at the
end of them since is it automatically added to by netdev_* log helpers.

Regards,

Andre

Andre Guedes (10):
  igc: Use netdev log helpers in igc_main.c
  igc: Use netdev log helpers in igc_ethtool.c
  igc: Use netdev log helpers in igc_ptp.c
  igc: Use netdev log helpers in igc_dump.c
  igc: Use netdev log helpers in igc_base.c
  igc: Use netdev log helpers in igc_diag.c
  igc: Remove '\n' from log strings in igc_i225.c
  igc: Remove '\n' from log strings in igc_mac.c
  igc: Remove '\n' from log messages in igc_nvm.c
  igc: Remove '\n' from log strings in igc_phy.c

 drivers/net/ethernet/intel/igc/igc_base.c    |  16 +--
 drivers/net/ethernet/intel/igc/igc_diag.c    |  22 ++--
 drivers/net/ethernet/intel/igc/igc_dump.c    | 109 ++++++++--------
 drivers/net/ethernet/intel/igc/igc_ethtool.c |  48 ++++---
 drivers/net/ethernet/intel/igc/igc_i225.c    |  22 ++--
 drivers/net/ethernet/intel/igc/igc_mac.c     |  42 +++---
 drivers/net/ethernet/intel/igc/igc_main.c    | 129 +++++++++----------
 drivers/net/ethernet/intel/igc/igc_nvm.c     |  12 +-
 drivers/net/ethernet/intel/igc/igc_phy.c     |  52 ++++----
 drivers/net/ethernet/intel/igc/igc_ptp.c     |  12 +-
 10 files changed, 223 insertions(+), 241 deletions(-)

-- 
2.25.0


             reply	other threads:[~2020-03-25  0:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25  0:38 Andre Guedes [this message]
2020-03-25  0:38 ` [Intel-wired-lan] [PATCH 01/10] igc: Use netdev log helpers in igc_main.c Andre Guedes
2020-04-02  3:33   ` Brown, Aaron F
2020-03-25  0:38 ` [Intel-wired-lan] [PATCH 02/10] igc: Use netdev log helpers in igc_ethtool.c Andre Guedes
2020-04-02  3:35   ` Brown, Aaron F
2020-03-25  0:38 ` [Intel-wired-lan] [PATCH 03/10] igc: Use netdev log helpers in igc_ptp.c Andre Guedes
2020-04-02  3:37   ` Brown, Aaron F
2020-03-25  0:38 ` [Intel-wired-lan] [PATCH 04/10] igc: Use netdev log helpers in igc_dump.c Andre Guedes
2020-04-02  3:39   ` Brown, Aaron F
2020-03-25  0:38 ` [Intel-wired-lan] [PATCH 05/10] igc: Use netdev log helpers in igc_base.c Andre Guedes
2020-04-02  3:41   ` Brown, Aaron F
2020-03-25  0:38 ` [Intel-wired-lan] [PATCH 06/10] igc: Use netdev log helpers in igc_diag.c Andre Guedes
2020-04-02  3:42   ` Brown, Aaron F
2020-03-25  0:38 ` [Intel-wired-lan] [PATCH 07/10] igc: Remove '\n' from log strings in igc_i225.c Andre Guedes
2020-04-02  3:44   ` Brown, Aaron F
2020-03-25  0:38 ` [Intel-wired-lan] [PATCH 08/10] igc: Remove '\n' from log strings in igc_mac.c Andre Guedes
2020-04-02  3:46   ` Brown, Aaron F
2020-03-25  0:38 ` [Intel-wired-lan] [PATCH 09/10] igc: Remove '\n' from log messages in igc_nvm.c Andre Guedes
2020-04-02  3:48   ` Brown, Aaron F
2020-03-25  0:38 ` [Intel-wired-lan] [PATCH 10/10] igc: Remove '\n' from log strings in igc_phy.c Andre Guedes
2020-04-02  3:49   ` Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200325003824.5487-1-andre.guedes@intel.com \
    --to=andre.guedes@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox