From: Andre Guedes <andre.guedes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 07/10] igc: Remove '\n' from log strings in igc_i225.c
Date: Tue, 24 Mar 2020 17:38:21 -0700 [thread overview]
Message-ID: <20200325003824.5487-8-andre.guedes@intel.com> (raw)
In-Reply-To: <20200325003824.5487-1-andre.guedes@intel.com>
To keep log strings in igc_i225.c consistent with the rest of the driver
code, this patch removes the '\n' character at the end. The newline
character is automatically added by netdev_dbg() so there is no changes
in the output.
Note: hw_dbg() is a macro that expands to netdev_dbg().
Signed-off-by: Andre Guedes <andre.guedes@intel.com>
---
drivers/net/ethernet/intel/igc/igc_i225.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c
index c25f555aaf82..a5856ae87a7e 100644
--- a/drivers/net/ethernet/intel/igc/igc_i225.c
+++ b/drivers/net/ethernet/intel/igc/igc_i225.c
@@ -71,7 +71,7 @@ static s32 igc_get_hw_semaphore_i225(struct igc_hw *hw)
/* If we do not have the semaphore here, we have to give up. */
if (i == timeout) {
- hw_dbg("Driver can't access device - SMBI bit is set.\n");
+ hw_dbg("Driver can't access device - SMBI bit is set");
return -IGC_ERR_NVM;
}
}
@@ -91,7 +91,7 @@ static s32 igc_get_hw_semaphore_i225(struct igc_hw *hw)
if (i == timeout) {
/* Release semaphores */
igc_put_hw_semaphore(hw);
- hw_dbg("Driver can't access the NVM\n");
+ hw_dbg("Driver can't access the NVM");
return -IGC_ERR_NVM;
}
@@ -131,7 +131,7 @@ s32 igc_acquire_swfw_sync_i225(struct igc_hw *hw, u16 mask)
}
if (i == timeout) {
- hw_dbg("Driver can't access resource, SW_FW_SYNC timeout.\n");
+ hw_dbg("Driver can't access resource, SW_FW_SYNC timeout");
ret_val = -IGC_ERR_SWFW_SYNC;
goto out;
}
@@ -228,7 +228,7 @@ static s32 igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words,
*/
if (offset >= nvm->word_size || (words > (nvm->word_size - offset)) ||
words == 0) {
- hw_dbg("nvm parameter(s) out of bounds\n");
+ hw_dbg("nvm parameter(s) out of bounds");
ret_val = -IGC_ERR_NVM;
goto out;
}
@@ -250,7 +250,7 @@ static s32 igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words,
}
if (ret_val) {
- hw_dbg("Shadow RAM write EEWR timed out\n");
+ hw_dbg("Shadow RAM write EEWR timed out");
break;
}
}
@@ -369,7 +369,7 @@ static s32 igc_update_flash_i225(struct igc_hw *hw)
ret_val = igc_pool_flash_update_done_i225(hw);
if (ret_val == -IGC_ERR_NVM) {
- hw_dbg("Flash update time out\n");
+ hw_dbg("Flash update time out");
goto out;
}
@@ -378,9 +378,9 @@ static s32 igc_update_flash_i225(struct igc_hw *hw)
ret_val = igc_pool_flash_update_done_i225(hw);
if (ret_val)
- hw_dbg("Flash update time out\n");
+ hw_dbg("Flash update time out");
else
- hw_dbg("Flash update complete\n");
+ hw_dbg("Flash update complete");
out:
return ret_val;
@@ -406,7 +406,7 @@ static s32 igc_update_nvm_checksum_i225(struct igc_hw *hw)
*/
ret_val = igc_read_nvm_eerd(hw, 0, 1, &nvm_data);
if (ret_val) {
- hw_dbg("EEPROM read failed\n");
+ hw_dbg("EEPROM read failed");
goto out;
}
@@ -423,7 +423,7 @@ static s32 igc_update_nvm_checksum_i225(struct igc_hw *hw)
ret_val = igc_read_nvm_eerd(hw, i, 1, &nvm_data);
if (ret_val) {
hw->nvm.ops.release(hw);
- hw_dbg("NVM Read Error while updating checksum.\n");
+ hw_dbg("NVM Read Error while updating checksum");
goto out;
}
checksum += nvm_data;
@@ -433,7 +433,7 @@ static s32 igc_update_nvm_checksum_i225(struct igc_hw *hw)
&checksum);
if (ret_val) {
hw->nvm.ops.release(hw);
- hw_dbg("NVM Write Error while updating checksum.\n");
+ hw_dbg("NVM Write Error while updating checksum");
goto out;
}
--
2.25.0
next prev parent reply other threads:[~2020-03-25 0:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 0:38 [Intel-wired-lan] [PATCH 00/10] igc: Align log messages Andre Guedes
2020-03-25 0:38 ` [Intel-wired-lan] [PATCH 01/10] igc: Use netdev log helpers in igc_main.c Andre Guedes
2020-04-02 3:33 ` Brown, Aaron F
2020-03-25 0:38 ` [Intel-wired-lan] [PATCH 02/10] igc: Use netdev log helpers in igc_ethtool.c Andre Guedes
2020-04-02 3:35 ` Brown, Aaron F
2020-03-25 0:38 ` [Intel-wired-lan] [PATCH 03/10] igc: Use netdev log helpers in igc_ptp.c Andre Guedes
2020-04-02 3:37 ` Brown, Aaron F
2020-03-25 0:38 ` [Intel-wired-lan] [PATCH 04/10] igc: Use netdev log helpers in igc_dump.c Andre Guedes
2020-04-02 3:39 ` Brown, Aaron F
2020-03-25 0:38 ` [Intel-wired-lan] [PATCH 05/10] igc: Use netdev log helpers in igc_base.c Andre Guedes
2020-04-02 3:41 ` Brown, Aaron F
2020-03-25 0:38 ` [Intel-wired-lan] [PATCH 06/10] igc: Use netdev log helpers in igc_diag.c Andre Guedes
2020-04-02 3:42 ` Brown, Aaron F
2020-03-25 0:38 ` Andre Guedes [this message]
2020-04-02 3:44 ` [Intel-wired-lan] [PATCH 07/10] igc: Remove '\n' from log strings in igc_i225.c Brown, Aaron F
2020-03-25 0:38 ` [Intel-wired-lan] [PATCH 08/10] igc: Remove '\n' from log strings in igc_mac.c Andre Guedes
2020-04-02 3:46 ` Brown, Aaron F
2020-03-25 0:38 ` [Intel-wired-lan] [PATCH 09/10] igc: Remove '\n' from log messages in igc_nvm.c Andre Guedes
2020-04-02 3:48 ` Brown, Aaron F
2020-03-25 0:38 ` [Intel-wired-lan] [PATCH 10/10] igc: Remove '\n' from log strings in igc_phy.c Andre Guedes
2020-04-02 3:49 ` Brown, Aaron F
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325003824.5487-8-andre.guedes@intel.com \
--to=andre.guedes@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox