From: Kuba Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: vadim.fedorenko@linux.dev, corbet@lwn.net,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
jesse.brandeburg@intel.com,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org,
pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH net-next v3 2/5] dpll: spec: add support for pin-dpll signal phase offset/adjust
Date: Fri, 6 Oct 2023 12:44:57 -0700 [thread overview]
Message-ID: <20231006124457.26417f37@kernel.org> (raw)
In-Reply-To: <ZSA7cEEc5nKl07/z@nanopsycho>
On Fri, 6 Oct 2023 18:53:04 +0200 Jiri Pirko wrote:
> Fri, Oct 06, 2023 at 04:55:36PM CEST, kuba@kernel.org wrote:
> >> I'm confused. Didn't you say you'll remove this? If not, my question
> >> from v1 still stands.
> >
> >Perhaps we should dis-allow setting version in non-genetlink-legacy
> >specs? I thought it may be a useful thing to someone, at some point,
> >but so far the scoreboard is: legit uses: 0, confused uses: 1 :S
> >
> >Thoughts?
>
> I don't know what the meaning of version is. I just never saw that being
> touched. Is there any semantics documented for it?
>
> Kuba, any opinion?
/me switches the first name in From :P
I think it basically predates the op / policy introspection,
and allows people to break backward compat.
drop_monitor bumped to 2 in 2009:
683703a26e46 ("drop_monitor: Update netlink protocol to include
netlink attribute header in alert message")
which breaks backward compat.
genetlink ctrl went to 2 in 2006:
334c29a64507 ("[GENETLINK]: Move command capabilities to flags.")
which moves some info around in attrs, also breaks backward compat
if someone depended on the old placement.
ovs did it in 2013:
44da5ae5fbea ("openvswitch: Drop user features if old user space
attempted to create datapath")
again, breaks backwards compat.
I guess it may still make one day to bump the version for some proto
which has very tight control over the user space. But it hasn't
happened for 10 years.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-10-06 19:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 11:40 [Intel-wired-lan] [PATCH net-next v3 0/5] dpll: add phase-offset and phase-adjust Arkadiusz Kubalewski
2023-10-06 11:40 ` [Intel-wired-lan] [PATCH net-next v3 1/5] dpll: docs: add support for pin signal phase offset/adjust Arkadiusz Kubalewski
2023-10-06 11:40 ` [Intel-wired-lan] [PATCH net-next v3 2/5] dpll: spec: add support for pin-dpll " Arkadiusz Kubalewski
2023-10-06 12:30 ` Jiri Pirko
2023-10-06 14:55 ` Jakub Kicinski
2023-10-06 16:53 ` Jiri Pirko
2023-10-06 19:44 ` Kuba Kicinski [this message]
2023-10-07 10:29 ` Jiri Pirko
2023-10-09 15:22 ` Jakub Kicinski
2023-10-09 22:55 ` Kubalewski, Arkadiusz
2023-10-06 11:40 ` [Intel-wired-lan] [PATCH net-next v3 3/5] dpll: netlink/core: " Arkadiusz Kubalewski
2023-10-06 12:38 ` Jiri Pirko
2023-10-09 22:49 ` Kubalewski, Arkadiusz
2023-10-06 11:41 ` [Intel-wired-lan] [PATCH net-next v3 4/5] ice: dpll: implement phase related callbacks Arkadiusz Kubalewski
2023-10-06 12:33 ` Simon Horman
2023-10-06 12:41 ` Jiri Pirko
2023-10-06 11:41 ` [Intel-wired-lan] [PATCH net-next v3 5/5] dpll: netlink/core: change pin frequency set behavior Arkadiusz Kubalewski
2023-10-06 12:35 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006124457.26417f37@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox