* [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic
@ 2023-11-20 11:27 Jan Sokolowski
2023-11-20 21:48 ` Jacob Keller
0 siblings, 1 reply; 7+ messages in thread
From: Jan Sokolowski @ 2023-11-20 11:27 UTC (permalink / raw)
To: intel-wired-lan; +Cc: Jan Sokolowski
It was found that this statistic is incorrectly reported
by HW and thus, useless.
Remove it.
Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
---
drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 -
drivers/net/ethernet/intel/ice/ice_main.c | 5 -----
drivers/net/ethernet/intel/ice/ice_type.h | 1 -
3 files changed, 7 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
index a34083567e6f..cda98e185254 100644
--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
@@ -129,7 +129,6 @@ static const struct ice_stats ice_gstrings_pf_stats[] = {
ICE_PF_STAT("rx_oversize.nic", stats.rx_oversize),
ICE_PF_STAT("rx_jabber.nic", stats.rx_jabber),
ICE_PF_STAT("rx_csum_bad.nic", hw_csum_rx_error),
- ICE_PF_STAT("rx_length_errors.nic", stats.rx_len_errors),
ICE_PF_STAT("rx_dropped.nic", stats.eth.rx_discards),
ICE_PF_STAT("rx_crc_errors.nic", stats.crc_errors),
ICE_PF_STAT("illegal_bytes.nic", stats.illegal_bytes),
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 81044cc10931..ddeb43059126 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -6732,13 +6732,11 @@ void ice_update_vsi_stats(struct ice_vsi *vsi)
cur_ns->rx_crc_errors = pf->stats.crc_errors;
cur_ns->rx_errors = pf->stats.crc_errors +
pf->stats.illegal_bytes +
- pf->stats.rx_len_errors +
pf->stats.rx_undersize +
pf->hw_csum_rx_error +
pf->stats.rx_jabber +
pf->stats.rx_fragments +
pf->stats.rx_oversize;
- cur_ns->rx_length_errors = pf->stats.rx_len_errors;
/* record drops from the port level */
cur_ns->rx_missed_errors = pf->stats.eth.rx_discards;
}
@@ -6878,9 +6876,6 @@ void ice_update_pf_stats(struct ice_pf *pf)
&prev_ps->mac_remote_faults,
&cur_ps->mac_remote_faults);
- ice_stat_update32(hw, GLPRT_RLEC(port), pf->stat_prev_loaded,
- &prev_ps->rx_len_errors, &cur_ps->rx_len_errors);
-
ice_stat_update32(hw, GLPRT_RUC(port), pf->stat_prev_loaded,
&prev_ps->rx_undersize, &cur_ps->rx_undersize);
diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h
index 16615e322382..306d0141ea8e 100644
--- a/drivers/net/ethernet/intel/ice/ice_type.h
+++ b/drivers/net/ethernet/intel/ice/ice_type.h
@@ -1001,7 +1001,6 @@ struct ice_hw_port_stats {
u64 error_bytes; /* errbc */
u64 mac_local_faults; /* mlfc */
u64 mac_remote_faults; /* mrfc */
- u64 rx_len_errors; /* rlec */
u64 link_xon_rx; /* lxonrxc */
u64 link_xoff_rx; /* lxoffrxc */
u64 link_xon_tx; /* lxontxc */
--
2.31.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic
2023-11-20 11:27 [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic Jan Sokolowski
@ 2023-11-20 21:48 ` Jacob Keller
2023-11-29 10:26 ` Sokolowski, Jan
0 siblings, 1 reply; 7+ messages in thread
From: Jacob Keller @ 2023-11-20 21:48 UTC (permalink / raw)
To: intel-wired-lan
On 11/20/2023 3:27 AM, Jan Sokolowski wrote:
> It was found that this statistic is incorrectly reported
> by HW and thus, useless.
>
> Remove it.
Is there any further information about what is reported incorrectly? Is
rx_length_errors part of netdev stats and standardized? Does HW fail to
report some packets or does it report packets which don't have an issue?
I mean the hardware does *something*, so I think it would be good to
have an understanding of how this differs from what we expected when
proposing to remove it.
Thanks,
Jake
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic
2023-11-20 21:48 ` Jacob Keller
@ 2023-11-29 10:26 ` Sokolowski, Jan
2023-11-29 11:03 ` Przemek Kitszel
0 siblings, 1 reply; 7+ messages in thread
From: Sokolowski, Jan @ 2023-11-29 10:26 UTC (permalink / raw)
To: Keller, Jacob E, intel-wired-lan@osuosl.org
>
>On 11/20/2023 3:27 AM, Jan Sokolowski wrote:
>> It was found that this statistic is incorrectly reported
>> by HW and thus, useless.
>>
>> Remove it.
>
>Is there any further information about what is reported incorrectly? Is
>rx_length_errors part of netdev stats and standardized? Does HW fail to
>report some packets or does it report packets which don't have an issue?
>
It's a part of visible stats, standardized.
According to the bug report, HW was misreporting packets that did not have any issues.
>I mean the hardware does *something*, so I think it would be good to
>have an understanding of how this differs from what we expected when
>proposing to remove it.
>
>Thanks,
>Jake
>_______________________________________________
>Intel-wired-lan mailing list
>Intel-wired-lan@osuosl.org
>https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic
2023-11-29 10:26 ` Sokolowski, Jan
@ 2023-11-29 11:03 ` Przemek Kitszel
0 siblings, 0 replies; 7+ messages in thread
From: Przemek Kitszel @ 2023-11-29 11:03 UTC (permalink / raw)
To: Sokolowski, Jan, Keller, Jacob E, intel-wired-lan@osuosl.org
On 11/29/23 11:26, Sokolowski, Jan wrote:
>>
>> On 11/20/2023 3:27 AM, Jan Sokolowski wrote:
>>> It was found that this statistic is incorrectly reported
>>> by HW and thus, useless.
>>>
>>> Remove it.
>>
>> Is there any further information about what is reported incorrectly? Is
>> rx_length_errors part of netdev stats and standardized? Does HW fail to
>> report some packets or does it report packets which don't have an issue?
Great questions
>>
>
> It's a part of visible stats, standardized.
Please add that info into commit message of v2, and CC netdev.
Perhaps one could ask if it would be better to always-report-zero as
a value of that, standardized, stat. But if we could just remove it,
it's better.
>
> According to the bug report, HW was misreporting packets that did not have any issues.
>
>> I mean the hardware does *something*, so I think it would be good to
>> have an understanding of how this differs from what we expected when
>> proposing to remove it.
>>
>> Thanks,
>> Jake
>> _______________________________________________
>> Intel-wired-lan mailing list
>> Intel-wired-lan@osuosl.org
>> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic
@ 2023-12-06 10:43 Jan Sokolowski
2023-12-07 23:33 ` Tony Nguyen
2023-12-11 4:58 ` Pucha, HimasekharX Reddy
0 siblings, 2 replies; 7+ messages in thread
From: Jan Sokolowski @ 2023-12-06 10:43 UTC (permalink / raw)
To: intel-wired-lan; +Cc: Jan Sokolowski, Mateusz Polchlopek
It was found that this statistic is incorrectly
reported by HW and thus, useless.
As RX length error statistics are shown to the
end user when requested, the values reported
are misleading.
Thus, that value is no longer reported and
doesn't count anymore when adding all rx errors.
Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
---
drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 -
drivers/net/ethernet/intel/ice/ice_main.c | 5 -----
drivers/net/ethernet/intel/ice/ice_type.h | 1 -
3 files changed, 7 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
index bde9bc74f928..9a62d74f9379 100644
--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
@@ -129,7 +129,6 @@ static const struct ice_stats ice_gstrings_pf_stats[] = {
ICE_PF_STAT("rx_oversize.nic", stats.rx_oversize),
ICE_PF_STAT("rx_jabber.nic", stats.rx_jabber),
ICE_PF_STAT("rx_csum_bad.nic", hw_csum_rx_error),
- ICE_PF_STAT("rx_length_errors.nic", stats.rx_len_errors),
ICE_PF_STAT("rx_dropped.nic", stats.eth.rx_discards),
ICE_PF_STAT("rx_crc_errors.nic", stats.crc_errors),
ICE_PF_STAT("illegal_bytes.nic", stats.illegal_bytes),
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 08691469b489..09d508df3deb 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -6822,13 +6822,11 @@ void ice_update_vsi_stats(struct ice_vsi *vsi)
cur_ns->rx_crc_errors = pf->stats.crc_errors;
cur_ns->rx_errors = pf->stats.crc_errors +
pf->stats.illegal_bytes +
- pf->stats.rx_len_errors +
pf->stats.rx_undersize +
pf->hw_csum_rx_error +
pf->stats.rx_jabber +
pf->stats.rx_fragments +
pf->stats.rx_oversize;
- cur_ns->rx_length_errors = pf->stats.rx_len_errors;
/* record drops from the port level */
cur_ns->rx_missed_errors = pf->stats.eth.rx_discards;
}
@@ -6968,9 +6966,6 @@ void ice_update_pf_stats(struct ice_pf *pf)
&prev_ps->mac_remote_faults,
&cur_ps->mac_remote_faults);
- ice_stat_update32(hw, GLPRT_RLEC(port), pf->stat_prev_loaded,
- &prev_ps->rx_len_errors, &cur_ps->rx_len_errors);
-
ice_stat_update32(hw, GLPRT_RUC(port), pf->stat_prev_loaded,
&prev_ps->rx_undersize, &cur_ps->rx_undersize);
diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h
index 1fff865d0661..e1ded29ca59f 100644
--- a/drivers/net/ethernet/intel/ice/ice_type.h
+++ b/drivers/net/ethernet/intel/ice/ice_type.h
@@ -1002,7 +1002,6 @@ struct ice_hw_port_stats {
u64 error_bytes; /* errbc */
u64 mac_local_faults; /* mlfc */
u64 mac_remote_faults; /* mrfc */
- u64 rx_len_errors; /* rlec */
u64 link_xon_rx; /* lxonrxc */
u64 link_xoff_rx; /* lxoffrxc */
u64 link_xon_tx; /* lxontxc */
--
2.31.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic
2023-12-06 10:43 Jan Sokolowski
@ 2023-12-07 23:33 ` Tony Nguyen
2023-12-11 4:58 ` Pucha, HimasekharX Reddy
1 sibling, 0 replies; 7+ messages in thread
From: Tony Nguyen @ 2023-12-07 23:33 UTC (permalink / raw)
To: Jan Sokolowski, intel-wired-lan; +Cc: Mateusz Polchlopek
On 12/6/2023 2:43 AM, Jan Sokolowski wrote:
> It was found that this statistic is incorrectly
> reported by HW and thus, useless.
>
> As RX length error statistics are shown to the
> end user when requested, the values reported
> are misleading.
>
> Thus, that value is no longer reported and
> doesn't count anymore when adding all rx errors.
>
> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
> Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Applied, however, shouldn't this have been a v2?
https://lore.kernel.org/intel-wired-lan/20231120112726.149409-1-jan.sokolowski@intel.com/
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic
2023-12-06 10:43 Jan Sokolowski
2023-12-07 23:33 ` Tony Nguyen
@ 2023-12-11 4:58 ` Pucha, HimasekharX Reddy
1 sibling, 0 replies; 7+ messages in thread
From: Pucha, HimasekharX Reddy @ 2023-12-11 4:58 UTC (permalink / raw)
To: Sokolowski, Jan, intel-wired-lan@lists.osuosl.org
Cc: Sokolowski, Jan, Polchlopek, Mateusz
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Jan Sokolowski
> Sent: Wednesday, December 6, 2023 4:14 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Sokolowski, Jan <jan.sokolowski@intel.com>; Polchlopek, Mateusz <mateusz.polchlopek@intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic
>
> It was found that this statistic is incorrectly
> reported by HW and thus, useless.
>
> As RX length error statistics are shown to the
> end user when requested, the values reported
> are misleading.
>
> Thus, that value is no longer reported and
> doesn't count anymore when adding all rx errors.
>
> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
> Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 -
> drivers/net/ethernet/intel/ice/ice_main.c | 5 -----
> drivers/net/ethernet/intel/ice/ice_type.h | 1 -
> 3 files changed, 7 deletions(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-12-11 4:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-20 11:27 [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic Jan Sokolowski
2023-11-20 21:48 ` Jacob Keller
2023-11-29 10:26 ` Sokolowski, Jan
2023-11-29 11:03 ` Przemek Kitszel
-- strict thread matches above, loose matches on Subject: below --
2023-12-06 10:43 Jan Sokolowski
2023-12-07 23:33 ` Tony Nguyen
2023-12-11 4:58 ` Pucha, HimasekharX Reddy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox