Re: [Intel-wired-lan] [PATCH iwl-next v3 3/3] ixgbe: Cleanup after type convertion

[Paul Menzel <pmenzel@molgen.mpg.de>]

Dear Jedrzej,


Thank you for your patch. Two nits regarding the commit message. For the 
summary: *Clean up* after type conver*s*ion.

Am 18.01.24 um 14:43 schrieb Jedrzej Jagielski:> Clean up code where 
touched during type convertion by the patch

1.  Clean up the code, touched during …
2.  conver*s*ion

> 8035560dbfaf. Rearrange to fix reverse Christmas tree.

Is re-arranging the only thing done by the patch? Maybe that should be 
the commit message summary/title then.


Kind regards,

Paul


> Suggested-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
>   .../net/ethernet/intel/ixgbe/ixgbe_82598.c    | 14 ++--
>   .../net/ethernet/intel/ixgbe/ixgbe_82599.c    | 40 +++++------
>   .../net/ethernet/intel/ixgbe/ixgbe_common.c   | 66 +++++++++----------
>   .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  |  2 +-
>   drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c  | 54 +++++++--------
>   drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 12 ++--
>   drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 50 +++++++-------
>   7 files changed, 119 insertions(+), 119 deletions(-)

[…]