Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
	<intel-wired-lan@lists.osuosl.org>
Cc: Jacob Keller <jacob.e.keller@intel.com>, netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to int
Date: Mon, 22 Jan 2024 13:18:57 -0800	[thread overview]
Message-ID: <e1fc9c7e-20fd-76ac-15e5-b50dcfc1ae9d@intel.com> (raw)
In-Reply-To: <20240118134332.470907-1-jedrzej.jagielski@intel.com>



On 1/18/2024 5:43 AM, Jedrzej Jagielski wrote:
> Currently big amount of the functions returning standard error codes
> are of type s32. Convert them to regular ints as typdefs here are not
> necessary to return standard error codes.
> 
> Suggested-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>

There's various checkpatch issues being reported:

CHECK: Alignment should match open parenthesis
ERROR: space prohibited before that ',' (ctx:WxW)
WARNING: please, no space before tabs

Seems like a number of these can be remedied.

Thanks,
Tony

  parent reply	other threads:[~2024-01-22 21:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 13:43 [Intel-wired-lan] [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to int Jedrzej Jagielski
2024-01-18 13:43 ` [Intel-wired-lan] [PATCH iwl-next v3 2/3] ixgbe: Fix smatch warnings after type convertion Jedrzej Jagielski
2024-01-18 14:02   ` Dan Carpenter
2024-01-18 13:43 ` [Intel-wired-lan] [PATCH iwl-next v3 3/3] ixgbe: Cleanup " Jedrzej Jagielski
2024-01-18 14:28   ` Paul Menzel
2024-01-18 14:33   ` Przemek Kitszel
2024-01-24 12:34     ` Jagielski, Jedrzej
2024-01-19 16:02   ` Simon Horman
2024-01-20  6:06   ` kernel test robot
2024-01-20  8:16   ` kernel test robot
2024-01-22 21:18 ` Tony Nguyen [this message]
2024-01-25 10:16   ` [Intel-wired-lan] [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to int Jagielski, Jedrzej
2024-01-25 19:31     ` Tony Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1fc9c7e-20fd-76ac-15e5-b50dcfc1ae9d@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jedrzej.jagielski@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox