From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 3/3] ixgbe: Cleanup after type convertion
Date: Thu, 18 Jan 2024 15:33:37 +0100 [thread overview]
Message-ID: <b88cb347-9133-42f2-b41c-62f53666c488@intel.com> (raw)
In-Reply-To: <20240118134332.470907-3-jedrzej.jagielski@intel.com>
On 1/18/24 14:43, Jedrzej Jagielski wrote:
> Clean up code where touched during type convertion by the patch
> 8035560dbfaf. Rearrange to fix reverse Christmas tree
I don't see this SHA in my copy, please fix it.
>
> Suggested-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
> .../net/ethernet/intel/ixgbe/ixgbe_82598.c | 14 ++--
> .../net/ethernet/intel/ixgbe/ixgbe_82599.c | 40 +++++------
> .../net/ethernet/intel/ixgbe/ixgbe_common.c | 66 +++++++++----------
> .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 54 +++++++--------
> drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 12 ++--
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 50 +++++++-------
> 7 files changed, 119 insertions(+), 119 deletions(-)
>
code changes are fine,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
next prev parent reply other threads:[~2024-01-18 14:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 13:43 [Intel-wired-lan] [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to int Jedrzej Jagielski
2024-01-18 13:43 ` [Intel-wired-lan] [PATCH iwl-next v3 2/3] ixgbe: Fix smatch warnings after type convertion Jedrzej Jagielski
2024-01-18 14:02 ` Dan Carpenter
2024-01-18 13:43 ` [Intel-wired-lan] [PATCH iwl-next v3 3/3] ixgbe: Cleanup " Jedrzej Jagielski
2024-01-18 14:28 ` Paul Menzel
2024-01-18 14:33 ` Przemek Kitszel [this message]
2024-01-24 12:34 ` Jagielski, Jedrzej
2024-01-19 16:02 ` Simon Horman
2024-01-20 6:06 ` kernel test robot
2024-01-20 8:16 ` kernel test robot
2024-01-22 21:18 ` [Intel-wired-lan] [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to int Tony Nguyen
2024-01-25 10:16 ` Jagielski, Jedrzej
2024-01-25 19:31 ` Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b88cb347-9133-42f2-b41c-62f53666c488@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jedrzej.jagielski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox