[Intel-wired-lan] [PATCH iwl-net v2] igc: Remove delay during TX ring configuration

[Intel-wired-lan] [PATCH iwl-net v2] igc: Remove delay during TX ring configuration

[Muhammad Husaini Zulkifli]

Remove unnecessary delay during the TX ring configuration.
This will cause delay, especially during link down and
link up activity.

Furthermore, old SKUs like as I225 will call the reset_adapter
to reset the controller during TSN mode Gate Control List (GCL)
setting. This will add more time to the configuration of the
real-time use case.

It doesn't mentioned about this delay in the Software User Manual.
It might have been ported from legacy code I210 in the past.

Fixes: 13b5b7fd6a4a ("igc: Add support for Tx/Rx rings")
Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>

---
V1 -> V2: Update commit message.
---
---
 drivers/net/ethernet/intel/igc/igc_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index d1e8a5eee811b..a65ddddcda5d0 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -711,7 +711,6 @@ static void igc_configure_tx_ring(struct igc_adapter *adapter,
 	/* disable the queue */
 	wr32(IGC_TXDCTL(reg_idx), 0);
 	wrfl();
-	mdelay(10);
 
 	wr32(IGC_TDLEN(reg_idx),
 	     ring->count * sizeof(union igc_adv_tx_desc));
-- 
2.17.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH iwl-net v2] igc: Remove delay during TX ring configuration

[Neftin, Sasha]

On 5/17/2023 03:18, Muhammad Husaini Zulkifli wrote:
> Remove unnecessary delay during the TX ring configuration.
> This will cause delay, especially during link down and
> link up activity.
> 
> Furthermore, old SKUs like as I225 will call the reset_adapter
> to reset the controller during TSN mode Gate Control List (GCL)
> setting. This will add more time to the configuration of the
> real-time use case.
> 
> It doesn't mentioned about this delay in the Software User Manual.
> It might have been ported from legacy code I210 in the past.
> 
> Fixes: 13b5b7fd6a4a ("igc: Add support for Tx/Rx rings")
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> 
> ---
> V1 -> V2: Update commit message.
> ---
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index d1e8a5eee811b..a65ddddcda5d0 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -711,7 +711,6 @@ static void igc_configure_tx_ring(struct igc_adapter *adapter,
>   	/* disable the queue */
>   	wr32(IGC_TXDCTL(reg_idx), 0);
>   	wrfl();
> -	mdelay(10);
>   
>   	wr32(IGC_TDLEN(reg_idx),
>   	     ring->count * sizeof(union igc_adv_tx_desc));
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH iwl-net v2] igc: Remove delay during TX ring configuration

[naamax.meir]

On 5/17/2023 03:18, Muhammad Husaini Zulkifli wrote:
> Remove unnecessary delay during the TX ring configuration.
> This will cause delay, especially during link down and
> link up activity.
> 
> Furthermore, old SKUs like as I225 will call the reset_adapter
> to reset the controller during TSN mode Gate Control List (GCL)
> setting. This will add more time to the configuration of the
> real-time use case.
> 
> It doesn't mentioned about this delay in the Software User Manual.
> It might have been ported from legacy code I210 in the past.
> 
> Fixes: 13b5b7fd6a4a ("igc: Add support for Tx/Rx rings")
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> 
> ---
> V1 -> V2: Update commit message.
> ---
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 1 -
>   1 file changed, 1 deletion(-)

Tested-by: Naama Meir <naamax.meir@linux.intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan