From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: "Drewek, Wojciech" <wojciech.drewek@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next 06/12] ice: Add guard rule when creating FDB in switchdev
Date: Wed, 26 Apr 2023 17:24:58 +0200 [thread overview]
Message-ID: <97e4fc5a-85d2-3b46-12c3-7e893a3305d8@intel.com> (raw)
In-Reply-To: <MW4PR11MB577640D359484E99EB333D05FD659@MW4PR11MB5776.namprd11.prod.outlook.com>
From: Wojciech Drewek <wojciech.drewek@intel.com>
Date: Wed, 26 Apr 2023 11:50:56 +0200
>
>
>> -----Original Message-----
>> From: Drewek, Wojciech
>> Sent: wtorek, 25 kwietnia 2023 11:18
>> To: Lobakin, Aleksander <aleksander.lobakin@intel.com>
[...]
>>> guard_rule = ice_eswitch_...
>>> err = PTR_ERR(guard_rule);
>>> if (err) {
>>> ...
>>>
>>
>> I like it, less ptr <-> macros
>
> Actually it won't work, PTR_ERR would not convert pointer to 0 in case of success.
Ooops, PTR_ERR_OR_ZERO() then? I forgot there are several macros for
different cases =\
>
>>
>>>> + dev_err(dev, "Failed to create eswitch bridge %sgress guard rule, err: %d\n",
>>>> + port_type == ICE_ESWITCH_BR_UPLINK_PORT ? "e" : "in",
>>>> + err);
>>>
>>> You still can print it via "%pe" + @guard_rule instead of @err :p (same
>>> with @fwd_rule above)
[...]
Thanks,
Olek
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-04-26 15:25 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 9:34 [Intel-wired-lan] [PATCH net-next 00/12] ice: switchdev bridge offload Wojciech Drewek
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 01/12] ice: Minor switchdev fixes Wojciech Drewek
2023-04-19 14:35 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 02/12] ice: Remove exclusion code for RDMA+SRIOV Wojciech Drewek
2023-04-19 14:38 ` Alexander Lobakin
2023-04-25 15:26 ` Michal Schmidt
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 03/12] ice: Unset src prune on uplink VSI Wojciech Drewek
2023-04-19 14:49 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 04/12] ice: Implement basic eswitch bridge setup Wojciech Drewek
2023-04-19 15:23 ` Alexander Lobakin
2023-04-20 9:54 ` Drewek, Wojciech
2023-04-20 10:46 ` Drewek, Wojciech
2023-04-20 16:53 ` Alexander Lobakin
2023-04-20 16:51 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 05/12] ice: Switchdev FDB events support Wojciech Drewek
2023-04-19 15:38 ` Alexander Lobakin
2023-04-20 11:27 ` Drewek, Wojciech
2023-04-20 16:59 ` Alexander Lobakin
2023-04-21 8:45 ` Drewek, Wojciech
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 06/12] ice: Add guard rule when creating FDB in switchdev Wojciech Drewek
2023-04-21 14:22 ` Alexander Lobakin
2023-04-25 9:17 ` Drewek, Wojciech
2023-04-26 9:50 ` Drewek, Wojciech
2023-04-26 15:24 ` Alexander Lobakin [this message]
2023-04-27 7:24 ` Drewek, Wojciech
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 07/12] ice: Accept LAG netdevs in bridge offloads Wojciech Drewek
2023-04-21 14:40 ` Alexander Lobakin
2023-04-26 11:31 ` Drewek, Wojciech
2023-04-26 15:31 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 08/12] ice: Add VLAN FDB support in switchdev mode Wojciech Drewek
2023-04-21 15:25 ` Alexander Lobakin
2023-04-27 10:28 ` Drewek, Wojciech
2023-05-08 14:09 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 09/12] ice: implement bridge port vlan Wojciech Drewek
2023-04-21 16:35 ` Alexander Lobakin
2023-05-09 11:25 ` Drewek, Wojciech
2023-05-09 15:06 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 10/12] ice: implement static version of ageing Wojciech Drewek
2023-04-21 16:22 ` Alexander Lobakin
2023-05-09 10:55 ` Drewek, Wojciech
2023-05-09 14:55 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 11/12] ice: add tracepoints for the switchdev bridge Wojciech Drewek
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 12/12] ice: Ethtool fdb_cnt stats Wojciech Drewek
2023-04-21 16:32 ` Alexander Lobakin
2023-05-09 12:52 ` Drewek, Wojciech
2023-05-09 15:14 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97e4fc5a-85d2-3b46-12c3-7e893a3305d8@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox