From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH net-next 02/12] ice: Remove exclusion code for RDMA+SRIOV
Date: Wed, 19 Apr 2023 16:38:35 +0200 [thread overview]
Message-ID: <f40f823f-c9d2-331d-71ee-d9f28f7d6177@intel.com> (raw)
In-Reply-To: <20230417093412.12161-3-wojciech.drewek@intel.com>
From: Wojciech Drewek <wojciech.drewek@intel.com>
Date: Mon, 17 Apr 2023 11:34:02 +0200
> From: Dave Ertman <david.m.ertman@intel.com>
>
> There was a change previously to stop SR-IOV and LAG from existing on the
> same interface. This was to prevent the violation of LACP (Link
> Aggregation Control Protocol). The method to achieve this was to add a
> no-op Rx handler onto the netdev when SR-IOV VFs were present, thus
> blocking bonding, bridging, etc from claiming the interface by adding
> its own Rx handler. Also, when an interface was added into a aggregate,
> then the SR-IOV capability was set to false.
[...]
> diff --git a/drivers/net/ethernet/intel/ice/ice_lag.h b/drivers/net/ethernet/intel/ice/ice_lag.h
> index 51b5cf467ce2..0bd6b96d7e01 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lag.h
> +++ b/drivers/net/ethernet/intel/ice/ice_lag.h
> @@ -29,59 +29,9 @@ struct ice_lag {
> /* each thing blocking bonding will increment this value by one.
> * If this value is zero, then bonding is allowed.
> */
^ this comment block actually belongs to @dis_lag, so it also needs to
be removed.
> - u16 dis_lag;
> u8 role;
> };
>
> int ice_init_lag(struct ice_pf *pf);
> void ice_deinit_lag(struct ice_pf *pf);
> -rx_handler_result_t ice_lag_nop_handler(struct sk_buff **pskb);
[...]
Thanks,
Olek
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-04-19 14:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 9:34 [Intel-wired-lan] [PATCH net-next 00/12] ice: switchdev bridge offload Wojciech Drewek
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 01/12] ice: Minor switchdev fixes Wojciech Drewek
2023-04-19 14:35 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 02/12] ice: Remove exclusion code for RDMA+SRIOV Wojciech Drewek
2023-04-19 14:38 ` Alexander Lobakin [this message]
2023-04-25 15:26 ` Michal Schmidt
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 03/12] ice: Unset src prune on uplink VSI Wojciech Drewek
2023-04-19 14:49 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 04/12] ice: Implement basic eswitch bridge setup Wojciech Drewek
2023-04-19 15:23 ` Alexander Lobakin
2023-04-20 9:54 ` Drewek, Wojciech
2023-04-20 10:46 ` Drewek, Wojciech
2023-04-20 16:53 ` Alexander Lobakin
2023-04-20 16:51 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 05/12] ice: Switchdev FDB events support Wojciech Drewek
2023-04-19 15:38 ` Alexander Lobakin
2023-04-20 11:27 ` Drewek, Wojciech
2023-04-20 16:59 ` Alexander Lobakin
2023-04-21 8:45 ` Drewek, Wojciech
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 06/12] ice: Add guard rule when creating FDB in switchdev Wojciech Drewek
2023-04-21 14:22 ` Alexander Lobakin
2023-04-25 9:17 ` Drewek, Wojciech
2023-04-26 9:50 ` Drewek, Wojciech
2023-04-26 15:24 ` Alexander Lobakin
2023-04-27 7:24 ` Drewek, Wojciech
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 07/12] ice: Accept LAG netdevs in bridge offloads Wojciech Drewek
2023-04-21 14:40 ` Alexander Lobakin
2023-04-26 11:31 ` Drewek, Wojciech
2023-04-26 15:31 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 08/12] ice: Add VLAN FDB support in switchdev mode Wojciech Drewek
2023-04-21 15:25 ` Alexander Lobakin
2023-04-27 10:28 ` Drewek, Wojciech
2023-05-08 14:09 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 09/12] ice: implement bridge port vlan Wojciech Drewek
2023-04-21 16:35 ` Alexander Lobakin
2023-05-09 11:25 ` Drewek, Wojciech
2023-05-09 15:06 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 10/12] ice: implement static version of ageing Wojciech Drewek
2023-04-21 16:22 ` Alexander Lobakin
2023-05-09 10:55 ` Drewek, Wojciech
2023-05-09 14:55 ` Alexander Lobakin
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 11/12] ice: add tracepoints for the switchdev bridge Wojciech Drewek
2023-04-17 9:34 ` [Intel-wired-lan] [PATCH net-next 12/12] ice: Ethtool fdb_cnt stats Wojciech Drewek
2023-04-21 16:32 ` Alexander Lobakin
2023-05-09 12:52 ` Drewek, Wojciech
2023-05-09 15:14 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f40f823f-c9d2-331d-71ee-d9f28f7d6177@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox