[Intel-wired-lan] [PATCH net v1] ice: Fix DSCP PFC TLV creation

[Intel-wired-lan] [PATCH net v1] ice: Fix DSCP PFC TLV creation

[Karen Ostrowska]

From: Dave Ertman <david.m.ertman@intel.com>

When creating the TLV to send to the FW for configuring DSCP
mode PFC, the PFCENABLE field was being masked with a 4 bit
mask (0xF), but this is an 8 bit bitmask for enabled classes
for PFC.  This means that traffic classes 4-7 could not be
enabled for PFC.

Remove the mask completely, as it is not necessary, as we are
assigning 8bits to an 8 bit field.

Fixes: 2a87bd73e50d("ice: Add DSCP support")
Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
Signed-off-by: Karen Ostrowska <karen.ostrowska@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_dcb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_dcb.c b/drivers/net/ethernet/intel/ice/ice_dcb.c
index 6be02f9b0b8c..789b99963910 100644
--- a/drivers/net/ethernet/intel/ice/ice_dcb.c
+++ b/drivers/net/ethernet/intel/ice/ice_dcb.c
@@ -1372,7 +1372,7 @@ ice_add_dscp_pfc_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
 	tlv->ouisubtype = htonl(ouisubtype);
 
 	buf[0] = dcbcfg->pfc.pfccap & 0xF;
-	buf[1] = dcbcfg->pfc.pfcena & 0xF;
+	buf[1] = dcbcfg->pfc.pfcena;
 }
 
 /**
-- 
2.31.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1] ice: Fix DSCP PFC TLV creation

[Tony Nguyen]

[-- Attachment #1.1: Type: text/plain, Size: 1492 bytes --]

On 1/25/2023 8:01 AM, Karen Ostrowska wrote:
> From: Dave Ertman<david.m.ertman@intel.com>
>
> When creating the TLV to send to the FW for configuring DSCP
> mode PFC, the PFCENABLE field was being masked with a 4 bit
> mask (0xF), but this is an 8 bit bitmask for enabled classes
> for PFC.  This means that traffic classes 4-7 could not be
> enabled for PFC.
>
> Remove the mask completely, as it is not necessary, as we are
> assigning 8bits to an 8 bit field.
>
> Fixes: 2a87bd73e50d("ice: Add DSCP support")

Fixes tag: Fixes: 2a87bd73e50d("ice: Add DSCP support")

Has these problem(s):

- missing space between the SHA1 and the subject

> Signed-off-by: Dave Ertman<david.m.ertman@intel.com>
> Signed-off-by: Karen Ostrowska<karen.ostrowska@intel.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_dcb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_dcb.c b/drivers/net/ethernet/intel/ice/ice_dcb.c
> index 6be02f9b0b8c..789b99963910 100644
> --- a/drivers/net/ethernet/intel/ice/ice_dcb.c
> +++ b/drivers/net/ethernet/intel/ice/ice_dcb.c
> @@ -1372,7 +1372,7 @@ ice_add_dscp_pfc_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
>   	tlv->ouisubtype = htonl(ouisubtype);
>   
>   	buf[0] = dcbcfg->pfc.pfccap & 0xF;
> -	buf[1] = dcbcfg->pfc.pfcena & 0xF;
> +	buf[1] = dcbcfg->pfc.pfcena;

Also, I don't believe I saw a response to Michal's question:

What about pfc.pfccap? Shouldn't we also remove the mask?

[-- Attachment #1.2: Type: text/html, Size: 73596 bytes --]

[-- Attachment #2: Type: text/plain, Size: 162 bytes --]

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1] ice: Fix DSCP PFC TLV creation

[Paul Menzel]

Dear Karen,


Thank you for the patch.

Am 25.01.23 um 17:01 schrieb Karen Ostrowska:
> From: Dave Ertman <david.m.ertman@intel.com>
> 
> When creating the TLV to send to the FW for configuring DSCP
> mode PFC, the PFCENABLE field was being masked with a 4 bit
> mask (0xF), but this is an 8 bit bitmask for enabled classes
> for PFC.  This means that traffic classes 4-7 could not be
> enabled for PFC.
> 
> Remove the mask completely, as it is not necessary, as we are
> assigning 8bits to an 8 bit field.

Please reflow the text to use the full 75 characters of allowed text width.

Please add a space in “8 bits”.

> Fixes: 2a87bd73e50d("ice: Add DSCP support")

Please add a space after the commit hash before the (.

> Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
> Signed-off-by: Karen Ostrowska <karen.ostrowska@intel.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_dcb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_dcb.c b/drivers/net/ethernet/intel/ice/ice_dcb.c
> index 6be02f9b0b8c..789b99963910 100644
> --- a/drivers/net/ethernet/intel/ice/ice_dcb.c
> +++ b/drivers/net/ethernet/intel/ice/ice_dcb.c
> @@ -1372,7 +1372,7 @@ ice_add_dscp_pfc_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
>   	tlv->ouisubtype = htonl(ouisubtype);
>   
>   	buf[0] = dcbcfg->pfc.pfccap & 0xF;
> -	buf[1] = dcbcfg->pfc.pfcena & 0xF;
> +	buf[1] = dcbcfg->pfc.pfcena;
>   }
>   
>   /**


Kind regards,

Paul
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

[Intel-wired-lan] [PATCH net v1] ice: Fix DSCP PFC TLV creation

[Karen Ostrowska]

From: Dave Ertman <david.m.ertman@intel.com>

When creating the TLV to send to the FW for configuring DSCP mode PFC,the 
PFCENABLE field was being masked with a 4 bit mask (0xF), but this is an 8
bit bitmask for enabled classes for PFC.  This means that traffic classes 
4-7 could not be enabled for PFC.

Remove the mask completely, as it is not necessary, as we are assigning 8 
bits to an 8 bit field.

Fixes: 2a87bd73e50d ("ice: Add DSCP support")
Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
Signed-off-by: Karen Ostrowska <karen.ostrowska@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_dcb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_dcb.c b/drivers/net/ethernet/intel/ice/ice_dcb.c
index 6be02f9b0b8c..789b99963910 100644
--- a/drivers/net/ethernet/intel/ice/ice_dcb.c
+++ b/drivers/net/ethernet/intel/ice/ice_dcb.c
@@ -1372,7 +1372,7 @@ ice_add_dscp_pfc_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
 	tlv->ouisubtype = htonl(ouisubtype);
 
 	buf[0] = dcbcfg->pfc.pfccap & 0xF;
-	buf[1] = dcbcfg->pfc.pfcena & 0xF;
+	buf[1] = dcbcfg->pfc.pfcena;
 }
 
 /**
-- 
2.31.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1] ice: Fix DSCP PFC TLV creation

[Ertman, David M]

> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Tony Nguyen
> Sent: Wednesday, January 25, 2023 3:36 PM
> To: Ostrowska, Karen <karen.ostrowska@intel.com>; intel-wired-lan@lists.osuosl.org; michal.swiatkowski@linux.intel.com
> Subject: Re: [Intel-wired-lan] [PATCH net v1] ice: Fix DSCP PFC TLV creation

...
> >	buf[0] = dcbcfg->pfc.pfccap & 0xF;
> > -	buf[1] = dcbcfg->pfc.pfcena & 0xF;
> > +	buf[1] = dcbcfg->pfc.pfcena;
> Also, I don't believe I saw a response to Michal's question:
> What about pfc.pfccap? Shouldn't we also remove the mask?

pfc.pfccap is not a bitmap like pfc.pfcena is.  pfc.pfccap is a count value 0-8, so any
value in the upper 4 bits is not desirable.

DaveE
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1] ice: Fix DSCP PFC TLV creation

[Tony Nguyen]

On 1/27/2023 5:24 AM, Karen Ostrowska wrote:
> From: Dave Ertman <david.m.ertman@intel.com>
> 
> When creating the TLV to send to the FW for configuring DSCP mode PFC,the
> PFCENABLE field was being masked with a 4 bit mask (0xF), but this is an 8
> bit bitmask for enabled classes for PFC.  This means that traffic classes
> 4-7 could not be enabled for PFC.
> 
> Remove the mask completely, as it is not necessary, as we are assigning 8
> bits to an 8 bit field.
> 
> Fixes: 2a87bd73e50d ("ice: Add DSCP support")
> Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
> Signed-off-by: Karen Ostrowska <karen.ostrowska@intel.com>
> ---

Applied, however, this should be a v2 (with changelog)

>   drivers/net/ethernet/intel/ice/ice_dcb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_dcb.c b/drivers/net/ethernet/intel/ice/ice_dcb.c
> index 6be02f9b0b8c..789b99963910 100644
> --- a/drivers/net/ethernet/intel/ice/ice_dcb.c
> +++ b/drivers/net/ethernet/intel/ice/ice_dcb.c
> @@ -1372,7 +1372,7 @@ ice_add_dscp_pfc_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
>   	tlv->ouisubtype = htonl(ouisubtype);
>   
>   	buf[0] = dcbcfg->pfc.pfccap & 0xF;
> -	buf[1] = dcbcfg->pfc.pfcena & 0xF;
> +	buf[1] = dcbcfg->pfc.pfcena;
>   }
>   
>   /**
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1] ice: Fix DSCP PFC TLV creation

[G, GurucharanX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Karen Ostrowska
> Sent: Friday, January 27, 2023 6:54 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Ostrowska, Karen <karen.ostrowska@intel.com>
> Subject: [Intel-wired-lan] [PATCH net v1] ice: Fix DSCP PFC TLV creation
> 
> From: Dave Ertman <david.m.ertman@intel.com>
> 
> When creating the TLV to send to the FW for configuring DSCP mode PFC,the
> PFCENABLE field was being masked with a 4 bit mask (0xF), but this is an 8 bit
> bitmask for enabled classes for PFC.  This means that traffic classes
> 4-7 could not be enabled for PFC.
> 
> Remove the mask completely, as it is not necessary, as we are assigning 8 bits
> to an 8 bit field.
> 
> Fixes: 2a87bd73e50d ("ice: Add DSCP support")
> Signed-off-by: Dave Ertman <david.m.ertman@intel.com>
> Signed-off-by: Karen Ostrowska <karen.ostrowska@intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_dcb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan