From: Jacob Keller <jacob.e.keller@intel.com>
To: <intel-wired-lan@osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET
Date: Wed, 20 Sep 2023 16:24:13 -0700 [thread overview]
Message-ID: <dfdf2612-992a-86c0-bbb7-95077ab6fe88@intel.com> (raw)
In-Reply-To: <20230920180745.1607563-4-aleksander.lobakin@intel.com>
On 9/20/2023 11:07 AM, Alexander Lobakin wrote:
> When CONFIG_INET is not set, tcp_gro_complete is not compiled, although
> the drivers using it may still be compiled (spotted by Randy):
>
> aarch64-linux-ld: drivers/net/ethernet/intel/idpf/idpf_txrx.o:
> in function `idpf_rx_rsc.isra.0':
> drivers/net/ethernet/intel/idpf/idpf_txrx.c:2909:(.text+0x40cc):
> undefined reference to `tcp_gro_complete'
>
> The drivers need to guard the calls to it manually.
> Return early from the RSC completion function if !CONFIG_INET, it won't
> work properly either way. This effectively makes it be compiled-out
> almost entirely on such builds.
>
> Fixes: 3a8845af66ed ("idpf: add RX splitq napi poll support")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/linux-next/4c84eb7b-3dec-467b-934b-8a0240f7fb12@infradead.org
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> drivers/net/ethernet/intel/idpf/idpf_txrx.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> index 6fa79898c42c..aa45afeb6496 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> @@ -2876,6 +2876,9 @@ static int idpf_rx_rsc(struct idpf_queue *rxq, struct sk_buff *skb,
> if (unlikely(!(ipv4 ^ ipv6)))
> return -EINVAL;
>
> + if (!IS_ENABLED(CONFIG_INET))
> + return 0;
> +
> rsc_segments = DIV_ROUND_UP(skb->data_len, rsc_seg_len);
> if (unlikely(rsc_segments == 1))
> return 0;
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-09-20 23:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 18:07 [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors Alexander Lobakin
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 1/3] ice: fix undefined references to ice_is_*() when !CONFIG_PTP_1588_CLOCK Alexander Lobakin
2023-09-20 23:20 ` Jacob Keller
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 2/3] ice: fix undefined references from DPLL code " Alexander Lobakin
2023-09-20 23:22 ` Jacob Keller
2023-09-21 23:58 ` Vadim Fedorenko
2023-09-22 13:58 ` Alexander Lobakin
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET Alexander Lobakin
2023-09-20 21:30 ` Randy Dunlap
2023-09-21 0:04 ` Jacob Keller
2023-09-21 1:30 ` Randy Dunlap
2023-10-12 15:47 ` Randy Dunlap
2023-10-12 16:13 ` Alexander Lobakin
2023-10-12 18:34 ` Keller, Jacob E
2023-10-12 23:31 ` Jakub Kicinski
2023-10-13 17:16 ` Jacob Keller
2023-09-20 23:24 ` Jacob Keller [this message]
2023-09-20 23:31 ` [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors Jacob Keller
2023-09-21 12:52 ` Alexander Lobakin
2023-09-21 13:04 ` Alexander Lobakin
2023-09-21 8:52 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfdf2612-992a-86c0-bbb7-95077ab6fe88@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox