From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Alexander Lobakin <aleksander.lobakin@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jacob Keller <jacob.e.keller@intel.com>
Cc: Michal Michalik <michal.michalik@intel.com>,
netdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
linux-kernel@vger.kernel.org,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
intel-wired-lan@lists.osuosl.org,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Milena Olech <milena.olech@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next 2/3] ice: fix undefined references from DPLL code when !CONFIG_PTP_1588_CLOCK
Date: Fri, 22 Sep 2023 00:58:04 +0100 [thread overview]
Message-ID: <e5022460-fc45-5571-1f5b-2b81f7811a7d@linux.dev> (raw)
In-Reply-To: <20230920180745.1607563-3-aleksander.lobakin@intel.com>
On 20/09/2023 19:07, Alexander Lobakin wrote:
> DPLL code in ice unconditionally calls several PTP functions which are
> only built when CONFIG_PTP_1588_CLOCK is set. This throws a good bunch
> of link errors:
>
> ERROR: modpost: "ice_cgu_get_pin_name"
> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_get_cgu_state"
> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> OR: modpost: "ice_is_cgu_present"
> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_get_cgu_rclk_pin_info"
> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_cgu_get_pin_type"
> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_cgu_get_pin_freq_supp"
> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
>
> ice_dpll_{,de}init() can be only called at runtime when the
> corresponding feature flags are set, which is not the case when PTP
> support is not compiled. However, the linker has no clue about this.
> Compile DPLL code only when CONFIG_PTP_1588_CLOCK is enabled and guard
> the mentioned init/deinit function calls, so that ice_dpll.o is only
> referred when it gets compiled.
>
> Note that ideally ice_is_feature_supported() needs to check for
> compile-time flags first to be able to handle this without any
> additional call guards, and we may want to do that in the future.
>
There is another fix under review [1], which came from Jacob.
It converts the code a bit more, and will create conflicts.
I would suggest to drop this patch until another series is fully
reviewed.
[1]
https://lore.kernel.org/netdev/20230921000633.1238097-1-jacob.e.keller@intel.com/
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-09-21 23:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 18:07 [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors Alexander Lobakin
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 1/3] ice: fix undefined references to ice_is_*() when !CONFIG_PTP_1588_CLOCK Alexander Lobakin
2023-09-20 23:20 ` Jacob Keller
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 2/3] ice: fix undefined references from DPLL code " Alexander Lobakin
2023-09-20 23:22 ` Jacob Keller
2023-09-21 23:58 ` Vadim Fedorenko [this message]
2023-09-22 13:58 ` Alexander Lobakin
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET Alexander Lobakin
2023-09-20 21:30 ` Randy Dunlap
2023-09-21 0:04 ` Jacob Keller
2023-09-21 1:30 ` Randy Dunlap
2023-10-12 15:47 ` Randy Dunlap
2023-10-12 16:13 ` Alexander Lobakin
2023-10-12 18:34 ` Keller, Jacob E
2023-10-12 23:31 ` Jakub Kicinski
2023-10-13 17:16 ` Jacob Keller
2023-09-20 23:24 ` Jacob Keller
2023-09-20 23:31 ` [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors Jacob Keller
2023-09-21 12:52 ` Alexander Lobakin
2023-09-21 13:04 ` Alexander Lobakin
2023-09-21 8:52 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5022460-fc45-5571-1f5b-2b81f7811a7d@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.michalik@intel.com \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox