Re: [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors

[Jacob Keller <jacob.e.keller@intel.com>]

On 9/20/2023 11:07 AM, Alexander Lobakin wrote:
> Recently, several link-time issues were spotted in the ethernet/intel/
> folder thanks to Kbuild bots and linux-next.
> The fixes are pretty straightforward, just some stubs and CONFIG_*
> guards, so resolve all of them in one shot and unbreak randconfig
> builds.
> 
> Alexander Lobakin (3):
>   ice: fix undefined references to ice_is_*() when
>     !CONFIG_PTP_1588_CLOCK
>   ice: fix undefined references from DPLL code when
>     !CONFIG_PTP_1588_CLOCK
>   idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET
> 
>  drivers/net/ethernet/intel/ice/Makefile     |  5 ++---
>  drivers/net/ethernet/intel/ice/ice_main.c   |  8 ++++---
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 25 ++++++++++++++++++++-
>  drivers/net/ethernet/intel/idpf/idpf_txrx.c |  3 +++
>  4 files changed, 34 insertions(+), 7 deletions(-)
> 
> ---
> Directly to netdev/net-next, build bots are not happy and the next
> linux-next is approaching :s

I had alternative fixes for ice at:

https://lore.kernel.org/intel-wired-lan/20230919233435.518620-1-jacob.e.keller@intel.com/

that are slightly more invasive but bring things in line with changes I
had proposed earlier before the DPLL code got merged. See:

https://lore.kernel.org/intel-wired-lan/20230919233435.518620-1-jacob.e.keller@intel.com/

I'd obviously prefer my version of the ice changes, but I understand if
we prefer a simple more 'obvious' fix be merged now. I can spin my
changes again to cleanup/refactor in a follow up if necessary.

Thanks,
Jake
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan