Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Fix memory leak on xe_alloc_pf_queue failure
@ 2024-08-22  8:13 Nirmoy Das
  2024-08-22  8:52 ` Matthew Auld
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Nirmoy Das @ 2024-08-22  8:13 UTC (permalink / raw)
  To: intel-xe
  Cc: Nirmoy Das, Matthew Auld, Matthew Brost, Rodrigo Vivi,
	Stuart Summers

Free up previously allocated pf_queue[i].data on error.

Fixes: 3338e4f90c14 ("drm/xe: Use topology to determine page fault queue size")
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Stuart Summers <stuart.summers@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_gt_pagefault.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c b/drivers/gpu/drm/xe/xe_gt_pagefault.c
index 0be4687bfc20..c19944eed5bd 100644
--- a/drivers/gpu/drm/xe/xe_gt_pagefault.c
+++ b/drivers/gpu/drm/xe/xe_gt_pagefault.c
@@ -437,9 +437,13 @@ int xe_gt_pagefault_init(struct xe_gt *gt)
 
 	for (i = 0; i < NUM_PF_QUEUE; ++i) {
 		ret = xe_alloc_pf_queue(gt, &gt->usm.pf_queue[i]);
-		if (ret)
+		if (ret) {
+			while (i-- > 0)
+				kfree(gt->usm.pf_queue[i].data);
 			return ret;
+		}
 	}
+
 	for (i = 0; i < NUM_ACC_QUEUE; ++i) {
 		gt->usm.acc_queue[i].gt = gt;
 		spin_lock_init(&gt->usm.acc_queue[i].lock);
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-08-22 12:52 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-22  8:13 [PATCH] drm/xe: Fix memory leak on xe_alloc_pf_queue failure Nirmoy Das
2024-08-22  8:52 ` Matthew Auld
2024-08-22  9:10   ` Nirmoy Das
2024-08-22  8:52 ` ✓ CI.Patch_applied: success for " Patchwork
2024-08-22  8:53 ` ✓ CI.checkpatch: " Patchwork
2024-08-22  8:54 ` ✓ CI.KUnit: " Patchwork
2024-08-22  9:06 ` ✓ CI.Build: " Patchwork
2024-08-22  9:08 ` ✓ CI.Hooks: " Patchwork
2024-08-22  9:11 ` ✓ CI.checksparse: " Patchwork
2024-08-22  9:30 ` ✓ CI.BAT: " Patchwork
2024-08-22 12:52 ` ✗ CI.FULL: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox