Re: [Intel-xe] [RFC v2 1/6] drm/xe/xe2: Support flat ccs.

["Thomas Hellström" <thomas.hellstrom@linux.intel.com>]

Hi,

On Tue, 2023-11-21 at 15:39 +0530, Himal Prasad Ghimiray wrote:
> Enable flat ccs for XE2_GFX_FEATURES.
> 
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Signed-off-by: Himal Prasad Ghimiray
> <himal.prasad.ghimiray@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Typically you add the implementation first and then enable it, so this
patch should go last. (Rule is the driver should not misbehave if
bisecting lands in the middle of a patch series).

/Thomas



> 
> diff --git a/drivers/gpu/drm/xe/xe_pci.c
> b/drivers/gpu/drm/xe/xe_pci.c
> index 682ba188e456..d9754f3d45f7 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -157,7 +157,7 @@ static const struct xe_graphics_desc
> graphics_xelpg = {
>  #define XE2_GFX_FEATURES \
>         .dma_mask_size = 46, \
>         .has_asid = 1, \
> -       .has_flat_ccs = 0 /* FIXME: implementation missing */, \
> +       .has_flat_ccs = 1, \
>         .has_range_tlb_invalidation = 1, \
>         .supports_usm = 0 /* FIXME: implementation missing */, \
>         .va_bits = 48, \