Re: [PATCH 0/6] drm/xe/xe_guc_ct: Prevent compiler read/write optimization breaks

["Summers, Stuart" <stuart.summers@intel.com>]

On Thu, 2025-12-18 at 15:35 +0000, Jonathan Cavitt wrote:
> Use READ_ONCE and WRITE_ONCE when operating on ct->state and the
> g2h_fence->done values to prevent the compiler from ignoring these
> necessary operations.
> 
> v2: (Matt Brost)
> - Add Fixes tags
> - Add comments
> 
> v3:
> - Split into multiple patches (Rodrigo Vivi)

Is there a reason we aren't combining the like-parameters at least into
a single patch? It doesn't look right splitting the READS and WRITES
into separate ones.

Thanks,
Stuart

> 
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
> Suggested-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> 
> Jonathan Cavitt (6):
>   drm/xe/xe_guc_ct: WRITE_ONCE g2h_fence done in g2h_fence_cancel
>   drm/xe/xe_guc_ct: WRITE_ONCE g2h_fence done in parse_g2h_response
>   drm/xe/xe_guc_ct: WRITE_ONCE ct state in guc_ct_change_state
>   drm/xe/xe_guc_ct: READ_ONCE ct state in xe_guc_ct_initialized
>   drm/xe/xe_guc_ct: READ_ONCE ct state in xe_guc_ct_enabled
>   drm/xe/xe_guc_ct: Justify WRITE_ONCE/READ_ONCE usage
> 
>  drivers/gpu/drm/xe/xe_guc_ct.c | 14 +++++++++++---
>  drivers/gpu/drm/xe/xe_guc_ct.h |  6 ++++--
>  2 files changed, 15 insertions(+), 5 deletions(-)
>