Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 7/8] drm/xe: Enable unclaimed register detection on xe
Date: Wed, 18 Nov 2026 12:14:00 +0200	[thread overview]
Message-ID: <0f03330a05eaec97180540f2177c18f33a76a7c8@intel.com> (raw)
In-Reply-To: <20261113134355.14579-8-ville.syrjala@linux.intel.com>

On Fri, 13 Nov 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Now that the unclaimed register detection code no longer relies
> on the lock we can enable it on xe, without bringing the lock
> along for the ride.
>
> xe only supports TGL+ class hardware, so that's all we have
> to care about here.
>
> Note that mmio is hideously expensive on all MTL+ systems, and
> enabling mmio_debug on will make it worse due to all the extra
> FPGA_DBG reads. But during development/testing it can be a very
> useful tool.
>
> One weird thing here is that the default value for the modparam
> still comes from i915's CONFIG_DRM_I915_DEBUG_MMIO. So xe will
> only get the modparam turned on by default if i915 is also
> included in the build.

Yeah, we'll need to move a bunch of kconfigs around when we have the
kconfig file for display.

As the CI results indicate, this is a change we want, however in the
mean time can't enable it because it craps all over CI.

I'm sure you've got an idea what to do already, but on the idea,

Acked-by: Jani Nikula <jani.nikula@intel.com>

>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_de.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_de.c b/drivers/gpu/drm/i915/display/intel_de.c
> index 9e2f6ce0ff7e..9399db0d8e1b 100644
> --- a/drivers/gpu/drm/i915/display/intel_de.c
> +++ b/drivers/gpu/drm/i915/display/intel_de.c
> @@ -502,7 +502,7 @@ static const struct intel_mmio_funcs tgl_mmio_funcs = {
>  	.check_for_unclaimed_mmio = hsw_check_for_unclaimed_mmio,
>  };
>  
> -#define LNL_MMIO_FLAGS __MMIO_WAKELOCK
> +#define LNL_MMIO_FLAGS (__MMIO_WAKELOCK | __MMIO_UNCLAIMED)
>  
>  static u32 lnl_mmio_read(struct intel_display *display, intel_reg_t reg)
>  {
> @@ -519,6 +519,7 @@ static void lnl_mmio_write(struct intel_display *display, intel_reg_t reg, u32 v
>  static const struct intel_mmio_funcs lnl_mmio_funcs = {
>  	.read = lnl_mmio_read,
>  	.write = lnl_mmio_write,
> +	.check_for_unclaimed_mmio = hsw_check_for_unclaimed_mmio,
>  };
>  
>  static bool driver_is_i915(void)
> @@ -557,7 +558,7 @@ void intel_de_init(struct intel_display *display)
>  		if (DISPLAY_VER(display) >= 20)
>  			display->mmio.funcs = &lnl_mmio_funcs;
>  		else
> -			display->mmio.funcs = &i9xx_mmio_funcs;
> +			display->mmio.funcs = &tgl_mmio_funcs;
>  	}
>  
>  	if (display->mmio.funcs->check_for_unclaimed_mmio)

-- 
Jani Nikula, Intel

  reply	other threads:[~2026-11-18 10:14 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 13:43 [PATCH 0/8] drm/{i915, xe}: Make unclaimed mmio detection lockless and enable it for xe Ville Syrjala
2026-11-13 13:43 ` [PATCH 1/8] drm/i915/de: Uninline intel_de_{read,write}_fw() Ville Syrjala
2026-11-13 14:11   ` Jani Nikula
2026-11-13 13:43 ` [PATCH 2/8] drm/i915/de: Pimp the intel_de_{read,write}_fw() docs Ville Syrjala
2026-11-13 14:12   ` [PATCH 2/8] drm/i915/de: Pimp the intel_de_{read, write}_fw() docs Jani Nikula
2026-11-13 14:31     ` Ville Syrjälä
2026-11-18  9:45       ` Jani Nikula
2026-11-13 13:43 ` [PATCH 3/8] drm/i915/de: Flatten the unclaimed mmio code Ville Syrjala
2026-11-13 14:25   ` Jani Nikula
2026-11-13 13:43 ` [PATCH 4/8] drm/i915/de: Make mmio_debug lockless Ville Syrjala
2026-11-13 16:30   ` Ville Syrjälä
2026-11-18  9:46     ` Jani Nikula
2026-11-18 10:04   ` Jani Nikula
2026-11-13 13:43 ` [PATCH 5/8] drm/i915/de: Optimize the mmio_debug checks in intel_de_{read, write}() Ville Syrjala
2026-11-18 10:10   ` Jani Nikula
2026-11-13 13:43 ` [PATCH 6/8] drm/i915/de: Make display registers unlocked for TGL+ on i915 Ville Syrjala
2026-11-18 10:11   ` Jani Nikula
2026-11-13 13:43 ` [PATCH 7/8] drm/xe: Enable unclaimed register detection on xe Ville Syrjala
2026-11-18 10:14   ` Jani Nikula [this message]
2026-11-13 13:43 ` [PATCH 8/8] drm/i915/de: Nuke driver_is_i915() Ville Syrjala
2026-11-18 10:15   ` Jani Nikula
2026-11-13 14:33 ` ✗ CI.checkpatch: warning for drm/{i915, xe}: Make unclaimed mmio detection lockless and enable it for xe Patchwork
2026-11-13 14:35 ` ✓ CI.KUnit: success " Patchwork
2026-11-13 14:52 ` ✗ CI.checksparse: warning " Patchwork
2026-11-13 15:07 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-11-13 16:41   ` Ville Syrjälä
2026-11-14  0:50 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f03330a05eaec97180540f2177c18f33a76a7c8@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox